Hopefully fix the CD-ROM integration tests for real by performing all operations while the server is stopped

Author: Sam Stenvall

upcloud/service/service_test.go

@@ -354,13 +354,9 @@ func TestTemplatizeServerStorage(t *testing.T) {
 // - creates a server
 // - stops the server
 // - attaches a CD-ROM device
-// - starts the server
 // - loads a CD-ROM
-// - stops the server
 // - ejects the CD-ROM
-// - deletes the server
 func TestLoadEjectCDROM(t *testing.T) {
-	//t.Skip("Skipping test because the API returns a lot of GENERAL_FAILURE and CDROM_EJECT_FAILED errors")
 	if testing.Short() {
 		t.Skip("Skipping test in short mode")
 	}
@@ -385,24 +381,6 @@ func TestLoadEjectCDROM(t *testing.T) {
 	handleError(err)
 	t.Log("CD-ROM is now attached")
 
-	// Start the server
-	t.Logf("Starting server with UUID %s", serverDetails.UUID)
-	serverDetails, err = svc.StartServer(&request.StartServerRequest{
-		UUID:    serverDetails.UUID,
-		Timeout: time.Minute * 5,
-	})
-
-	handleError(err)
-
-	serverDetails, err = svc.WaitForServerState(&request.WaitForServerStateRequest{
-		UUID:         serverDetails.UUID,
-		DesiredState: upcloud.ServerStateStarted,
-		Timeout:      time.Minute * 5,
-	})
-
-	handleError(err)
-	t.Log("Server is now started")
-
 	// Load the CD-ROM
 	t.Log("Loading CD-ROM into CD-ROM device")
 	serverDetails, err = svc.LoadCDROM(&request.LoadCDROMRequest{
@@ -413,19 +391,6 @@ func TestLoadEjectCDROM(t *testing.T) {
 	handleError(err)
 	t.Log("CD-ROM is now loaded")
 
-	// Wait for the server to leave maintenance state before stopping it
-	t.Logf("Waiting for server with UUID %s to leave maintenance state ...", serverDetails.UUID)
-	serverDetails, err = svc.WaitForServerState(&request.WaitForServerStateRequest{
-		UUID:           serverDetails.UUID,
-		UndesiredState: upcloud.ServerStateMaintenance,
-		Timeout:        time.Minute * 5,
-	})
-	handleError(err)
-
-	// Stop the server (apparently the CD-ROM cannot be ejected while it's running)
-	t.Logf("Waiting for the server with UUID %s to stop ...", serverDetails.UUID)
-	stopServer(serverDetails.UUID)
-
 	// Eject the CD-ROM
 	t.Log("Ejecting CD-ROM from CD-ROM device")
 	serverDetails, err = svc.EjectCDROM(&request.EjectCDROMRequest{