Fix mutable argument defaults

Author: akx

upcloud_api/cloud_manager/object_storage_mixin.py

@@ -1,3 +1,5 @@
+from typing import List, Optional
+
 from upcloud_api.object_storage import ObjectStorage
 from upcloud_api.utils import convert_datetime_string_to_object
 
@@ -82,14 +84,14 @@ def get_object_storage_network_statistics(
         object_storage,
         datetime_from,
         datetime_to=None,
-        interval=None,
-        bucket=[],
-        filename=[],
-        method=[],
-        status=[],
-        group_by=[],
-        order_by=[],
-        limit=None,
+        interval: Optional[int] = None,
+        bucket: Optional[List[str]] = None,
+        filename: Optional[List[str]] = None,
+        method: Optional[List[str]] = None,
+        status: Optional[List[int]] = None,
+        group_by: Optional[List[str]] = None,
+        order_by: Optional[List[str]] = None,
+        limit: Optional[int] = None,
     ):
         """
         The network usage of an Object Storage device is metered and can be reviewed using the statistics request.

upcloud_api/cloud_manager/storage_mixin.py

@@ -37,11 +37,18 @@ def get_storage(self, storage):
         return Storage(cloud_manager=self, **res['storage'])
 
     def create_storage(
-        self, size=10, tier='maxiops', title='Storage disk', zone='fi-hel1', backup_rule={}
+        self,
+        size=10,
+        tier='maxiops',
+        title='Storage disk',
+        zone='fi-hel1',
+        backup_rule: Optional[dict] = None,
     ):
         """
         Create a Storage object. Returns an object based on the API's response.
         """
+        if backup_rule is None:
+            backup_rule = {}
         body = {
             'storage': {
                 'size': size,
@@ -54,7 +61,7 @@ def create_storage(
         res = self.post_request('/storage', body)
         return Storage(cloud_manager=self, **res['storage'])
 
-    def _modify_storage(self, storage, size, title, backup_rule={}):
+    def _modify_storage(self, storage, size, title, backup_rule: Optional[dict] = None):
         body = {'storage': {}}
         if size:
             body['storage']['size'] = size
@@ -64,7 +71,7 @@ def _modify_storage(self, storage, size, title, backup_rule={}):
             body['storage']['backup_rule'] = backup_rule
         return self.put_request('/storage/' + str(storage), body)
 
-    def modify_storage(self, storage, size, title, backup_rule={}):
+    def modify_storage(self, storage, size, title, backup_rule: Optional[dict] = None):
         """
         Modify a Storage object. Returns an object based on the API's response.
         """

upcloud_api/cloud_manager/tag_mixin.py

@@ -1,3 +1,5 @@
+from typing import Optional
+
 from upcloud_api.tag import Tag
 
 
@@ -18,12 +20,14 @@ def get_tag(self, name):
         res = self.get_request('/tag/' + name)
         return Tag(cloud_manager=self, **res['tag'])
 
-    def create_tag(self, name, description=None, servers=[]):
+    def create_tag(self, name, description=None, servers: Optional[list] = None):
         """
         Create a new Tag. Only name is mandatory.
 
         Returns the created Tag object.
         """
+        if servers is None:
+            servers = []
         servers = [str(server) for server in servers]
         body = {'tag': Tag(name, description, servers).to_dict()}
         res = self.post_request('/tag', body)

upcloud_api/tag.py

@@ -15,8 +15,10 @@ class Tag(UpCloudResource):
 
     ATTRIBUTES = {'name': None, 'description': None, 'servers': []}
 
-    def __init__(self, name, description=None, servers=[], **kwargs):
+    def __init__(self, name, description=None, servers=None, **kwargs):
         """Init with Tag('tagname', 'description', [servers]) syntax."""
+        if servers is None:
+            servers = []
         super().__init__(name=name, description=description, servers=servers, **kwargs)
 
     def _reset(self, **kwargs):