Servers: do not create password when SSH keys are provided

Author: Antti Myyrä

test/test_server_creation.py

@@ -124,7 +124,7 @@ def test_server_prepare_post_body_optional_attributes(self):
             assert body['server']['password_delivery'] == 'email'
             assert body['server']['login_user'] == {
                 'username': 'upclouduser',
-                'create_password': 'yes',
+                'create_password': 'no',
                 'ssh_keys': {'ssh_key': ['this-is-a-SSH-key']},
             }
             assert body['server']['avoid_host'] == '12345678'

upcloud_api/cloud_manager/server_mixin.py

@@ -91,7 +91,7 @@ def create_server(self, server: Server) -> Server:
               hostname = "my.example.1",
               zone = "uk-lon1",
               storage_devices = [
-                Storage(os = "01000000-0000-4000-8000-000030060200", size=10, tier=maxiops, title='The OS drive'),
+                Storage(os = "01000000-0000-4000-8000-000030200200", size=10, tier=maxiops, title='Example OS disk'),
                 Storage(size=10),
                 Storage()
               title = "My Example Server"
@@ -103,10 +103,11 @@ def create_server(self, server: Server) -> Server:
         - title defaults to hostname + " OS disk" and hostname + " storage disk id"
           (id is a running starting from 1)
         - tier defaults to maxiops
-        - valid operating systems are:
-          "CentOS 6.10", "CentOS 7.6"
-          "Ubuntu 12.04", "01000000-0000-4000-8000-000030060200"
-          "Windows 2012", "Windows 2016"
+        - valid operating systems are for example:
+          * CentOS 8: 01000000-0000-4000-8000-000050010400
+          * Debian 10: 01000000-0000-4000-8000-000020050100
+          * Ubuntu 20.04: 01000000-0000-4000-8000-000030200200
+          * Windows 2019: 01000000-0000-4000-8000-000010070300
         """
         if isinstance(server, Server):
             body = server.prepare_post_body()

upcloud_api/server.py

@@ -10,14 +10,14 @@
     from upcloud_api import CloudManager
 
 
-def login_user_block(username, ssh_keys, create_password=True):
+def login_user_block(username, ssh_keys, create_password=False):
     """
     Helper function for creating Server.login_user blocks.
 
     (see: https://www.upcloud.com/api/8-servers/#create-server)
     """
     block = {
-        'create_password': 'yes' if create_password is True else 'no',
+        'create_password': 'yes' if create_password else 'no',
         'ssh_keys': {'ssh_key': ssh_keys},
     }