Skip to content

Commit d801534

Browse files
committed
Avoid circular imports
1 parent 67fb66e commit d801534

23 files changed

Lines changed: 43 additions & 24 deletions

test/helpers/infra.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
from upcloud_api import CloudManager, FirewallRule, IPAddress, Storage, Tag
1+
from upcloud_api.firewall import FirewallRule
2+
from upcloud_api.ip_address import IPAddress
23
from upcloud_api.server import Server, login_user_block
4+
from upcloud_api.storage import Storage
5+
from upcloud_api.tag import Tag
36

47
CLUSTER = {
58
'web1': Server(

upcloud_api/cloud_manager/base.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import requests
44

5-
from upcloud_api import UpCloudAPIError, __version__
5+
from upcloud_api.errors import UpCloudAPIError
66

77

88
class BaseAPI:
@@ -27,7 +27,7 @@ def request(self, method, endpoint, body=None, params=None, timeout=-1, request_
2727
raise Exception('Invalid/Forbidden HTTP method')
2828

2929
url = 'https://api.upcloud.com/' + self.api_v + endpoint if request_to_api else endpoint
30-
headers = {'Authorization': self.token, 'User-Agent': f'upcloud-python-api/{__version__}'}
30+
headers = {'Authorization': self.token, 'User-Agent': self._get_user_agent()}
3131

3232
headers['Content-Type'] = (
3333
'application/json' if request_to_api else 'application/octet-stream'
@@ -95,3 +95,8 @@ def __error_middleware(self, res, res_json):
9595
)
9696

9797
return res_json
98+
99+
def _get_user_agent(self) -> str:
100+
from upcloud_api import __version__
101+
102+
return f'upcloud-python-api/{__version__}'

upcloud_api/cloud_manager/firewall_mixin.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
from upcloud_api import FirewallRule, Server
1+
from upcloud_api.firewall import FirewallRule
2+
from upcloud_api.server import Server
23

34

45
def uuid_and_instance(server):

upcloud_api/cloud_manager/host_mixin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from upcloud_api import Host
1+
from upcloud_api.host import Host
22

33

44
class HostManager:

upcloud_api/cloud_manager/ip_address_mixin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from upcloud_api import IPAddress
1+
from upcloud_api.ip_address import IPAddress
22

33

44
class IPManager:

upcloud_api/cloud_manager/network_mixin.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
from upcloud_api import Interface, IpNetwork, Network, Router
1+
from upcloud_api.interface import Interface
2+
from upcloud_api.ip_network import IpNetwork
3+
from upcloud_api.network import Network
4+
from upcloud_api.router import Router
25

36

47
class NetworkManager:

upcloud_api/cloud_manager/object_storage_mixin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from upcloud_api import ObjectStorage
1+
from upcloud_api.object_storage import ObjectStorage
22
from upcloud_api.utils import convert_datetime_string_to_object
33

44

upcloud_api/cloud_manager/server_mixin.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
from upcloud_api import IPAddress, Server, Storage
1+
from upcloud_api.ip_address import IPAddress
2+
from upcloud_api.server import Server
3+
from upcloud_api.storage import Storage
24

35

46
class ServerManager:

upcloud_api/cloud_manager/storage_mixin.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
from upcloud_api import Storage, StorageImport
1+
from typing import Optional
2+
3+
from upcloud_api.storage import Storage
4+
from upcloud_api.storage_import import StorageImport
25
from upcloud_api.utils import get_raw_data_from_file
36

47

upcloud_api/cloud_manager/tag_mixin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from upcloud_api import Tag
1+
from upcloud_api.tag import Tag
22

33

44
class TagManager:

0 commit comments

Comments
 (0)