Skip to content

Hardcoded/unnecessary sleeps in admin start/stop #52

@scop

Description

@scop

sleep(45);
return isset($stop['response']['error']['error_message']) ? $stop['response']['error']['error_message'] : 'success';
}
}
public function start(){
$instanceId = $this->params['model']->serviceProperties->get('instanceId|instance Id');
$start = $this->manager->StartServer($instanceId);
sleep(45);

These hardcoded 45 second sleeps seem quite arbitrary. They are in a sense also somewhat odd, because the response is captured before the sleep and I don't think the response will change during the sleep, so feels as if they are unnecessary as well.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions