Skip to content

Commit 1353fde

Browse files
committed
Update the comment about nm --extern-only.
1 parent fe80002 commit 1353fde

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,8 +390,8 @@ finish: $(SYSROOT_INC) libc
390390
mkdir -p "$(SYSROOT_SHARE)"
391391

392392
# Collect symbol information.
393-
# TODO: Use llvm-nm --extern-only instead of grep once
394-
# https://bugs.llvm.org/show_bug.cgi?id=40497 is fixed.
393+
# TODO: Use llvm-nm --extern-only instead of grep. This is blocked on
394+
# LLVM PR40497, which is fixed in 9.0, but not in 8.0.
395395
$(WASM_NM) --defined-only "$(SYSROOT_LIB)"/libc.a "$(SYSROOT_LIB)"/*.o \
396396
|grep ' [[:upper:]] ' |sed 's/.* [[:upper:]] //' |LC_COLLATE=C sort > "$(SYSROOT_SHARE)/defined-symbols.txt"
397397
for undef_sym in $$($(WASM_NM) --undefined-only "$(SYSROOT_LIB)"/*.a "$(SYSROOT_LIB)"/*.o \

0 commit comments

Comments
 (0)