Skip to content

Commit 79e7b17

Browse files
authored
Fix null field for resource metadata fields in experimental chart (#4419)
1 parent 39934ce commit 79e7b17

File tree

2 files changed

+472
-16
lines changed

2 files changed

+472
-16
lines changed

charts/gha-runner-scale-set-experimental/templates/autoscalingrunnserset.yaml

Lines changed: 40 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -175,44 +175,68 @@ spec:
175175
{{- toYaml . | nindent 4 }}
176176
{{- end }}
177177

178-
{{- with .Values.resource.autoscalingListener.metadata }}
178+
{{- $meta := .Values.resource.autoscalingListener.metadata | default dict }}
179+
{{- $lbls := $meta.labels | default dict }}
180+
{{- $anns := $meta.annotations | default dict }}
181+
{{- if or (not (empty $lbls)) (not (empty $anns)) }}
179182
autoscalingListener:
180-
{{- include "autoscaling-runner-set.spec-resource-metadata" . | nindent 4 }}
183+
{{- include "autoscaling-runner-set.spec-resource-metadata" $meta | nindent 4 }}
181184
{{- end }}
182185

183-
{{- with .Values.resource.listenerServiceAccount.metadata }}
186+
{{- $meta := .Values.resource.listenerServiceAccount.metadata | default dict }}
187+
{{- $lbls := $meta.labels | default dict }}
188+
{{- $anns := $meta.annotations | default dict }}
189+
{{- if or (not (empty $lbls)) (not (empty $anns)) }}
184190
listenerServiceAccountMetadata:
185-
{{- include "autoscaling-runner-set.spec-resource-metadata" . | nindent 4 }}
191+
{{- include "autoscaling-runner-set.spec-resource-metadata" $meta | nindent 4 }}
186192
{{- end }}
187193

188-
{{- with .Values.resource.listenerRole.metadata }}
194+
{{- $meta := .Values.resource.listenerRole.metadata | default dict }}
195+
{{- $lbls := $meta.labels | default dict }}
196+
{{- $anns := $meta.annotations | default dict }}
197+
{{- if or (not (empty $lbls)) (not (empty $anns)) }}
189198
listenerRoleMetadata:
190-
{{- include "autoscaling-runner-set.spec-resource-metadata" . | nindent 4 }}
199+
{{- include "autoscaling-runner-set.spec-resource-metadata" $meta | nindent 4 }}
191200
{{- end }}
192201

193-
{{- with .Values.resource.listenerRoleBinding.metadata }}
202+
{{- $meta := .Values.resource.listenerRoleBinding.metadata | default dict }}
203+
{{- $lbls := $meta.labels | default dict }}
204+
{{- $anns := $meta.annotations | default dict }}
205+
{{- if or (not (empty $lbls)) (not (empty $anns)) }}
194206
listenerRoleBindingMetadata:
195-
{{- include "autoscaling-runner-set.spec-resource-metadata" . | nindent 4 }}
207+
{{- include "autoscaling-runner-set.spec-resource-metadata" $meta | nindent 4 }}
196208
{{- end }}
197209

198-
{{- with .Values.resource.listenerConfigSecret.metadata }}
210+
{{- $meta := .Values.resource.listenerConfigSecret.metadata | default dict }}
211+
{{- $lbls := $meta.labels | default dict }}
212+
{{- $anns := $meta.annotations | default dict }}
213+
{{- if or (not (empty $lbls)) (not (empty $anns)) }}
199214
listenerConfigSecretMetadata:
200-
{{- include "autoscaling-runner-set.spec-resource-metadata" . | nindent 4 }}
215+
{{- include "autoscaling-runner-set.spec-resource-metadata" $meta | nindent 4 }}
201216
{{- end }}
202217

203-
{{- with .Values.resource.ephemeralRunnerSet.metadata }}
218+
{{- $meta := .Values.resource.ephemeralRunnerSet.metadata | default dict }}
219+
{{- $lbls := $meta.labels | default dict }}
220+
{{- $anns := $meta.annotations | default dict }}
221+
{{- if or (not (empty $lbls)) (not (empty $anns)) }}
204222
ephemeralRunnerSetMetadata:
205-
{{- include "autoscaling-runner-set.spec-resource-metadata" . | nindent 4 }}
223+
{{- include "autoscaling-runner-set.spec-resource-metadata" $meta | nindent 4 }}
206224
{{- end }}
207225

208-
{{- with .Values.resource.ephemeralRunner.metadata }}
226+
{{- $meta := .Values.resource.ephemeralRunner.metadata | default dict }}
227+
{{- $lbls := $meta.labels | default dict }}
228+
{{- $anns := $meta.annotations | default dict }}
229+
{{- if or (not (empty $lbls)) (not (empty $anns)) }}
209230
ephemeralRunnerMetadata:
210-
{{- include "autoscaling-runner-set.spec-resource-metadata" . | nindent 4 }}
231+
{{- include "autoscaling-runner-set.spec-resource-metadata" $meta | nindent 4 }}
211232
{{- end }}
212233

213-
{{- with .Values.resource.ephemeralRunnerConfigSecret.metadata }}
234+
{{- $meta := .Values.resource.ephemeralRunnerConfigSecret.metadata | default dict }}
235+
{{- $lbls := $meta.labels | default dict }}
236+
{{- $anns := $meta.annotations | default dict }}
237+
{{- if or (not (empty $lbls)) (not (empty $anns)) }}
214238
ephemeralRunnerConfigSecretMetadata:
215-
{{- include "autoscaling-runner-set.spec-resource-metadata" . | nindent 4 }}
239+
{{- include "autoscaling-runner-set.spec-resource-metadata" $meta | nindent 4 }}
216240
{{- end }}
217241

218242
template:

0 commit comments

Comments
 (0)