Refactor in HTTPStatus

Author: michalpokusa

adafruit_httpserver/server.py

@@ -9,7 +9,7 @@
 from .request import HTTPRequest
 from .response import HTTPResponse
 from .route import HTTPRoute
-from .status import HTTPStatus
+from .status import BAD_REQUEST_400
 
 class HTTPServer:
     """A basic socket-based HTTP server."""
@@ -107,9 +107,9 @@ def poll(self):
                 elif request.method == HTTPMethod.GET:
                     response = HTTPResponse(filename=request.path, root=self.root_path)
 
-                # If no handler exists and request method is not GET, return 500 Internal Server Error.
+                # If no handler exists and request method is not GET, return 400 Bad Request.
                 else:
-                    response = HTTPResponse(status=HTTPStatus.INTERNAL_SERVER_ERROR)
+                    response = HTTPResponse(status=BAD_REQUEST_400)
 
                 response.send(conn)
         except OSError as ex:

adafruit_httpserver/status.py

@@ -1,25 +1,23 @@
 class HTTPStatus:  # pylint: disable=too-few-public-methods
     """HTTP status codes."""
 
-    def __init__(self, value, phrase):
+    def __init__(self, code, text):
         """Define a status code.
 
         :param int value: Numeric value: 200, 404, etc.
         :param str phrase: Short phrase: "OK", "Not Found', etc.
         """
-        self.value = value
-        self.phrase = phrase
+        self.code = code
+        self.text = text
 
     def __repr__(self):
-        return f'HTTPStatus({self.value}, "{self.phrase}")'
+        return f'HTTPStatus({self.code}, "{self.text}")'
 
     def __str__(self):
-        return f"{self.value} {self.phrase}"
+        return f"{self.code} {self.text}"
 
 
-HTTPStatus.NOT_FOUND = HTTPStatus(404, "Not Found")
-"""404 Not Found"""
-HTTPStatus.OK = HTTPStatus(200, "OK")  # pylint: disable=invalid-name
-"""200 OK"""
-HTTPStatus.INTERNAL_SERVER_ERROR = HTTPStatus(500, "Internal Server Error")
-"""500 Internal Server Error"""
+OK_200 = HTTPStatus(200, "OK")
+BAD_REQUEST_400 = HTTPStatus(400, "Bad Request")
+NOT_FOUND_404 = HTTPStatus(404, "Not Found")
+INTERNAL_SERVER_ERROR_500 = HTTPStatus(500, "Internal Server Error")