Forcing the channel argument to as_bytes() in MIDIMessage and its children to be specified as a named (non-positional) arg. This is the variable that is ignored by some children. #3

Author: Kevin J Walters

adafruit_midi/channel_pressure.py

@@ -56,7 +56,7 @@ def __init__(self, pressure):
             raise self._EX_VALUEERROR_OOR
 
     # channel value is mandatory
-    def as_bytes(self, channel=None):
+    def as_bytes(self, *, channel=None):
         return bytearray([self._STATUS | (channel & self.CHANNELMASK),
                           self.pressure])
 

adafruit_midi/control_change.py

@@ -59,7 +59,7 @@ def __init__(self, control, value):
             raise self._EX_VALUEERROR_OOR
 
     # channel value is mandatory
-    def as_bytes(self, channel=None):
+    def as_bytes(self, *, channel=None):
         return bytearray([self._STATUS | (channel & self.CHANNELMASK),
                           self.control, self.value])
 

adafruit_midi/midi_message.py

@@ -280,7 +280,7 @@ def from_message_bytes(cls, midibytes, channel_in):
     # A default method for constructing wire messages with no data.
     # Returns a (mutable) bytearray with just the status code in.
     # pylint: disable=unused-argument
-    def as_bytes(self, channel=None):
+    def as_bytes(self, *, channel=None):
         """Return the ``bytearray`` wire protocol representation of the object."""
         return bytearray([self._STATUS])
 

adafruit_midi/note_off.py

@@ -60,7 +60,7 @@ def __init__(self, note, velocity):
             raise self._EX_VALUEERROR_OOR
 
     # channel value is mandatory
-    def as_bytes(self, channel=None):
+    def as_bytes(self, *, channel=None):
         return bytearray([self._STATUS | (channel & self.CHANNELMASK),
                           self.note, self.velocity])
 

adafruit_midi/note_on.py

@@ -60,7 +60,7 @@ def __init__(self, note, velocity):
             raise self._EX_VALUEERROR_OOR
 
     # channel value is mandatory
-    def as_bytes(self, channel=None):
+    def as_bytes(self, *, channel=None):
         return bytearray([self._STATUS | (channel & self.CHANNELMASK),
                           self.note, self.velocity])
 

adafruit_midi/pitch_bend_change.py

@@ -57,7 +57,7 @@ def __init__(self, pitch_bend):
             raise self._EX_VALUEERROR_OOR
 
     # channel value is mandatory
-    def as_bytes(self, channel=None):
+    def as_bytes(self, *, channel=None):
         return bytearray([self._STATUS | (channel & self.CHANNELMASK),
                           self.pitch_bend & 0x7f,
                           (self.pitch_bend >> 7) & 0x7f])

adafruit_midi/polyphonic_key_pressure.py

@@ -59,7 +59,7 @@ def __init__(self, note, pressure):
             raise self._EX_VALUEERROR_OOR
 
     # channel value is mandatory
-    def as_bytes(self, channel=None):
+    def as_bytes(self, *, channel=None):
         return bytearray([self._STATUS | (channel & self.CHANNELMASK),
                           self.note, self.pressure])
 

adafruit_midi/program_change.py

@@ -56,7 +56,7 @@ def __init__(self, patch):
             raise self._EX_VALUEERROR_OOR
 
     # channel value is mandatory
-    def as_bytes(self, channel=None):
+    def as_bytes(self, *, channel=None):
         return bytearray([self._STATUS | (channel & self.CHANNELMASK),
                           self.patch])
 

adafruit_midi/system_exclusive.py

@@ -59,7 +59,7 @@ def __init__(self, manufacturer_id, data):
         self.data = bytearray(data)
 
     # channel value present to keep interface uniform but unused
-    def as_bytes(self, channel=None):
+    def as_bytes(self, *, channel=None):
         return (bytearray([self._STATUS])
                 + self.manufacturer_id
                 + self.data