Giving NoteOn and NoteOff some default velocity values as this is useful from REPL. #3

Author: Kevin J Walters

adafruit_midi/note_off.py

@@ -44,15 +44,15 @@ class NoteOff(MIDIMessage):
 
     :param note: The note (key) number either as an ``int`` (0-127) or a
         ``str`` which is parsed, e.g. "C4" (middle C) is 60, "A4" is 69.
-    :param int velocity: The release velocity, 0-127.
+    :param int velocity: The release velocity, 0-127, defaults to 0.
 
     """
 
     _STATUS = 0x80
     _STATUSMASK = 0xf0
     LENGTH = 3
 
-    def __init__(self, note, velocity, *, channel=None):
+    def __init__(self, note, velocity=0, *, channel=None):
         self.note = note_parser(note)
         self.velocity = velocity
         super().__init__(channel=channel)

adafruit_midi/note_on.py

@@ -45,14 +45,14 @@ class NoteOn(MIDIMessage):
     :param note: The note (key) number either as an ``int`` (0-127) or a
         ``str`` which is parsed, e.g. "C4" (middle C) is 60, "A4" is 69.
     :param int velocity: The strike velocity, 0-127, 0 is equivalent
-        to a Note Off.
+        to a Note Off, defaults to 127.
     """
 
     _STATUS = 0x90
     _STATUSMASK = 0xf0
     LENGTH = 3
 
-    def __init__(self, note, velocity, *, channel=None):
+    def __init__(self, note, velocity=127, *, channel=None):
         self.note = note_parser(note)
         self.velocity = velocity
         super().__init__(channel=channel)

tests/test_MIDIMessage_unittests.py

@@ -223,6 +223,12 @@ def test_NoteOn_constructor_int(self):
         self.assertEqual(object3.velocity, 0x50)
         self.assertEqual(object3.channel, 7)
 
+        object4 = NoteOn(60)  # velocity defaults to 127
+
+        self.assertEqual(object4.note, 60)
+        self.assertEqual(object4.velocity, 127)
+        self.assertIsNone(object4.channel)
+
     def test_SystemExclusive_NoteOn(self):
         data = bytes([0xf0, 0x42, 0x01, 0x02, 0x03, 0x04, 0xf7,  0x90 | 14, 0x30, 0x60])
         ichannel = 14
@@ -335,6 +341,10 @@ def test_NoteOff_constructor_string(self):
         self.assertEqual(object3.note, 61)
         self.assertEqual(object3.velocity, 0)
 
+        object4 = NoteOff("C#4")  # velocity defaults to 0
+        self.assertEqual(object4.note, 61)
+        self.assertEqual(object4.velocity, 0)
+
     def test_NoteOff_constructor_valueerror1(self):
         with self.assertRaises(ValueError):
             NoteOff(60, 0x80)