Linted

Author: evaherrada

CircuitPython_sdcardio_sdioio/benchmark/code.py

@@ -1,10 +1,10 @@
 import time
 import os
 
-import mount_sd
 
 # First, just write the file 'hello.txt' to the card
-with open("/sd/hello.txt", "w") as f: print("hello world", file=f)
+with open("/sd/hello.txt", "w") as f:
+    print("hello world", file=f)
 
 print()
 print("SD card I/O benchmarks")
@@ -16,7 +16,8 @@
 # time taken.
 for sz in 512, 4096:
     b = bytearray(sz)
-    for i in range(sz): b[i] = 0xaa
+    for i in range(sz):
+        b[i] = 0xaa
     for n in (1, 16):
         with open("/sd/hello.bin", "wb") as f:
             t0 = time.monotonic_ns()

CircuitPython_sdcardio_sdioio/list_files/code.py

@@ -1,7 +1,5 @@
 import os
 
-import mount_sd
-
 def print_directory(path, tabs=0):
     for file in os.listdir(path):
         stats = os.stat(path + "/" + file)

CircuitPython_sdcardio_sdioio/log_temperature/code.py

@@ -3,7 +3,6 @@
 import board
 import digitalio
 import microcontroller
-import mount_sd
 
 led = digitalio.DigitalInOut(board.D13)
 led.direction = digitalio.Direction.OUTPUT

CircuitPython_sdcardio_sdioio/play_mp3s/code.py

@@ -3,16 +3,15 @@
 
 import board
 import digitalio
-import mount_sd
 
 # Updating the display can interfere with MP3 playback if it is not
 # done carefully
 try:
     board.DISPLAY.auto_refresh = False
-except:
+except: # pylint: disable=bare-except
     pass
 
-from audiomp3 import MP3Decoder
+from audiomp3 import MP3Decoder # pylint: disable=wrong-import-position
 
 try:
     from audioio import AudioOut

CircuitPython_sdcardio_sdioio/show_bitmaps/code.py

@@ -4,8 +4,6 @@
 import board
 import displayio
 
-import mount_sd
-
 display = board.DISPLAY
 
 # The bmp files on the sd card will be shown in alphabetical order

Light_Paintstick_HalloWing/light_paintstick_cpx/code.py

@@ -84,7 +84,6 @@ def read_le(value):
 
 class BMPError(Exception):
     """Error handler for BMP-loading function"""
-    pass
 
 def load_bmp(filename):
     """Load BMP file, return as list of column buffers"""
@@ -159,11 +158,11 @@ def load_bmp(filename):
 
     except OSError as err:
         if err.args[0] == 28:
-            raise OSError("OS Error 28 0.25")
-        else:
-            raise OSError("OS Error 0.5")
+            raise OSError("OS Error 28 0.25") from err
+        raise OSError("OS Error 0.5") from err
     except BMPError as err:
-        print("Failed to parse BMP: " + err.args[0])
+        raise BMPError("Failed to parse BMP: " + err.args[0]) from err
+
 
 
 # Load BMP image, return 'columns' array:

Light_Paintstick_HalloWing/light_paintstick_hallowing/code.py

@@ -58,7 +58,6 @@ def read_le(value):
 
 class BMPError(Exception):
     """Error handler for BMP-loading function"""
-    pass
 
 def load_bmp(filename):
     """Load BMP file, return as list of column buffers"""
@@ -133,11 +132,10 @@ def load_bmp(filename):
 
     except OSError as err:
         if err.args[0] == 28:
-            raise OSError("OS Error 28 0.25")
-        else:
-            raise OSError("OS Error 0.5")
+            raise OSError("OS Error 28 0.25") from err
+        raise OSError("OS Error 0.5") from err
     except BMPError as err:
-        print("Failed to parse BMP: " + err.args[0])
+        raise BMPError("Failed to parse BMP: " + err.args[0]) from err
 
 
 # Load BMP image, return 'COLUMNS' array:

Nightlight/cpx_nightlight/code.py

@@ -37,8 +37,7 @@
         # Indicate the nightlight is off.
         cp.red_led = True
         continue
-    else:
-        cp.red_led = False
+    cp.red_led = False
 
     # Decrease brightness.
     if cp.touch_A7: