fix some compiler warnings

Author: ladyada

M4_Eyes/file.cpp

@@ -64,6 +64,7 @@ static int32_t dwim(JsonVariant v, int32_t def = 0) { // "Do What I Mean"
   }
 }
 
+/*
 static void getFilename(JsonVariant v, char **ptr) {
   if(*ptr) {          // If string already allocated,
     free(*ptr);       // delete old value...
@@ -73,6 +74,7 @@ static void getFilename(JsonVariant v, char **ptr) {
     *ptr = strdup(v); // Make a copy of string, save that
   }
 }
+*/
 
 void loadConfig(char *filename) {
   File    file;
@@ -135,7 +137,7 @@ void loadConfig(char *filename) {
       if(pMin > pMax) {
         float temp = pMin;
         pMin = pMax;
-        pMax = pMin;
+        pMax = temp;
       }
       irisMin   = (1.0 - pMax);
       irisRange = (pMax - pMin);
@@ -337,7 +339,7 @@ ImageReturnCode loadEyelid(char *filename,
   if(reader->bmpDimensions(filename, &w, &h) == IMAGE_SUCCESS) {
     tempBytes = ((w + 7) / 8) * h; // Bitmap size in bytes
     if (maxRam > tempBytes) {
-      if(tempPtr = (uint8_t *)malloc(maxRam - tempBytes)) {
+      if((tempPtr = (uint8_t *)malloc(maxRam - tempBytes)) != NULL) {
         // Make SOME tempPtr reference, or optimizer removes the alloc!
         tempPtr[0] = 0;
       }
@@ -420,7 +422,7 @@ ImageReturnCode loadTexture(char *filename, uint16_t **data,
   if(reader->bmpDimensions(filename, &w, &h) == IMAGE_SUCCESS) {
     tempBytes = w * h * 2; // Image size in bytes (converted to 16bpp)
     if (maxRam > tempBytes) {
-      if(tempPtr = (uint8_t *)malloc(maxRam - tempBytes)) {
+      if((tempPtr = (uint8_t *)malloc(maxRam - tempBytes)) != NULL) {
         // Make SOME tempPtr reference, or optimizer removes the alloc!
         tempPtr[0] = 0;
       }

M4_Eyes/pdmvoice.cpp

@@ -191,7 +191,7 @@ void voiceGain(float g) {
 void voiceMod(uint32_t freq, uint8_t waveform) {
   if(modBuf) { // Ignore if no modulation buffer allocated
     if(freq < MOD_MIN) freq = MOD_MIN;
-    modLen = (int)(actualPlaybackRate / freq + 0.5);
+    modLen = (uint32_t)(actualPlaybackRate / freq + 0.5);
     if(modLen   < 2) modLen   = 2;
     if(waveform > 4) waveform = 4;
     modWave = waveform;
@@ -204,17 +204,17 @@ void voiceMod(uint32_t freq, uint8_t waveform) {
       memset(&modBuf[modLen / 2], 0, modLen - modLen / 2);
       break;
      case 2: // Sine
-      for(int i=0; i<modLen; i++) {
+      for(uint32_t i=0; i<modLen; i++) {
         modBuf[i] = (int)((sin(M_PI * 2.0 * (float)i / (float)modLen) + 1.0) * 0.5 * 255.0 + 0.5);
       }
       break;
      case 3: // Triangle
-      for(int i=0; i<modLen; i++) {
+      for(uint32_t i=0; i<modLen; i++) {
         modBuf[i] = (int)(fabs(0.5 - (float)i / (float)modLen) * 2.0 * 255.0 + 0.5);
       }
       break;
      case 4: // Sawtooth (increasing)
-      for(int i=0; i<modLen; i++) {
+      for(uint32_t i=0; i<modLen; i++) {
         modBuf[i] = (int)((float)i / (float)(modLen - 1) * 255.0 + 0.5);
       }
       break;