Commit a15e2b5
committed
pylint disables, Debouncer and import fixes
excellent thanks @BlitzCityDIY @TheKitty
here are the round of adjustments:
1. f-string syntax error (line 2009)
Extracted conditional to zoom_label variable
2. DRV2605 shouldn't be optional import
Moved to normal import adafruit_drv2605 at top
3. Haptic init shouldn't have try/except
Direct haptic = adafruit_drv2605.DRV2605(i2c)
4. Don't wrap single-call code in functions
Unwrapped _build_bars() back to module-level loop
5. Redefined-outer-name from loop vars
Renamed to bar_idx, bar_x (unique names)
6. Consolidate graph functions
Already done previous pass — create_sensor_graph() / update_sensor_graph()
7. Use f-strings
Already converted all 36 .format() calls
Memory updated with reviewer's patterns (#7, #14).
Remaining for next PR: Migrate manual button polling to adafruit_debouncer.Button — that's a substantial refactor of the entire polling loop but will eliminate the manual timestamp tracking, pending flags, and double-tap state machine. The debouncer library's short_count and long_press APIs handle all of that natively.1 parent f545a70 commit a15e2b5
1 file changed
+59
-75
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
| 34 | + | |
39 | 35 | | |
40 | 36 | | |
41 | 37 | | |
| |||
336 | 332 | | |
337 | 333 | | |
338 | 334 | | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
343 | | - | |
344 | | - | |
345 | | - | |
346 | | - | |
| 335 | + | |
| 336 | + | |
347 | 337 | | |
348 | 338 | | |
349 | 339 | | |
| |||
369 | 359 | | |
370 | 360 | | |
371 | 361 | | |
372 | | - | |
373 | | - | |
374 | | - | |
375 | | - | |
376 | | - | |
377 | | - | |
378 | | - | |
379 | | - | |
380 | | - | |
381 | | - | |
382 | | - | |
383 | | - | |
384 | | - | |
385 | | - | |
386 | | - | |
387 | | - | |
388 | | - | |
389 | | - | |
390 | | - | |
391 | | - | |
392 | | - | |
393 | | - | |
394 | | - | |
395 | | - | |
| 362 | + | |
| 363 | + | |
396 | 364 | | |
397 | | - | |
398 | | - | |
399 | | - | |
400 | | - | |
401 | | - | |
402 | | - | |
403 | | - | |
404 | | - | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
405 | 372 | | |
| 373 | + | |
406 | 374 | | |
407 | | - | |
408 | | - | |
409 | | - | |
410 | | - | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
411 | 380 | | |
412 | | - | |
| 381 | + | |
413 | 382 | | |
414 | | - | |
415 | | - | |
| 383 | + | |
416 | 384 | | |
417 | | - | |
418 | | - | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
419 | 390 | | |
420 | | - | |
| 391 | + | |
421 | 392 | | |
422 | | - | |
423 | | - | |
| 393 | + | |
424 | 394 | | |
425 | | - | |
426 | | - | |
427 | | - | |
428 | | - | |
429 | | - | |
430 | | - | |
431 | | - | |
432 | | - | |
433 | | - | |
434 | | - | |
435 | | - | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
436 | 404 | | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
437 | 412 | | |
438 | | - | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
439 | 424 | | |
440 | 425 | | |
441 | 426 | | |
| |||
619 | 604 | | |
620 | 605 | | |
621 | 606 | | |
622 | | - | |
623 | | - | |
624 | 607 | | |
625 | 608 | | |
626 | 609 | | |
| |||
633 | 616 | | |
634 | 617 | | |
635 | 618 | | |
636 | | - | |
637 | | - | |
638 | 619 | | |
639 | 620 | | |
640 | 621 | | |
| |||
2006 | 1987 | | |
2007 | 1988 | | |
2008 | 1989 | | |
2009 | | - | |
2010 | | - | |
| 1990 | + | |
| 1991 | + | |
| 1992 | + | |
| 1993 | + | |
| 1994 | + | |
2011 | 1995 | | |
2012 | 1996 | | |
2013 | 1997 | | |
| |||
0 commit comments