Merge pull request #7563 from Neradoc/deinit-i2cdisplay-reset-on-raise

tannewt · web-flow · commit 1af2b6acbe6d · 2023-02-13T10:03:39.000-08:00
Deinit the reset pin when displayio.I2CDisplay fails
diff --git a/shared-module/displayio/I2CDisplay.c b/shared-module/displayio/I2CDisplay.c
@@ -54,6 +54,7 @@ void common_hal_displayio_i2cdisplay_construct(displayio_i2cdisplay_obj_t *self,
     // Probe the bus to see if a device acknowledges the given address.
     if (!common_hal_busio_i2c_probe(i2c, device_address)) {
         self->base.type = &mp_type_NoneType;
+        common_hal_displayio_i2cdisplay_deinit(self);
         mp_raise_ValueError_varg(translate("Unable to find I2C Display at %x"), device_address);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,7 @@ void common_hal_displayio_i2cdisplay_construct(displayio_i2cdisplay_obj_t *self,`
`54`	`54`	`// Probe the bus to see if a device acknowledges the given address.`
`55`	`55`	`if (!common_hal_busio_i2c_probe(i2c, device_address)) {`
`56`	`56`	`self->base.type = &mp_type_NoneType;`
	`57`	`+ common_hal_displayio_i2cdisplay_deinit(self);`
`57`	`58`	`mp_raise_ValueError_varg(translate("Unable to find I2C Display at %x"), device_address);`
`58`	`59`	`}`
`59`	`60`