Skip to content

Commit 4b0aee4

Browse files
dhalbertdhalbert
committed
fix some tests
1 parent 9a7b9d7 commit 4b0aee4

14 files changed

Lines changed: 64 additions & 14 deletions

File tree

‎Makefile‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,7 @@ check-stubs: stubs
282282
@(cd $(STUBDIR) && set -- */__init__.pyi && mypy "$${@%/*}")
283283
@tools/test-stubs.sh
284284

285+
.PHONY: update-frozen-libraries
285286
update-frozen-libraries:
286287
@echo "Updating all frozen libraries to latest tagged version."
287288
cd frozen; for library in *; do cd $$library; ../../tools/git-checkout-latest-tag.sh; cd ..; done
@@ -350,3 +351,15 @@ remove-all-submodules:
350351
.PHONY: fetch-tags
351352
fetch-tags:
352353
git fetch --tags --recurse-submodules=no --shallow-since="2023-02-01" https://github.com/adafruit/circuitpython HEAD
354+
355+
.PHONY: coverage
356+
coverage:
357+
make -j -C ports/unix VARIANT=coverage
358+
359+
.PHONY: coverage-clean
360+
coverage-clean:
361+
make -C ports/unix VARIANT=coverage clean
362+
363+
.PHONY: run-tests
364+
run-tests:
365+
cd tests; MICROPY_MICROPYTHON=../ports/unix/build-coverage/micropython ./run-tests.py

‎lib/oofatfs/ff.c‎

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,7 @@ typedef struct {
278278

279279

280280
/* SBCS up-case tables (\x80-\xFF) */
281+
// CIRCUITPY-CHANGE
281282
// Optimize the 437-only case with a truncated lookup table.
282283
#if FF_CODE_PAGE == 437
283284
#define TBL_CT437 {0x80,0x9A,0x45,0x41,0x8E,0x41,0x8F,0x80,0x45,0x45,0x45,0x49,0x49,0x49,0x8E,0x8F, \
@@ -1187,6 +1188,7 @@ static DWORD get_fat ( /* 0xFFFFFFFF:Disk error, 1:Internal error, 2..0x7FF
11871188
break;
11881189
}
11891190
}
1191+
// CIRCUITPY-CHANGE: explicit fallthrough
11901192
MP_FALLTHROUGH
11911193
/* go to default */
11921194
#endif
@@ -1997,6 +1999,7 @@ static void gen_numname (
19971999
if (c > '9') c += 7;
19982000
ns[i--] = c;
19992001
seq /= 16;
2002+
// CIRCUITPY-CHANGE: limit to 8 digits
20002003
} while (seq && i > 0);
20012004
ns[i] = '~';
20022005

@@ -2894,6 +2897,7 @@ static FRESULT create_name ( /* FR_OK: successful, FR_INVALID_NAME: could not
28942897
}
28952898
#elif FF_CODE_PAGE < 900 /* SBCS cfg */
28962899
wc = ff_uni2oem(wc, CODEPAGE); /* Unicode ==> ANSI/OEM code */
2900+
// CIRCUITPY-CHANGE
28972901
// Optimize the 437-only case with a truncated lookup table.
28982902
#if FF_CODE_PAGE == 437
28992903
if (wc & 0x80 && wc < (0xA5 - 0x80)) wc = ExCvt[wc & 0x7F]; /* Convert extended character to upper (SBCS) */
@@ -4832,7 +4836,7 @@ FRESULT f_rename (
48324836
DWORD dw;
48334837
DEF_NAMBUF
48344838

4835-
4839+
// CIRCUITPY-CHANGE
48364840
// Check to see if we're moving a directory into itself. This occurs when we're moving a
48374841
// directory where the old path is a prefix of the new and the next character is a "/" and thus
48384842
// preserves the original directory name.
@@ -5425,6 +5429,7 @@ FRESULT f_mkfs (
54255429
// CIRCUITPY-CHANGE: Make number of root directory entries changeable. See below.
54265430
UINT n_rootdir = 512; /* Default number of root directory entries for FAT volume */
54275431
static const WORD cst[] = {1, 4, 16, 64, 256, 512, 0}; /* Cluster size boundary for FAT volume (4Ks unit) */
5432+
// CIRCUITPY-CHANGE: optional FAT32 support
54285433
#if FF_MKFS_FAT32
54295434
static const WORD cst32[] = {1, 2, 4, 8, 16, 32, 0}; /* Cluster size boundary for FAT32 volume (128Ks unit) */
54305435
#endif
@@ -5439,6 +5444,7 @@ FRESULT f_mkfs (
54395444
DWORD tbl[3];
54405445
#endif
54415446

5447+
// CIRCUITPY-CHANGE: random volids
54425448
DWORD volid = MAKE_VOLID();
54435449

54445450
/* Check mounted drive and clear work area */
@@ -5500,6 +5506,7 @@ FRESULT f_mkfs (
55005506
}
55015507
}
55025508
if (au > 128) LEAVE_MKFS(FR_INVALID_PARAMETER); /* Too large au for FAT/FAT32 */
5509+
// CIRCUITPY-CHANGE: optional FAT32 support
55035510
if (FF_MKFS_FAT32 && (opt & FM_FAT32)) { /* FAT32 possible? */
55045511
if ((opt & FM_ANY) == FM_FAT32 || !(opt & FM_FAT)) { /* FAT32 only or no-FAT? */
55055512
fmt = FS_FAT32; break;
@@ -5555,6 +5562,7 @@ FRESULT f_mkfs (
55555562
}
55565563
st = 1; /* Do not compress short run */
55575564
/* go to next case */
5565+
// CIRCUITPY-CHANGE: explicit fallthrough
55585566
MP_FALLTHROUGH
55595567
case 1:
55605568
ch = si++; /* Fill the short run */
@@ -5641,6 +5649,7 @@ FRESULT f_mkfs (
56415649
st_dword(buf + BPB_DataOfsEx, b_data - b_vol); /* Data offset [sector] */
56425650
st_dword(buf + BPB_NumClusEx, n_clst); /* Number of clusters */
56435651
st_dword(buf + BPB_RootClusEx, 2 + tbl[0] + tbl[1]); /* Root dir cluster # */
5652+
// CIRCUITPY-CHANGE: random volids
56445653
st_dword(buf + BPB_VolIDEx, volid); /* VSN */
56455654
st_word(buf + BPB_FSVerEx, 0x100); /* Filesystem version (1.00) */
56465655
for (buf[BPB_BytsPerSecEx] = 0, i = ss; i >>= 1; buf[BPB_BytsPerSecEx]++) ; /* Log2 of sector size [byte] */
@@ -5677,6 +5686,7 @@ FRESULT f_mkfs (
56775686
do {
56785687
pau = au;
56795688
/* Pre-determine number of clusters and FAT sub-type */
5689+
// CIRCUITPY-CHANGE: optional FAT32 support
56805690
#if FF_MKFS_FAT32
56815691
if (fmt == FS_FAT32) { /* FAT32 volume */
56825692
if (pau == 0) { /* au auto-selection */
@@ -5725,6 +5735,7 @@ FRESULT f_mkfs (
57255735
/* Determine number of clusters and final check of validity of the FAT sub-type */
57265736
if (sz_vol < b_data + pau * 16 - b_vol) LEAVE_MKFS(FR_MKFS_ABORTED); /* Too small volume */
57275737
n_clst = (sz_vol - sz_rsv - sz_fat * n_fats - sz_dir) / pau;
5738+
// CIRCUITPY-CHANGE: optional FAT32 support
57285739
#if FF_MKFS_FAT32
57295740
if (fmt == FS_FAT32) {
57305741
if (n_clst <= MAX_FAT16) { /* Too few clusters for FAT32 */
@@ -5766,6 +5777,7 @@ FRESULT f_mkfs (
57665777
buf[BPB_SecPerClus] = (BYTE)pau; /* Cluster size [sector] */
57675778
st_word(buf + BPB_RsvdSecCnt, (WORD)sz_rsv); /* Size of reserved area */
57685779
buf[BPB_NumFATs] = (BYTE)n_fats; /* Number of FATs */
5780+
// CIRCUITPY-CHANGE: optional FAT32 support
57695781
#if FF_MKFS_FAT32
57705782
st_word(buf + BPB_RootEntCnt, (WORD)((fmt == FS_FAT32) ? 0 : n_rootdir)); /* Number of root directory entries */
57715783
#else
@@ -5780,6 +5792,7 @@ FRESULT f_mkfs (
57805792
st_word(buf + BPB_SecPerTrk, 63); /* Number of sectors per track (for int13) */
57815793
st_word(buf + BPB_NumHeads, 255); /* Number of heads (for int13) */
57825794
st_dword(buf + BPB_HiddSec, b_vol); /* Volume offset in the physical drive [sector] */
5795+
// CIRCUITPY-CHANGE: optional FAT32 support
57835796
#if FF_MKFS_FAT32
57845797
if (fmt == FS_FAT32) {
57855798
st_dword(buf + BS_VolID32, volid); /* VSN */
@@ -5803,6 +5816,7 @@ FRESULT f_mkfs (
58035816
if (disk_write(pdrv, buf, b_vol, 1) != RES_OK) LEAVE_MKFS(FR_DISK_ERR); /* Write it to the VBR sector */
58045817

58055818
/* Create FSINFO record if needed */
5819+
// CIRCUITPY-CHANGE: optional FAT32 support
58065820
#if FF_MKFS_FAT32
58075821
if (fmt == FS_FAT32) {
58085822
disk_write(pdrv, buf, b_vol + 6, 1); /* Write backup VBR (VBR + 6) */
@@ -5821,6 +5835,7 @@ FRESULT f_mkfs (
58215835
mem_set(buf, 0, (UINT)szb_buf);
58225836
sect = b_fat; /* FAT start sector */
58235837
for (i = 0; i < n_fats; i++) { /* Initialize FATs each */
5838+
// CIRCUITPY-CHANGE: optional FAT32 support
58245839
#if FF_MKFS_FAT32
58255840
if (fmt == FS_FAT32) {
58265841
st_dword(buf + 0, 0xFFFFFFF8); /* Entry 0 */
@@ -5841,6 +5856,7 @@ FRESULT f_mkfs (
58415856
}
58425857

58435858
/* Initialize root directory (fill with zero) */
5859+
// CIRCUITPY-CHANGE: optional FAT32 support
58445860
#if FF_MKFS_FAT32
58455861
nsect = (fmt == FS_FAT32) ? pau : sz_dir; /* Number of root directory sectors */
58465862
#else
@@ -5857,6 +5873,7 @@ FRESULT f_mkfs (
58575873
if (FF_FS_EXFAT && fmt == FS_EXFAT) {
58585874
sys = 0x07; /* HPFS/NTFS/exFAT */
58595875
} else {
5876+
// CIRCUITPY-CHANGE: optional FAT32 support
58605877
if (FF_MKFS_FAT32 && fmt == FS_FAT32) {
58615878
sys = 0x0C; /* FAT32X */
58625879
} else {

‎lib/oofatfs/ff.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ typedef struct {
162162
DWORD bitbase; /* Allocation bitmap base sector */
163163
#endif
164164
DWORD winsect; /* Current sector appearing in the win[] */
165+
// CIRCUITPY-CHANGE: ensure alignment
165166
__attribute__((aligned(FF_WINDOW_ALIGNMENT),)) BYTE win[FF_MAX_SS]; /* Disk access window for Directory, FAT (and file data at tiny cfg). */
166167
} FATFS;
167168

@@ -334,6 +335,7 @@ FRESULT f_setcp (WORD cp); /* Set curre
334335
DWORD get_fattime (void);
335336
#endif
336337

338+
// CIRCUITPY-CHANGE: random volids
337339
#if FF_FS_MAKE_VOLID
338340
DWORD make_volid (void);
339341
#endif

‎lib/oofatfs/ffconf.h‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,15 @@
7272
#define FF_USE_MKFS 1
7373
/* This option switches f_mkfs() function. (0:Disable or 1:Enable) */
7474

75+
// CIRCUITPY-CHANGE: optional FAT32 support
7576
#ifdef MICROPY_FATFS_MKFS_FAT32
7677
#define FF_MKFS_FAT32 MICROPY_FATFS_MKFS_FAT32
7778
#else
7879
#define FF_MKFS_FAT32 0
7980
#endif
8081
/* This option switches off FAT32 support in f_mkfs() */
8182

83+
// CIRCUITPY-CHANGE: enable fast seek
8284
#define FF_USE_FASTSEEK 1
8385
/* This option switches fast seek function. (0:Disable or 1:Enable) */
8486

@@ -169,6 +171,7 @@
169171
/ memory for the working buffer, memory management functions, ff_memalloc() and
170172
/ ff_memfree() in ffsystem.c, need to be added to the project. */
171173

174+
// CIRCUITPY-CHANGE: unicode filenames for FAT
172175
#ifdef MICROPY_FATFS_LFN_UNICODE
173176
#define FF_LFN_UNICODE (MICROPY_FATFS_LFN_UNICODE)
174177
#else
@@ -267,6 +270,7 @@
267270
/ for variable sector size mode and disk_ioctl() function needs to implement
268271
/ GET_SECTOR_SIZE command. */
269272

273+
// CIRCUITPY-CHANGE: align FATFS window buffer for tinyusb
270274
#ifdef MICROPY_FATFS_WINDOW_ALIGNMENT
271275
#define FF_WINDOW_ALIGNMENT (MICROPY_FATFS_WINDOW_ALIGNMENT)
272276
#else
@@ -379,6 +383,7 @@
379383
/ SemaphoreHandle_t and etc. A header file for O/S definitions needs to be
380384
/ included somewhere in the scope of ff.h. */
381385

386+
// CIRCUITPY-CHANGE: random volids
382387
#ifndef FF_FS_MAKE_VOLID
383388
#define FF_FS_MAKE_VOLID (0)
384389
#endif

‎lib/oofatfs/ffunicode.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -499,6 +499,7 @@ DWORD ff_wtoupper ( /* Returns up-converted code point */
499499
DWORD uni /* Unicode code point to be up-converted */
500500
)
501501
{
502+
// CIRCUITPY-CHANGE
502503
#if FF_FS_CASE_INSENSITIVE_COMPARISON_ASCII_ONLY
503504
// Only uppercase ASCII characters. Everything else will require the user to
504505
// pass in an uppercase version.

‎ports/unix/mpconfigport.h‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,10 @@ typedef long mp_off_t;
152152
#define MICROPY_FATFS_RPATH (2)
153153
#define MICROPY_FATFS_MAX_SS (4096)
154154
#define MICROPY_FATFS_LFN_CODE_PAGE 437 /* 1=SFN/ANSI 437=LFN/U.S.(OEM) */
155+
// CIRCUITPY_CHANGE: enable FAT32 support
156+
#define MICROPY_FATFS_MKFS_FAT32 (1)
157+
// CIRCUITPY-CHANGE: allow FAT label access
158+
#define MICROPY_FATFS_USE_LABEL (1)
155159

156160
#define MICROPY_ALLOC_PATH_MAX (PATH_MAX)
157161

‎py/objstrunicode.c‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,10 @@ STATIC void uni_print_quoted(const mp_print_t *print, const byte *str_data, uint
7777
// CIRCUITPY-CHANGE: print printable Unicode chars
7878
} else if (ch <= 0x1f || (0x7f <= ch && ch <= 0xa0) || ch == 0xad) {
7979
mp_printf(print, "\\x%02x", ch);
80-
} else if ((0x2000 <= ch && ch <= 0x200f) || ch == 0x2028 || ch == 0x2029) {
80+
} else if ((0x2000 <= ch && ch <= 0x200f) || ch == 0x2028 || ch == 0x2029 || ch == 0xffff) {
8181
mp_printf(print, "\\u%04x", ch);
82+
} else if (ch == 0x1ffff) {
83+
mp_printf(print, "\\U%08x", ch);
8284
} else {
8385
// Print the full character out.
8486
int width = s - start;

‎tests/basics/slice_op.py.exp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
TypeError

‎tests/basics/string1.py‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
print(r'abc')
66
print(u'abc')
77
print(repr('\a\b\t\n\v\f\r'))
8-
print('\z') # unrecognised escape char
8+
# CIRCUITPY-CHANGE: unrecognized escape characters are caught with a SyntaxWarning in 3.12, so skip this test
9+
# MicroPython v1.23 (or maybe later) merge fixes this, so this is temporary
10+
### print('\z') # unrecognised escape char
911

1012
# construction
1113
print(str())

‎tests/basics/string_fstring.py‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ def foo(a, b):
3535
print(f"\\")
3636
print(f'#')
3737
try:
38-
eval("f'{\}'")
38+
# CIRCUITPY-CHANGE: 3.12 catches {\} with a syntax warning of invalid escape sequence
39+
# MicroPython v1.23 (or maybe later) merge fixes this, so this is temporary
40+
eval("f'{\\}'")
3941
except SyntaxError:
4042
print('SyntaxError')
4143
try:

0 commit comments

Comments
 (0)