Skip to content

Commit 5cdcf88

Browse files
committed
Fixes after the review
1 parent 2fac7c9 commit 5cdcf88

2 files changed

Lines changed: 3 additions & 7 deletions

File tree

shared-module/busdisplay/BusDisplay.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ static void _send_pixels(busdisplay_busdisplay_obj_t *self, uint8_t *pixels, uin
214214
}
215215

216216
static bool _refresh_area(busdisplay_busdisplay_obj_t *self, const displayio_area_t *area) {
217-
uint32_t buffer_size = CIRCUITPY_DISPLAY_AREA_BUFFER_SIZE / sizeof(uint32_t); // In uint32_ts
217+
uint16_t buffer_size = CIRCUITPY_DISPLAY_AREA_BUFFER_SIZE / sizeof(uint32_t); // In uint32_ts
218218

219219
displayio_area_t clipped;
220220
// Clip the area to the display by overlapping the areas. If there is no overlap then we're done.
@@ -223,7 +223,7 @@ static bool _refresh_area(busdisplay_busdisplay_obj_t *self, const displayio_are
223223
}
224224
uint16_t rows_per_buffer = displayio_area_height(&clipped);
225225
uint8_t pixels_per_word = (sizeof(uint32_t) * 8) / self->core.colorspace.depth;
226-
uint32_t pixels_per_buffer = displayio_area_size(&clipped);
226+
uint16_t pixels_per_buffer = displayio_area_size(&clipped);
227227

228228
uint16_t subrectangles = 1;
229229
// for SH1107 and other boundary constrained controllers

shared-module/displayio/bus_core.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ void displayio_display_bus_end_transaction(displayio_display_bus_t *self) {
117117
self->end_transaction(self->bus);
118118
}
119119

120-
static void _displayio_display_bus_send_region_commands(displayio_display_bus_t *self, displayio_display_core_t *display, displayio_area_t *area) {
120+
void displayio_display_bus_set_region_to_update(displayio_display_bus_t *self, displayio_display_core_t *display, displayio_area_t *area) {
121121
uint16_t x1 = area->x1 + self->colstart;
122122
uint16_t x2 = area->x2 + self->colstart;
123123
uint16_t y1 = area->y1 + self->rowstart;
@@ -235,10 +235,6 @@ static void _displayio_display_bus_send_region_commands(displayio_display_bus_t
235235
}
236236
}
237237

238-
void displayio_display_bus_set_region_to_update(displayio_display_bus_t *self, displayio_display_core_t *display, displayio_area_t *area) {
239-
_displayio_display_bus_send_region_commands(self, display, area);
240-
}
241-
242238
void displayio_display_bus_flush(displayio_display_bus_t *self) {
243239
if (self->flush != NULL) {
244240
self->flush(self->bus);

0 commit comments

Comments
 (0)