Assign key_count to MP_ROM_NONE on deinit (for gc)

Marco van der Kolk · Marco van der Kolk · commit 6dab35e0766f · 2023-07-08T15:21:58.000+02:00
Signed-off-by: Marco van der Kolk &lt;marco.git@vdkolk.nl&gt;
diff --git a/shared-module/keypad/ShiftRegisterKeys.c b/shared-module/keypad/ShiftRegisterKeys.c
@@ -116,6 +116,7 @@ void common_hal_keypad_shiftregisterkeys_deinit(keypad_shiftregisterkeys_obj_t *
         common_hal_digitalio_digitalinout_deinit(self->data_pins->items[key]);
     }
     self->data_pins = MP_ROM_NONE;
+    self->key_counts = MP_ROM_NONE;
 
     common_hal_keypad_deinit_core(self);
 }
@@ -125,8 +126,7 @@ size_t shiftregisterkeys_get_key_count(void *self_in) {
 
     size_t total = 0;
 
-    for (mp_uint_t i = 0; i < self->num_key_counts; i++)
-    {
+    for (mp_uint_t i = 0; i < self->num_key_counts; i++) {
         total += self->key_counts[i];
     }
 

Original file line number	Diff line number	Diff line change
`@@ -116,6 +116,7 @@ void common_hal_keypad_shiftregisterkeys_deinit(keypad_shiftregisterkeys_obj_t *`
`116`	`116`	`common_hal_digitalio_digitalinout_deinit(self->data_pins->items[key]);`
`117`	`117`	`}`
`118`	`118`	`self->data_pins = MP_ROM_NONE;`
	`119`	`+ self->key_counts = MP_ROM_NONE;`
`119`	`120`
`120`	`121`	`common_hal_keypad_deinit_core(self);`
`121`	`122`	`}`
`@@ -125,8 +126,7 @@ size_t shiftregisterkeys_get_key_count(void *self_in) {`
`125`	`126`
`126`	`127`	`size_t total = 0;`
`127`	`128`
`128`		`- for (mp_uint_t i = 0; i < self->num_key_counts; i++)`
`129`		`- {`
	`129`	`+ for (mp_uint_t i = 0; i < self->num_key_counts; i++) {`
`130`	`130`	`total += self->key_counts[i];`
`131`	`131`	`}`
`132`	`132`