Note something we should do

jepler · jepler · commit 8e94a912ff9c · 2025-01-07T14:06:40.000-06:00
diff --git a/ports/raspberrypi/common-hal/rp2pio/StateMachine.c b/ports/raspberrypi/common-hal/rp2pio/StateMachine.c
@@ -377,6 +377,7 @@ bool rp2pio_statemachine_construct(rp2pio_statemachine_obj_t *self,
         }
         const mcu_pin_obj_t *pin = mcu_get_pin_by_number(pin_number);
         if (!pin) {
+            // TODO: should be impossible, but free resources here anyway
             return false;
         }
         _pin_reference_count[pin_number]++;

Original file line number	Diff line number	Diff line change
`@@ -377,6 +377,7 @@ bool rp2pio_statemachine_construct(rp2pio_statemachine_obj_t *self,`
`377`	`377`	`}`
`378`	`378`	`const mcu_pin_obj_t *pin = mcu_get_pin_by_number(pin_number);`
`379`	`379`	`if (!pin) {`
	`380`	`+ // TODO: should be impossible, but free resources here anyway`
`380`	`381`	`return false;`
`381`	`382`	`}`
`382`	`383`	`_pin_reference_count[pin_number]++;`