remove unneeded -fno-inline-functions and -ggdb3; fix cxd56 noreturn warning

dhalbert · dhalbert · commit d85a4fc99758 · 2026-02-17T11:25:46.000-05:00
diff --git a/ports/cxd56/Makefile b/ports/cxd56/Makefile
@@ -74,7 +74,7 @@ CFLAGS += \
 	-fdata-sections \
 	-Wall \
 
-OPTIMIZATION_FLAGS ?= -O2 -fno-inline-functions
+OPTIMIZATION_FLAGS ?= -O2
 
 # option to override compiler optimization level, set in boards/$(BOARD)/mpconfigboard.mk
 CFLAGS += $(OPTIMIZATION_FLAGS)
diff --git a/ports/cxd56/common-hal/microcontroller/__init__.c b/ports/cxd56/common-hal/microcontroller/__init__.c
@@ -61,6 +61,8 @@ void common_hal_mcu_on_next_reset(mcu_runmode_t runmode) {
 void common_hal_mcu_reset(void) {
     filesystem_flush();
     boardctl(BOARDIOC_RESET, 0);
+    // boardctl is noreturn in this case.
+    __builtin_unreachable();
 }
 
 static const mp_rom_map_elem_t mcu_pin_globals_table[] = {
diff --git a/ports/litex/Makefile b/ports/litex/Makefile
@@ -32,7 +32,7 @@ ifeq ($(DEBUG), 1)
   OPTIMIZATION_FLAGS ?= -Og
 else
   CFLAGS += -DNDEBUG -ggdb3
-  OPTIMIZATION_FLAGS ?= -O2 -fno-inline-functions
+  OPTIMIZATION_FLAGS ?= -O2
 endif
 
 # option to override compiler optimization level, set in boards/$(BOARD)/mpconfigboard.mk
diff --git a/ports/nordic/Makefile b/ports/nordic/Makefile
@@ -36,8 +36,8 @@ ifeq ($(DEBUG), 1)
   CFLAGS += -ggdb3
   OPTIMIZATION_FLAGS = -Og
 else
-  OPTIMIZATION_FLAGS ?= -O2 -fno-inline-functions
-  CFLAGS += -DNDEBUG -ggdb3
+  OPTIMIZATION_FLAGS ?= -O2
+  CFLAGS += -DNDEBUG
 endif
 
 ifeq ($(NRF_DEBUG_PRINT), 1)
diff --git a/ports/silabs/Makefile b/ports/silabs/Makefile
@@ -71,7 +71,7 @@ ifeq ($(DEBUG), 1)
 	CFLAGS += -fno-inline -fno-ipa-sra -Og
 else
 	CFLAGS += -DNDEBUG
-	OPTIMIZATION_FLAGS ?= -Os -fno-inline-functions
+	OPTIMIZATION_FLAGS ?= -Os
 	CFLAGS += -g
 endif
 
diff --git a/ports/stm/Makefile b/ports/stm/Makefile
@@ -38,8 +38,7 @@ ifeq ($(DEBUG), 1)
 	CFLAGS += -fno-inline -fno-ipa-sra
 else
 	CFLAGS += -DNDEBUG
-	OPTIMIZATION_FLAGS ?= -O2 -fno-inline-functions
-	CFLAGS += -ggdb3
+	OPTIMIZATION_FLAGS ?= -O2
 endif
 
 # to override compiler optimization level, set in boards/$(BOARD)/mpconfigboard.mk

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,8 @@ void common_hal_mcu_on_next_reset(mcu_runmode_t runmode) {`
`61`	`61`	`void common_hal_mcu_reset(void) {`
`62`	`62`	`filesystem_flush();`
`63`	`63`	`boardctl(BOARDIOC_RESET, 0);`
	`64`	`+ // boardctl is noreturn in this case.`
	`65`	`+ __builtin_unreachable();`
`64`	`66`	`}`
`65`	`67`
`66`	`68`	`static const mp_rom_map_elem_t mcu_pin_globals_table[] = {`