Skip to content
This repository was archived by the owner on Feb 15, 2024. It is now read-only.

Commit 512af0e

Browse files
committed
Resolving compilation bug with EmbeddedDataSpecifications
1 parent a49ad09 commit 512af0e

6 files changed

Lines changed: 17 additions & 12 deletions

File tree

dataformat-xml/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@
2121
<artifactId>dataformat-core</artifactId>
2222
<version>${revision}</version>
2323
</dependency>
24+
<dependency>
25+
<groupId>io.adminshell.aas</groupId>
26+
<artifactId>dataformat-json</artifactId>
27+
<version>${revision}</version>
28+
</dependency>
2429
<dependency>
2530
<groupId>com.fasterxml.jackson.core</groupId>
2631
<artifactId>jackson-annotations</artifactId>

dataformat-xml/src/main/java/io/adminshell/aas/v3/dataformat/xml/XmlDeserializer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import io.adminshell.aas.v3.model.Capability;
2929
import io.adminshell.aas.v3.model.Category;
3030
import io.adminshell.aas.v3.model.ConceptDescription;
31-
import io.adminshell.aas.v3.model.DataSpecification;
31+
import io.adminshell.aas.v3.model.EmbeddedDataSpecification;
3232
import io.adminshell.aas.v3.model.DataSpecificationIEC61360;
3333
import io.adminshell.aas.v3.model.DataTypeIEC61360;
3434
import io.adminshell.aas.v3.model.Entity;
@@ -166,7 +166,7 @@ protected void buildMapper() {
166166

167167
protected SimpleModule buildCustomDeserializerModule() {
168168
SimpleModule module = new SimpleModule();
169-
module.addDeserializer(DataSpecification.class, new DataSpecificationDeserializer());
169+
module.addDeserializer(EmbeddedDataSpecification.class, new DataSpecificationDeserializer());
170170
module.addDeserializer(byte[].class, new ByteArrayDeserializer());
171171
return module;
172172
}

dataformat-xml/src/main/java/io/adminshell/aas/v3/dataformat/xml/XmlSerializer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
import io.adminshell.aas.v3.model.Capability;
6868
import io.adminshell.aas.v3.model.Category;
6969
import io.adminshell.aas.v3.model.ConceptDescription;
70-
import io.adminshell.aas.v3.model.DataSpecification;
70+
import io.adminshell.aas.v3.model.EmbeddedDataSpecification;
7171
import io.adminshell.aas.v3.model.DataSpecificationIEC61360;
7272
import io.adminshell.aas.v3.model.DataTypeIEC61360;
7373
import io.adminshell.aas.v3.model.Entity;
@@ -133,7 +133,7 @@ protected XmlMapper initMapper() {
133133
.addMixIn(Capability.class, CapabilityMixin.class)
134134
.addMixIn(ConceptDescription.class, ConceptDescriptionMixin.class)
135135
.addMixIn(DataSpecificationIEC61360.class, DataSpecificationIEC61360Mixin.class)
136-
.addMixIn(DataSpecification.class, DataSpecificationMixin.class)
136+
.addMixIn(EmbeddedDataSpecification.class, DataSpecificationMixin.class)
137137
.addMixIn(Entity.class, EntityMixin.class)
138138
.addMixIn(Extension.class, ExtensionMixin.class)
139139
.addMixIn(File.class, FileMixin.class)

dataformat-xml/src/main/java/io/adminshell/aas/v3/dataformat/xml/deserialization/DataSpecificationDeserializer.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@
1414
import com.fasterxml.jackson.databind.node.ObjectNode;
1515

1616
import io.adminshell.aas.v3.dataformat.xml.DataSpecificationManager;
17-
import io.adminshell.aas.v3.model.DataSpecification;
17+
import io.adminshell.aas.v3.model.EmbeddedDataSpecification;
1818
import io.adminshell.aas.v3.model.DataSpecificationContent;
1919
import io.adminshell.aas.v3.model.Reference;
20-
import io.adminshell.aas.v3.model.impl.DefaultDataSpecification;
20+
import io.adminshell.aas.v3.model.impl.DefaultEmbeddedDataSpecification;
2121

22-
public class DataSpecificationDeserializer extends JsonDeserializer<DataSpecification> {
22+
public class DataSpecificationDeserializer extends JsonDeserializer<EmbeddedDataSpecification> {
2323

2424
@Override
25-
public DataSpecification deserialize(JsonParser parser, DeserializationContext context)
25+
public EmbeddedDataSpecification deserialize(JsonParser parser, DeserializationContext context)
2626
throws IOException, JsonProcessingException {
2727
Object temp = parser.getCodec().readTree(parser);
2828
ObjectNode node = (ObjectNode) temp;
@@ -45,6 +45,6 @@ public DataSpecification deserialize(JsonParser parser, DeserializationContext c
4545
JsonParser parserContent = parser.getCodec().getFactory().getCodec().treeAsTokens(nodeContent);
4646
parserContent.nextToken();
4747
DataSpecificationContent content = parserContent.readValueAs(targetClass);
48-
return new DefaultDataSpecification.Builder().dataSpecificationContent(content).build();
48+
return new DefaultEmbeddedDataSpecification.Builder().dataSpecificationContent(content).build();
4949
}
5050
}

dataformat-xml/src/main/java/io/adminshell/aas/v3/dataformat/xml/mixin/ConceptDescriptionMixin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import com.fasterxml.jackson.annotation.JsonPropertyOrder;
77
import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty;
88

9-
import io.adminshell.aas.v3.model.DataSpecification;
9+
import io.adminshell.aas.v3.model.EmbeddedDataSpecification;
1010
import io.adminshell.aas.v3.model.Reference;
1111

1212
@JsonPropertyOrder({ "extensions", "idShort", "displayNames", "category", "descriptions", "administration",
@@ -17,6 +17,6 @@ public interface ConceptDescriptionMixin {
1717
public List<Reference> getIsCaseOfs();
1818

1919
@JsonIgnore
20-
public List<DataSpecification> getEmbeddedDataSpecifications();
20+
public List<EmbeddedDataSpecification> getEmbeddedDataSpecifications();
2121

2222
}

dataformat-xml/src/main/java/io/adminshell/aas/v3/dataformat/xml/serialization/EnumSerializer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package io.adminshell.aas.v3.dataformat.json.serialization;
1+
package io.adminshell.aas.v3.dataformat.xml.serialization;
22

33
import java.io.IOException;
44

0 commit comments

Comments
 (0)