Skip to content
This repository was archived by the owner on Feb 15, 2024. It is now read-only.

Commit e96184a

Browse files
committed
Refactor XML-Serializer Mixins
- clean up annotations
1 parent 0c4bb80 commit e96184a

7 files changed

Lines changed: 7 additions & 70 deletions

File tree

dataformat-xml/src/main/java/io/adminshell/aas/v3/dataformat/xml/mixin/AccessControlMixin.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,9 @@
1818
import java.util.List;
1919

2020
import com.fasterxml.jackson.annotation.JsonProperty;
21-
import com.fasterxml.jackson.annotation.JsonTypeInfo;
22-
import com.fasterxml.jackson.annotation.JsonTypeName;
2321

2422
import io.adminshell.aas.v3.model.AccessPermissionRule;
2523

26-
@JsonTypeName("AccessControl")
27-
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "modelType")
2824
public interface AccessControlMixin {
2925
@JsonProperty("accessPermissionRule")
3026
public List<AccessPermissionRule> getAccessPermissionRules();

dataformat-xml/src/main/java/io/adminshell/aas/v3/dataformat/xml/mixin/AccessControlPolicyPointsMixin.java

Lines changed: 0 additions & 27 deletions
This file was deleted.

dataformat-xml/src/main/java/io/adminshell/aas/v3/dataformat/xml/mixin/AccessPermissionRuleMixin.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import io.adminshell.aas.v3.model.PermissionsPerObject;
2424

2525
public interface AccessPermissionRuleMixin {
26-
2726
@JacksonXmlProperty(namespace = AasXmlNamespaceContext.ABAC_URI, localName = "permissionsPerObject")
2827
public List<PermissionsPerObject> getPermissionsPerObjects();
2928

dataformat-xml/src/main/java/io/adminshell/aas/v3/dataformat/xml/mixin/DataSpecificationContentMixin.java

Lines changed: 0 additions & 27 deletions
This file was deleted.

dataformat-xml/src/main/java/io/adminshell/aas/v3/dataformat/xml/mixin/DataSpecificationMixin.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,13 @@
1515
*/
1616
package io.adminshell.aas.v3.dataformat.xml.mixin;
1717

18-
19-
2018
import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty;
2119

2220
import io.adminshell.aas.v3.model.DataSpecificationContent;
2321

24-
// No order needed -> only one element
2522
public interface DataSpecificationMixin {
2623

27-
@JacksonXmlProperty(localName = "aas:dataSpecificationIEC61360")
28-
//@JacksonXmlElementWrapper(localName = "aas:dataSpecificationContent")
29-
public DataSpecificationContent getDataSpecificationContent();
30-
24+
@JacksonXmlProperty(localName = "aas:dataSpecificationIEC61360")
25+
public DataSpecificationContent getDataSpecificationContent();
26+
3127
}

dataformat-xml/src/main/java/io/adminshell/aas/v3/dataformat/xml/mixin/ValueListMixin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,5 @@
2525
public interface ValueListMixin {
2626

2727
@JacksonXmlProperty(namespace = AasXmlNamespaceContext.IEC61360_URI, localName = "valueReferencePair")
28-
List<ValueReferencePair> getValueReferencePairTypes();
28+
public List<ValueReferencePair> getValueReferencePairTypes();
2929
}

dataformat-xml/src/main/java/io/adminshell/aas/v3/dataformat/xml/mixin/ValueReferencePairMixin.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,13 @@
2323
import io.adminshell.aas.v3.dataformat.xml.serialization.NamespaceIndependentReferenceSerializer;
2424
import io.adminshell.aas.v3.model.Reference;
2525

26-
@JsonPropertyOrder({"valueId", "value"})
26+
@JsonPropertyOrder({ "valueId", "value" })
2727
public interface ValueReferencePairMixin {
2828

2929
@JacksonXmlProperty(namespace = AasXmlNamespaceContext.IEC61360_URI, localName = "valueId")
3030
@JsonSerialize(using = NamespaceIndependentReferenceSerializer.class)
31-
Reference getValueId();
31+
public Reference getValueId();
3232

3333
@JacksonXmlProperty(namespace = AasXmlNamespaceContext.IEC61360_URI, localName = "value")
34-
String getValue();
34+
public String getValue();
3535
}

0 commit comments

Comments
 (0)