Repository navigation
Commit c13bb38
feat(x402): public helpers for 402-emit + probe extra.name fix (1.3.4) (#11)
## Summary
Cleanup PR after the verify→settle fix chain (1.3.1 / 1.3.2 / 1.3.3).
Two parallel goals:
1. **Lift up the boilerplate every Python merchant inlined for emitting
x402 challenges** so the `extra.name` mistake (which silently breaks
every signature at the facilitator on base mainnet) can't recur.
2. **Fix the discovery probe + examples + tests** that hardcoded `extra:
{"name": "USDC"}` regardless of network (correct on sepolia, wrong on
mainnet — the actual USDC contract on Base mainnet returns `name() =
"USD Coin"`, sepolia returns `"USDC"`).
## New public API
```python
from agentscore_commerce.payment import build_x402_accepts_for_402
x402_accepts = build_x402_accepts_for_402(
x402_server,
network="eip155:8453",
price=f"${total_usd}",
pay_to=os.environ["TREASURY_BASE_RECIPIENT"],
max_timeout_seconds=300,
)
```
Returns a list of plain dicts ready for the 402 body's `accepts[]`. The
helper:
- Builds a typed `ResourceConfig` from kwargs (so callers don't import
the x402 type)
- Calls `server.build_payment_requirements(...)` which fills in `extra`
from the registered scheme metadata (sepolia gets `"USDC"`, mainnet gets
`"USD Coin"`, future networks get whatever the registered scheme says)
- Dumps each Pydantic `PaymentRequirements` to wire-shape via
`model_dump(by_alias=True, mode="json")`
- Falls through for dict-shaped requirements (older x402 / test stubs)
Also promoted from private (no behavior change; just public stability):
- `coerce_resource_config` (dict → `ResourceConfig`)
- `coerce_payment_payload` (dict → `PaymentPayload` / `PaymentPayloadV1`
per `x402Version`)
- `settle_result_to_json_bytes` (Pydantic `SettleResponse` → JSON bytes
via `model_dump_json(by_alias=True)`; falls through to `json.dumps` for
plain dicts)
## Probe / examples / tests
- `discovery/probe.py`: `sample_x402_accept_for_network` now returns:
- `eip155:8453` → `extra: {"name": "USD Coin", "version": "2"}` (was
`"USDC"`, wrong)
- `eip155:84532` → `extra: {"name": "USDC", "version": "2"}` (matches
the sepolia contract)
- `examples/multi_rail_merchant.py` + `examples/api_provider.py`: same
fix, comment points at `build_x402_accepts_for_402` as the cleaner
production pattern.
- `tests/test_discovery.py`: assertions updated; added explicit sepolia
assertion.
## Tests
- New:
`test_build_x402_accepts_for_402_returns_dicts_from_typed_requirements`
(passes typed `ResourceConfig` to the server, returns wire-shape dicts
with `payTo`/`maxTimeoutSeconds`/`extra` camelCase)
- Full suite: 724 passed, 3 skipped, **95.16% coverage**.
## Doc updates
- `README.md` + `CLAUDE.md` +
`core/docs/integrations/python-commerce.mdx` all gain a
`build_x402_accepts_for_402` snippet.
## Test plan
- [ ] CI green.
- [ ] Tag `v1.3.4`, push tag → PyPI publish.
- [ ] Bump `core/store/uv.lock` to 1.3.4 + refactor
`store/routes/purchase.py` to use the new helper (folded into existing
core PR #237).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 69eaddb commit c13bb38
12 files changed
Lines changed: 179 additions & 30 deletions
File tree
- agentscore_commerce
- discovery
- payment
- examples
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
250 | 266 | | |
251 | 267 | | |
252 | 268 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
43 | 47 | | |
44 | 48 | | |
45 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| 55 | + | |
55 | 56 | | |
56 | 57 | | |
57 | 58 | | |
| |||
61 | 62 | | |
62 | 63 | | |
63 | 64 | | |
| 65 | + | |
| 66 | + | |
64 | 67 | | |
| 68 | + | |
65 | 69 | | |
66 | 70 | | |
67 | 71 | | |
| |||
114 | 118 | | |
115 | 119 | | |
116 | 120 | | |
| 121 | + | |
117 | 122 | | |
| 123 | + | |
| 124 | + | |
118 | 125 | | |
119 | 126 | | |
120 | 127 | | |
| |||
130 | 137 | | |
131 | 138 | | |
132 | 139 | | |
| 140 | + | |
133 | 141 | | |
134 | 142 | | |
135 | 143 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
266 | 266 | | |
267 | 267 | | |
268 | 268 | | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
269 | 333 | | |
270 | 334 | | |
271 | 335 | | |
272 | 336 | | |
273 | 337 | | |
| 338 | + | |
274 | 339 | | |
275 | 340 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
189 | 189 | | |
190 | 190 | | |
191 | 191 | | |
192 | | - | |
| 192 | + | |
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
| |||
220 | 220 | | |
221 | 221 | | |
222 | 222 | | |
223 | | - | |
| 223 | + | |
224 | 224 | | |
225 | 225 | | |
226 | 226 | | |
| |||
252 | 252 | | |
253 | 253 | | |
254 | 254 | | |
255 | | - | |
256 | | - | |
| 255 | + | |
| 256 | + | |
257 | 257 | | |
258 | 258 | | |
259 | 259 | | |
| |||
321 | 321 | | |
322 | 322 | | |
323 | 323 | | |
324 | | - | |
| 324 | + | |
325 | 325 | | |
326 | 326 | | |
327 | 327 | | |
| |||
332 | 332 | | |
333 | 333 | | |
334 | 334 | | |
335 | | - | |
| 335 | + | |
336 | 336 | | |
337 | 337 | | |
338 | 338 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
132 | | - | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
133 | 141 | | |
134 | 142 | | |
135 | 143 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| 72 | + | |
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
| |||
250 | 251 | | |
251 | 252 | | |
252 | 253 | | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
253 | 257 | | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
271 | 265 | | |
272 | 266 | | |
273 | 267 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
179 | | - | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
180 | 182 | | |
181 | 183 | | |
182 | 184 | | |
| |||
185 | 187 | | |
186 | 188 | | |
187 | 189 | | |
| 190 | + | |
| 191 | + | |
188 | 192 | | |
189 | 193 | | |
190 | 194 | | |
| |||
0 commit comments