Skip to content

Commit 9dcf05c

Browse files
committed
fix(bio-research): download FASTQ files over HTTPS instead of HTTP
ENA FTP paths were converted to plain HTTP URLs, meaning multi-GB genomic downloads had no transport-layer encryption. ENA supports HTTPS on the same paths. Changed http:// to https:// on line 343. Fixes #166
1 parent 976999e commit 9dcf05c

File tree

1 file changed

+3
-3
lines changed
  • bio-research/skills/nextflow-development/scripts/utils

1 file changed

+3
-3
lines changed

bio-research/skills/nextflow-development/scripts/utils/ncbi_utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -338,9 +338,9 @@ def fetch_ena_fastq_urls(study_accession: str) -> Dict[str, List[str]]:
338338
srr = fields[run_idx]
339339
ftp_urls = fields[ftp_idx]
340340
if ftp_urls:
341-
# URLs are semicolon-separated, convert to HTTP URLs
342-
# ENA supports both FTP and HTTP, HTTP is easier with requests
343-
urls = [f"http://{url}" for url in ftp_urls.split(';') if url]
341+
# URLs are semicolon-separated, convert to HTTPS URLs
342+
# ENA supports HTTPS for encrypted downloads
343+
urls = [f"https://{url}" for url in ftp_urls.split(';') if url]
344344
fastq_urls[srr] = urls
345345

346346
return fastq_urls

0 commit comments

Comments
 (0)