Skip to content

Commit 9cd7f58

Browse files
kouclaude
andauthored
fix(dev/release): pin surefire version for Java JAR verification (#4948)
Debian's Maven package patches the default surefire version to 2.17, which doesn't support the JUnit Platform. As a result, no tests in VerifyReleaseCandidateTest were run and the verification passed without checking anything. Pin maven-surefire-plugin to 3.5.2 and enable failIfNoTests so that the verification fails if no tests are run. Closes #4947. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 3a4843e commit 9cd7f58

1 file changed

Lines changed: 17 additions & 0 deletions

File tree

‎dev/release/verify/java/pom.xml‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,23 @@
9393
</dependency>
9494
</dependencies>
9595

96+
<build>
97+
<pluginManagement>
98+
<plugins>
99+
<!-- Pin the version: some distributions (e.g. Debian) patch Maven's
100+
default to surefire 2.17, which can't run JUnit 5 tests. -->
101+
<plugin>
102+
<groupId>org.apache.maven.plugins</groupId>
103+
<artifactId>maven-surefire-plugin</artifactId>
104+
<version>3.5.2</version>
105+
<configuration>
106+
<failIfNoTests>true</failIfNoTests>
107+
</configuration>
108+
</plugin>
109+
</plugins>
110+
</pluginManagement>
111+
</build>
112+
96113
<profiles>
97114
<profile>
98115
<id>java-25+</id>

0 commit comments

Comments
 (0)