From f16be949ebe32c7a7ce22980367ed86e387f5bac Mon Sep 17 00:00:00 2001 From: Abhishek Kumar Date: Thu, 14 May 2026 16:53:06 +0530 Subject: [PATCH 1/3] ui: do not show deploy instance button for not ready images Currently, InfoCard for a not ready template shows deploy instance button which is incorrect. Signed-off-by: Abhishek Kumar --- ui/src/components/view/ImageDeployInstanceButton.vue | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ui/src/components/view/ImageDeployInstanceButton.vue b/ui/src/components/view/ImageDeployInstanceButton.vue index 2cdd5a0af460..7006bb7d495d 100644 --- a/ui/src/components/view/ImageDeployInstanceButton.vue +++ b/ui/src/components/view/ImageDeployInstanceButton.vue @@ -83,7 +83,8 @@ export default { computed: { allowed () { return (this.$route.meta.name === 'template' || - (this.$route.meta.name === 'iso' && this.resource.bootable)) + (this.$route.meta.name === 'iso' && this.resource?.bootable)) && + this.resource?.state === 'Ready' } }, methods: { @@ -91,7 +92,7 @@ export default { this.fetchResourceData() }, fetchResourceData () { - if (!this.resource || !this.resource.id) { + if (!this.resource || !this.resource.id || this.resource.state !== 'Ready') { return } const params = { From 9537afb7dd425ab430e615c24d67310ada613430 Mon Sep 17 00:00:00 2001 From: Abhishek Kumar Date: Wed, 20 May 2026 17:27:11 +0530 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Abhishek Kumar --- ui/src/components/view/ImageDeployInstanceButton.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/src/components/view/ImageDeployInstanceButton.vue b/ui/src/components/view/ImageDeployInstanceButton.vue index 7006bb7d495d..cdfadd5e3261 100644 --- a/ui/src/components/view/ImageDeployInstanceButton.vue +++ b/ui/src/components/view/ImageDeployInstanceButton.vue @@ -84,7 +84,7 @@ export default { allowed () { return (this.$route.meta.name === 'template' || (this.$route.meta.name === 'iso' && this.resource?.bootable)) && - this.resource?.state === 'Ready' + this.resource.isready } }, methods: { @@ -92,7 +92,7 @@ export default { this.fetchResourceData() }, fetchResourceData () { - if (!this.resource || !this.resource.id || this.resource.state !== 'Ready') { + if (!this.resource || !this.resource.id || !this.resource.isready) { return } const params = { From 9a06a57fad851b9639921eed4c22d1510a8934b9 Mon Sep 17 00:00:00 2001 From: Abhishek Kumar Date: Thu, 21 May 2026 01:50:20 +0530 Subject: [PATCH 3/3] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- ui/src/components/view/ImageDeployInstanceButton.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/src/components/view/ImageDeployInstanceButton.vue b/ui/src/components/view/ImageDeployInstanceButton.vue index cdfadd5e3261..a4d47d4464ae 100644 --- a/ui/src/components/view/ImageDeployInstanceButton.vue +++ b/ui/src/components/view/ImageDeployInstanceButton.vue @@ -84,7 +84,7 @@ export default { allowed () { return (this.$route.meta.name === 'template' || (this.$route.meta.name === 'iso' && this.resource?.bootable)) && - this.resource.isready + !!this.resource?.isready } }, methods: {