Skip to content

Commit 3515095

Browse files
heliang666sheliangsongxiaosheng
authored
Fix ClassCastException caused by overly broad type check in Dubbo tracing integration with Spring WebFlux. (#15371)
Co-authored-by: heliang <heliang1@xiaohongshu.com> Co-authored-by: xiaosheng <songxiaosheng@apache.org>
1 parent 1e070b5 commit 3515095

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

dubbo-metrics/dubbo-tracing/src/main/java/org/apache/dubbo/tracing/handler/DubboClientTracingObservationHandler.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
import io.micrometer.observation.Observation;
2222
import io.micrometer.observation.ObservationHandler;
23-
import io.micrometer.observation.transport.SenderContext;
2423
import io.micrometer.tracing.Tracer;
2524

2625
public class DubboClientTracingObservationHandler<T extends DubboClientContext> implements ObservationHandler<T> {
@@ -35,6 +34,6 @@ public void onScopeOpened(T context) {}
3534

3635
@Override
3736
public boolean supportsContext(Observation.Context context) {
38-
return context instanceof SenderContext;
37+
return context instanceof DubboClientContext;
3938
}
4039
}

dubbo-metrics/dubbo-tracing/src/main/java/org/apache/dubbo/tracing/handler/DubboServerTracingObservationHandler.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
import io.micrometer.observation.Observation;
2323
import io.micrometer.observation.ObservationHandler;
24-
import io.micrometer.observation.transport.ReceiverContext;
2524
import io.micrometer.tracing.TraceContext;
2625
import io.micrometer.tracing.Tracer;
2726

@@ -46,6 +45,6 @@ public void onScopeOpened(T context) {
4645

4746
@Override
4847
public boolean supportsContext(Observation.Context context) {
49-
return context instanceof ReceiverContext;
48+
return context instanceof DubboServerContext;
5049
}
5150
}

0 commit comments

Comments
 (0)