Skip to content

Commit 48b2389

Browse files
authored
Add listener to NacosMetadataReport casListenMap without serviceKey checking (#15476)
1 parent 3e8d1f5 commit 48b2389

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

dubbo-metadata/dubbo-metadata-report-nacos/src/main/java/org/apache/dubbo/metadata/store/nacos/NacosMetadataReport.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -300,13 +300,16 @@ public ConfigItem getConfigItem(String key, String group) {
300300
return new ConfigItem(content, casMd5);
301301
}
302302

303+
/**
304+
* allow adding listener without checking if the serviceKey is existed in the map.
305+
* there are multiple references which have the same serviceKey but might have multiple listeners,
306+
* because the extra parameters of their subscribed URLs might be different.
307+
*/
303308
@Override
304309
public Set<String> getServiceAppMapping(String serviceKey, MappingListener listener, URL url) {
305310
String group = DEFAULT_MAPPING_GROUP;
306311

307-
if (null == casListenerMap.get(buildListenerKey(serviceKey, group))) {
308-
addCasServiceMappingListener(serviceKey, group, listener);
309-
}
312+
addCasServiceMappingListener(serviceKey, group, listener);
310313
String content = getConfig(serviceKey, group);
311314
return ServiceNameMapping.getAppNames(content);
312315
}

0 commit comments

Comments
 (0)