Remove System.out from the unit test cases. (#15523)

Author: little-kid-an

dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/StickyTest.java

@@ -71,7 +71,6 @@ public void setUp() throws Exception {
     @Test
     void testStickyNoCheck() {
         int count = testSticky("t1", false);
-        System.out.println(count);
         Assertions.assertTrue(count > 0 && count <= runs);
     }
 
@@ -84,7 +83,6 @@ void testStickyForceCheck() {
     @Test
     void testMethodStickyNoCheck() {
         int count = testSticky("method1", false);
-        System.out.println(count);
         Assertions.assertTrue(count > 0 && count <= runs);
     }
 

dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/loadbalance/AdaptiveLoadBalanceTest.java

@@ -68,9 +68,6 @@ void testSelectByWeight() {
         }
 
         // 1 : 9 : 6
-        System.out.println(sumInvoker1);
-        System.out.println(sumInvoker2);
-        System.out.println(sumInvoker3);
         Assertions.assertEquals(sumInvoker1 + sumInvoker2 + sumInvoker3, loop, "select failed!");
     }
 

dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/loadbalance/LeastActiveBalanceTest.java

@@ -33,7 +33,6 @@ void testLeastActiveLoadBalance_select() {
         Map<Invoker, AtomicLong> counter = getInvokeCounter(runs, LeastActiveLoadBalance.NAME);
         for (Map.Entry<Invoker, AtomicLong> entry : counter.entrySet()) {
             Long count = entry.getValue().get();
-            //            System.out.println(count);
             Assertions.assertTrue(
                     Math.abs(count - runs / (0f + invokers.size())) < runs / (0f + invokers.size()),
                     "abs diff should < avg");
@@ -63,8 +62,6 @@ void testSelectByWeight() {
         }
 
         // the sumInvoker1 : sumInvoker2 approximately equal to 1: 9
-        System.out.println(sumInvoker1);
-        System.out.println(sumInvoker2);
 
         Assertions.assertEquals(sumInvoker1 + sumInvoker2, loop, "select failed!");
     }

dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/loadbalance/RandomLoadBalanceTest.java

@@ -81,9 +81,6 @@ void testSelectByWeight() {
         }
 
         // 1 : 9 : 6
-        System.out.println(sumInvoker1);
-        System.out.println(sumInvoker2);
-        System.out.println(sumInvoker3);
         Assertions.assertEquals(sumInvoker1 + sumInvoker2 + sumInvoker3, loop, "select failed!");
     }
 }

dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/loadbalance/ShortestResponseLoadBalanceTest.java

@@ -60,8 +60,6 @@ public void testSelectByWeight() {
         }
 
         // the sumInvoker1 : sumInvoker2 approximately equal to 1: 9
-        System.out.println(sumInvoker1);
-        System.out.println(sumInvoker2);
 
         Assertions.assertEquals(sumInvoker1 + sumInvoker2, loop, "select failed!");
     }

dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/router/affinity/AffinityRouteTest.java

@@ -33,10 +33,13 @@
 
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 public class AffinityRouteTest {
+    private static final Logger logger = LoggerFactory.getLogger(AffinityRouteTest.class);
 
     private static BitList<Invoker<String>> invokers;
 
@@ -127,7 +130,7 @@ void testMetAffinityRoute() {
         List<String> filtered = filtrate(new ArrayList<String>(providerUrls), "region=beijing");
 
         assertEquals(filtered.size(), res.size());
-        System.out.println("The affinity routing condition is met and the result is routed");
+        logger.info("The affinity routing condition is met and the result is routed");
     }
 
     @Test
@@ -158,7 +161,7 @@ void testUnMetAffinityRoute() {
         List<String> filtered = filtrate(new ArrayList<String>(providerUrls), "region=beijing");
 
         assertEquals(invokers.size(), res.size());
-        System.out.println("The affinity routing condition was not met and the result was not routed");
+        logger.info("The affinity routing condition was not met and the result was not routed");
     }
 
     @Test
@@ -189,7 +192,7 @@ void testRatioEqualsAffinityRoute() {
         List<String> filtered = filtrate(new ArrayList<String>(providerUrls), "region=beijing");
 
         assertEquals(filtered.size(), res.size());
-        System.out.println("The affinity routing condition is met and the result is routed");
+        logger.info("The affinity routing condition is met and the result is routed");
     }
 
     @Test
@@ -220,6 +223,6 @@ void testRatioNotEqualsAffinityRoute() {
         List<String> filtered = filtrate(new ArrayList<String>(providerUrls), "region=beijing");
 
         assertEquals(invokers.size(), res.size());
-        System.out.println("The affinity routing condition was not met and the result was not routed");
+        logger.info("The affinity routing condition was not met and the result was not routed");
     }
 }

dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/router/condition/config/ConditionStateRouterTestV31.java

@@ -113,7 +113,6 @@ public void testParseRawRule() {
         Assertions.assertEquals(rule.getConditions().size(), 2);
         Assertions.assertEquals(rule.getConditions().get(0).getTo().size(), 3);
         Assertions.assertEquals(rule.getConditions().get(1).getTo().size(), 1);
-        System.out.println("rule.getConditions() = " + rule.getConditions());
     }
 
     @Test
@@ -451,7 +450,6 @@ public void testMultiplyDestination() {
 
             actualDistribution.put(result.size(), actualDistribution.getOrDefault(result.size(), 0) + 1);
         }
-        System.out.println("actualDistribution = " + actualDistribution);
         int sum = 0;
         for (Map.Entry<Integer, Integer> entry : actualDistribution.entrySet()) {
             sum += entry.getValue();

dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/router/mesh/rule/DestinationRuleTest.java

@@ -40,8 +40,6 @@ void parserTest() {
                 this.getClass().getClassLoader().getResourceAsStream("DestinationRuleTest.yaml"),
                 DestinationRule.class);
 
-        System.out.println(destinationRule);
-
         //        apiVersion: service.dubbo.apache.org/v1alpha1
         //        kind: DestinationRule
         //        metadata: { name: demo-route }
@@ -102,11 +100,9 @@ void parserMultiRuleTest() {
             Map resultMap = (Map) result;
             if (resultMap.get("kind").equals(DESTINATION_RULE_KEY)) {
                 DestinationRule destinationRule = yaml2.loadAs(yaml2.dump(result), DestinationRule.class);
-                System.out.println(destinationRule);
                 assertNotNull(destinationRule);
             } else if (resultMap.get(KIND_KEY).equals(VIRTUAL_SERVICE_KEY)) {
                 VirtualServiceRule virtualServiceRule = yaml2.loadAs(yaml2.dump(result), VirtualServiceRule.class);
-                System.out.println(virtualServiceRule);
                 assertNotNull(virtualServiceRule);
             }
         }

dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/router/mesh/rule/VirtualServiceRuleTest.java

@@ -38,7 +38,6 @@ void parserTest() {
                 this.getClass().getClassLoader().getResourceAsStream("VirtualServiceTest.yaml"),
                 VirtualServiceRule.class);
 
-        System.out.println(virtualServiceRule);
         assertNotNull(virtualServiceRule);
 
         assertEquals("service.dubbo.apache.org/v1alpha1", virtualServiceRule.getApiVersion());

dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/AbstractClusterInvokerTest.java

@@ -499,7 +499,6 @@ void testSelectBalance() {
 
         for (Map.Entry<Invoker, AtomicLong> entry : counter.entrySet()) {
             Long count = entry.getValue().get();
-            //            System.out.println(count);
             if (entry.getKey().isAvailable())
                 Assertions.assertTrue(count > runs / invokers.size(), "count should > avg");
         }