Get bytes using UTF-8 charset (#15483)

zrlw · web-flow · commit 55d1c092cb98 · 2025-06-24T15:27:39.000+08:00
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/io/Bytes.java b/dubbo-common/src/main/java/org/apache/dubbo/common/io/Bytes.java
@@ -23,6 +23,7 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
+import java.nio.charset.StandardCharsets;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
 import java.util.Map;
@@ -823,7 +824,7 @@ public static byte[] unzip(byte[] bytes) throws IOException {
      * @return MD5 byte array.
      */
     public static byte[] getMD5(String str) {
-        return getMD5(str.getBytes());
+        return getMD5(str.getBytes(StandardCharsets.UTF_8));
     }
 
     /**
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/utils/JVMUtil.java b/dubbo-common/src/main/java/org/apache/dubbo/common/utils/JVMUtil.java
@@ -24,6 +24,7 @@
 import java.lang.management.MonitorInfo;
 import java.lang.management.ThreadInfo;
 import java.lang.management.ThreadMXBean;
+import java.nio.charset.StandardCharsets;
 
 import static java.lang.Thread.State.BLOCKED;
 import static java.lang.Thread.State.TIMED_WAITING;
@@ -33,7 +34,7 @@ public class JVMUtil {
     public static void jstack(OutputStream stream) throws Exception {
         ThreadMXBean threadMxBean = ManagementFactory.getThreadMXBean();
         for (ThreadInfo threadInfo : threadMxBean.dumpAllThreads(true, true)) {
-            stream.write(getThreadDumpString(threadInfo).getBytes());
+            stream.write(getThreadDumpString(threadInfo).getBytes(StandardCharsets.UTF_8));
         }
     }
 
diff --git a/dubbo-maven-plugin/src/main/java/org/apache/dubbo/maven/plugin/protoc/DubboProtocCompilerMojo.java b/dubbo-maven-plugin/src/main/java/org/apache/dubbo/maven/plugin/protoc/DubboProtocCompilerMojo.java
@@ -533,6 +533,7 @@ public String getOutput() {
     }
 
     private static String fixUnicodeOutput(final String message) {
+        // TODO default charset is not UTF-8 ?
         return new String(message.getBytes(), StandardCharsets.UTF_8);
     }
 }
diff --git a/dubbo-plugin/dubbo-auth/src/main/java/org/apache/dubbo/auth/BasicAuthenticator.java b/dubbo-plugin/dubbo-auth/src/main/java/org/apache/dubbo/auth/BasicAuthenticator.java
@@ -21,6 +21,7 @@
 import org.apache.dubbo.common.URL;
 import org.apache.dubbo.rpc.Invocation;
 
+import java.nio.charset.StandardCharsets;
 import java.util.Base64;
 import java.util.Objects;
 
@@ -31,7 +32,7 @@ public void sign(Invocation invocation, URL url) {
         String username = url.getParameter(Constants.USERNAME_KEY);
         String password = url.getParameter(Constants.PASSWORD_KEY);
         String auth = username + ":" + password;
-        String encodedAuth = Base64.getEncoder().encodeToString(auth.getBytes());
+        String encodedAuth = Base64.getEncoder().encodeToString(auth.getBytes(StandardCharsets.UTF_8));
         String authHeaderValue = "Basic " + encodedAuth;
 
         invocation.setAttachment(Constants.AUTHORIZATION_HEADER_LOWER, authHeaderValue);
@@ -42,7 +43,7 @@ public void authenticate(Invocation invocation, URL url) throws RpcAuthenticatio
         String username = url.getParameter(Constants.USERNAME_KEY);
         String password = url.getParameter(Constants.PASSWORD_KEY);
         String auth = username + ":" + password;
-        String encodedAuth = Base64.getEncoder().encodeToString(auth.getBytes());
+        String encodedAuth = Base64.getEncoder().encodeToString(auth.getBytes(StandardCharsets.UTF_8));
         String authHeaderValue = "Basic " + encodedAuth;
 
         if (!Objects.equals(authHeaderValue, invocation.getAttachment(Constants.AUTHORIZATION_HEADER))
diff --git a/dubbo-plugin/dubbo-auth/src/main/java/org/apache/dubbo/auth/utils/SignatureUtils.java b/dubbo-plugin/dubbo-auth/src/main/java/org/apache/dubbo/auth/utils/SignatureUtils.java
@@ -64,7 +64,7 @@ private static String sign(byte[] data, String key) throws RuntimeException {
         } catch (NoSuchAlgorithmException e) {
             throw new RuntimeException("Failed to generate HMAC: no such algorithm exception " + HMAC_SHA256_ALGORITHM);
         }
-        SecretKeySpec signingKey = new SecretKeySpec(key.getBytes(), HMAC_SHA256_ALGORITHM);
+        SecretKeySpec signingKey = new SecretKeySpec(key.getBytes(StandardCharsets.UTF_8), HMAC_SHA256_ALGORITHM);
         try {
             mac.init(signingKey);
         } catch (InvalidKeyException e) {
diff --git a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/handler/ForeignHostPermitHandler.java b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/handler/ForeignHostPermitHandler.java
@@ -22,6 +22,7 @@
 
 import java.net.InetAddress;
 import java.net.InetSocketAddress;
+import java.nio.charset.StandardCharsets;
 import java.util.function.Predicate;
 
 import io.netty.buffer.ByteBuf;
@@ -74,7 +75,7 @@ public void handlerAdded(ChannelHandlerContext ctx) throws Exception {
 
         ByteBuf cb = Unpooled.wrappedBuffer((QosConstants.BR_STR
                         + "Foreign Ip Not Permitted, Consider Config It In Whitelist." + QosConstants.BR_STR)
-                .getBytes());
+                .getBytes(StandardCharsets.UTF_8));
         ctx.writeAndFlush(cb).addListener(ChannelFutureListener.CLOSE);
     }
 
diff --git a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/handler/HttpProcessHandler.java b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/handler/HttpProcessHandler.java
@@ -27,6 +27,8 @@
 import org.apache.dubbo.qos.command.exception.PermissionDenyException;
 import org.apache.dubbo.rpc.model.FrameworkModel;
 
+import java.nio.charset.StandardCharsets;
+
 import io.netty.buffer.Unpooled;
 import io.netty.channel.ChannelFutureListener;
 import io.netty.channel.ChannelHandlerContext;
@@ -68,9 +70,11 @@ public HttpProcessHandler(FrameworkModel frameworkModel, QosConfiguration qosCon
 
     private static FullHttpResponse http(int httpCode, String result) {
         FullHttpResponse response = new DefaultFullHttpResponse(
-                HttpVersion.HTTP_1_1, HttpResponseStatus.valueOf(httpCode), Unpooled.wrappedBuffer(result.getBytes()));
+                HttpVersion.HTTP_1_1,
+                HttpResponseStatus.valueOf(httpCode),
+                Unpooled.wrappedBuffer(result.getBytes(StandardCharsets.UTF_8)));
         HttpHeaders httpHeaders = response.headers();
-        httpHeaders.set(HttpHeaderNames.CONTENT_TYPE, "text/plain");
+        httpHeaders.set(HttpHeaderNames.CONTENT_TYPE, "text/plain; charset=utf-8");
         httpHeaders.set(HttpHeaderNames.CONTENT_LENGTH, response.content().readableBytes());
         return response;
     }
diff --git a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/handler/QosProcessHandler.java b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/handler/QosProcessHandler.java
@@ -20,6 +20,7 @@
 import org.apache.dubbo.qos.api.QosConfiguration;
 import org.apache.dubbo.rpc.model.FrameworkModel;
 
+import java.nio.charset.StandardCharsets;
 import java.util.List;
 import java.util.concurrent.TimeUnit;
 
@@ -60,8 +61,8 @@ public void channelActive(final ChannelHandlerContext ctx) throws Exception {
                         () -> {
                             final String welcome = qosConfiguration.getWelcome();
                             if (welcome != null) {
-                                ctx.write(Unpooled.wrappedBuffer(welcome.getBytes()));
-                                ctx.writeAndFlush(Unpooled.wrappedBuffer(PROMPT.getBytes()));
+                                ctx.write(Unpooled.wrappedBuffer(welcome.getBytes(StandardCharsets.UTF_8)));
+                                ctx.writeAndFlush(Unpooled.wrappedBuffer(PROMPT.getBytes(StandardCharsets.UTF_8)));
                             }
                         },
                         500,
diff --git a/dubbo-plugin/dubbo-spring-security/src/main/java/org/apache/dubbo/spring/security/jackson/ObjectMapperCodec.java b/dubbo-plugin/dubbo-spring-security/src/main/java/org/apache/dubbo/spring/security/jackson/ObjectMapperCodec.java
@@ -22,6 +22,7 @@
 import org.apache.dubbo.common.utils.ClassUtils;
 import org.apache.dubbo.common.utils.StringUtils;
 
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.function.Consumer;
@@ -64,7 +65,7 @@ public <T> T deserialize(String content, Class<T> clazz) {
         if (StringUtils.isBlank(content)) {
             return null;
         }
-        return deserialize(content.getBytes(), clazz);
+        return deserialize(content.getBytes(StandardCharsets.UTF_8), clazz);
     }
 
     public String serialize(Object object) {
diff --git a/dubbo-plugin/dubbo-triple-websocket/src/main/java/org/apache/dubbo/rpc/protocol/tri/websocket/TripleTextMessageHandler.java b/dubbo-plugin/dubbo-triple-websocket/src/main/java/org/apache/dubbo/rpc/protocol/tri/websocket/TripleTextMessageHandler.java
@@ -23,6 +23,8 @@
 
 import javax.websocket.MessageHandler;
 
+import java.nio.charset.StandardCharsets;
+
 public class TripleTextMessageHandler implements MessageHandler.Partial<String> {
 
     private final WebSocketTransportListener webSocketTransportListener;
@@ -33,8 +35,8 @@ public TripleTextMessageHandler(WebSocketTransportListener webSocketTransportLis
 
     @Override
     public void onMessage(String messagePart, boolean last) {
-        Http2InputMessage http2InputMessage =
-                new Http2InputMessageFrame(new FinalFragmentByteArrayInputStream(messagePart.getBytes(), last), false);
+        Http2InputMessage http2InputMessage = new Http2InputMessageFrame(
+                new FinalFragmentByteArrayInputStream(messagePart.getBytes(StandardCharsets.UTF_8), last), false);
         webSocketTransportListener.onData(http2InputMessage);
     }
 }
diff --git a/dubbo-registry/dubbo-registry-api/src/test/java/org/apache/dubbo/registry/ZKTools.java b/dubbo-registry/dubbo-registry-api/src/test/java/org/apache/dubbo/registry/ZKTools.java
@@ -231,7 +231,7 @@ public static void tesConditionRule() {
     }
 
     public static void setData(String path, String data) throws Exception {
-        client.setData().inBackground().forPath(path, data.getBytes());
+        client.setData().inBackground().forPath(path, data.getBytes(StandardCharsets.UTF_8));
     }
 
     public static void testPathCache() throws Exception {
diff --git a/dubbo-registry/dubbo-registry-multicast/src/main/java/org/apache/dubbo/registry/multicast/MulticastRegistry.java b/dubbo-registry/dubbo-registry-multicast/src/main/java/org/apache/dubbo/registry/multicast/MulticastRegistry.java
@@ -37,6 +37,7 @@
 import java.net.InetSocketAddress;
 import java.net.MulticastSocket;
 import java.net.Socket;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashSet;
@@ -260,7 +261,7 @@ private void multicast(String msg) {
             logger.info("Send multicast message: " + msg + " to " + multicastAddress + ":" + multicastPort);
         }
         try {
-            byte[] data = (msg + "\n").getBytes();
+            byte[] data = (msg + "\n").getBytes(StandardCharsets.UTF_8);
             DatagramPacket hi = new DatagramPacket(data, data.length, multicastAddress, multicastPort);
             multicastSocket.send(hi);
         } catch (Exception e) {
@@ -273,7 +274,7 @@ private void unicast(String msg, String host) {
             logger.info("Send unicast message: " + msg + " to " + host + ":" + multicastPort);
         }
         try {
-            byte[] data = (msg + "\n").getBytes();
+            byte[] data = (msg + "\n").getBytes(StandardCharsets.UTF_8);
             DatagramPacket hi = new DatagramPacket(data, data.length, InetAddress.getByName(host), multicastPort);
             multicastSocket.send(hi);
         } catch (Exception e) {
diff --git a/dubbo-registry/dubbo-registry-zookeeper/src/main/java/org/apache/dubbo/registry/zookeeper/util/CuratorFrameworkUtils.java b/dubbo-registry/dubbo-registry-zookeeper/src/main/java/org/apache/dubbo/registry/zookeeper/util/CuratorFrameworkUtils.java
@@ -25,6 +25,7 @@
 import org.apache.dubbo.rpc.model.ScopeModelUtil;
 
 import java.lang.reflect.Method;
+import java.nio.charset.StandardCharsets;
 import java.util.Collection;
 import java.util.List;
 import java.util.Map;
@@ -92,7 +93,7 @@ public static CuratorFramework buildCuratorFramework(URL connectionURL, Zookeepe
 
         String userInformation = connectionURL.getUserInformation();
         if (StringUtils.isNotEmpty(userInformation)) {
-            builder = builder.authorization("digest", userInformation.getBytes());
+            builder = builder.authorization("digest", userInformation.getBytes(StandardCharsets.UTF_8));
             builder.aclProvider(new ACLProvider() {
                 @Override
                 public List<ACL> getDefaultAcl() {
diff --git a/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/codec/TelnetCodec.java b/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/codec/TelnetCodec.java
@@ -29,6 +29,7 @@
 import java.io.IOException;
 import java.io.UnsupportedEncodingException;
 import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
 import java.util.Arrays;
 import java.util.LinkedList;
 import java.util.List;
@@ -273,7 +274,7 @@ protected Object decode(Channel channel, ChannelBuffer buffer, int readable, byt
         if (CollectionUtils.isNotEmpty(history) && index != null && index >= 0 && index < history.size()) {
             String value = history.get(index);
             if (value != null) {
-                byte[] b1 = value.getBytes();
+                byte[] b1 = value.getBytes(StandardCharsets.UTF_8);
                 byte[] b2 = new byte[b1.length + message.length];
                 System.arraycopy(b1, 0, b2, 0, b1.length);
                 System.arraycopy(message, 0, b2, b1.length, message.length);
diff --git a/dubbo-remoting/dubbo-remoting-api/src/test/java/org/apache/dubbo/remoting/codec/DeprecatedTelnetCodec.java b/dubbo-remoting/dubbo-remoting-api/src/test/java/org/apache/dubbo/remoting/codec/DeprecatedTelnetCodec.java
@@ -34,6 +34,7 @@
 import java.io.UnsupportedEncodingException;
 import java.net.InetSocketAddress;
 import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
 import java.util.Arrays;
 import java.util.LinkedList;
 import java.util.List;
@@ -310,7 +311,7 @@ protected Object decode(Channel channel, InputStream is, int readable, byte[] me
         if (history != null && history.size() > 0 && index != null && index >= 0 && index < history.size()) {
             String value = history.get(index);
             if (value != null) {
-                byte[] b1 = value.getBytes();
+                byte[] b1 = value.getBytes(StandardCharsets.UTF_8);
                 if (message != null && message.length > 0) {
                     byte[] b2 = new byte[b1.length + message.length];
                     System.arraycopy(b1, 0, b2, 0, b1.length);
diff --git a/dubbo-remoting/dubbo-remoting-zookeeper-curator5/src/main/java/org/apache/dubbo/remoting/zookeeper/curator5/Curator5ZookeeperClient.java b/dubbo-remoting/dubbo-remoting-zookeeper-curator5/src/main/java/org/apache/dubbo/remoting/zookeeper/curator5/Curator5ZookeeperClient.java
@@ -79,7 +79,7 @@ public Curator5ZookeeperClient(URL url) {
                     .sessionTimeoutMs(sessionExpireMs);
             String userInformation = url.getUserInformation();
             if (userInformation != null && userInformation.length() > 0) {
-                builder = builder.authorization("digest", userInformation.getBytes());
+                builder = builder.authorization("digest", userInformation.getBytes(StandardCharsets.UTF_8));
                 builder.aclProvider(new ACLProvider() {
                     @Override
                     public List<ACL> getDefaultAcl() {
diff --git a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java
@@ -53,6 +53,7 @@
 import java.io.IOException;
 import java.lang.reflect.Method;
 import java.lang.reflect.Type;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
@@ -183,7 +184,7 @@ public Result invoke(Invoker<?> invoker, Invocation inv) throws RpcException {
                     // as proto3 only accept one protobuf parameter
                     if (args.length == 1 && args[0] instanceof String) {
                         try (UnsafeByteArrayInputStream is =
-                                new UnsafeByteArrayInputStream(((String) args[0]).getBytes())) {
+                                new UnsafeByteArrayInputStream(((String) args[0]).getBytes(StandardCharsets.UTF_8))) {
                             args[0] = applicationModel
                                     .getExtensionLoader(Serialization.class)
                                     .getExtension(GENERIC_SERIALIZATION_PROTOBUF)

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@`
`24`	`24`	`import java.lang.management.MonitorInfo;`
`25`	`25`	`import java.lang.management.ThreadInfo;`
`26`	`26`	`import java.lang.management.ThreadMXBean;`
	`27`	`+import java.nio.charset.StandardCharsets;`
`27`	`28`
`28`	`29`	`import static java.lang.Thread.State.BLOCKED;`
`29`	`30`	`import static java.lang.Thread.State.TIMED_WAITING;`
`@@ -33,7 +34,7 @@ public class JVMUtil {`
`33`	`34`	`public static void jstack(OutputStream stream) throws Exception {`
`34`	`35`	`ThreadMXBean threadMxBean = ManagementFactory.getThreadMXBean();`
`35`	`36`	`for (ThreadInfo threadInfo : threadMxBean.dumpAllThreads(true, true)) {`
`36`		`- stream.write(getThreadDumpString(threadInfo).getBytes());`
	`37`	`+ stream.write(getThreadDumpString(threadInfo).getBytes(StandardCharsets.UTF_8));`
`37`	`38`	`}`
`38`	`39`	`}`
`39`	`40`
Original file line number	Diff line number	Diff line change
`@@ -533,6 +533,7 @@ public String getOutput() {`
`533`	`533`	`}`
`534`	`534`
`535`	`535`	`private static String fixUnicodeOutput(final String message) {`
	`536`	`+ // TODO default charset is not UTF-8 ?`
`536`	`537`	`return new String(message.getBytes(), StandardCharsets.UTF_8);`
`537`	`538`	`}`
`538`	`539`	`}`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ private static String sign(byte[] data, String key) throws RuntimeException {`
`64`	`64`	`} catch (NoSuchAlgorithmException e) {`
`65`	`65`	`throw new RuntimeException("Failed to generate HMAC: no such algorithm exception " + HMAC_SHA256_ALGORITHM);`
`66`	`66`	`}`
`67`		`- SecretKeySpec signingKey = new SecretKeySpec(key.getBytes(), HMAC_SHA256_ALGORITHM);`
	`67`	`+ SecretKeySpec signingKey = new SecretKeySpec(key.getBytes(StandardCharsets.UTF_8), HMAC_SHA256_ALGORITHM);`
`68`	`68`	`try {`
`69`	`69`	`mac.init(signingKey);`
`70`	`70`	`} catch (InvalidKeyException e) {`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@`
`22`	`22`	`import org.apache.dubbo.common.utils.ClassUtils;`
`23`	`23`	`import org.apache.dubbo.common.utils.StringUtils;`
`24`	`24`
	`25`	`+import java.nio.charset.StandardCharsets;`
`25`	`26`	`import java.util.ArrayList;`
`26`	`27`	`import java.util.List;`
`27`	`28`	`import java.util.function.Consumer;`
`@@ -64,7 +65,7 @@ public <T> T deserialize(String content, Class<T> clazz) {`
`64`	`65`	`if (StringUtils.isBlank(content)) {`
`65`	`66`	`return null;`
`66`	`67`	`}`
`67`		`- return deserialize(content.getBytes(), clazz);`
	`68`	`+ return deserialize(content.getBytes(StandardCharsets.UTF_8), clazz);`
`68`	`69`	`}`
`69`	`70`
`70`	`71`	`public String serialize(Object object) {`