Fixed hanging test cases when failed to download ZK image that due to timeout or other problems (#15693)

* Close CuratorFramework before throwing IllegalStateException to avoid re-connecting ZK infinitely

* Check whether WatchDog is used or not to avoid hanging at destroyProcess

Author: zrlw

dubbo-remoting/dubbo-remoting-zookeeper-curator5/src/main/java/org/apache/dubbo/remoting/zookeeper/curator5/Curator5ZookeeperClient.java

@@ -98,6 +98,8 @@ public List<ACL> getAclForPath(String path) {
             boolean connected = client.blockUntilConnected(timeout, TimeUnit.MILLISECONDS);
 
             if (!connected) {
+                // close CuratorFramework to stop re-connection.
+                client.close();
                 IllegalStateException illegalStateException =
                         new IllegalStateException("zookeeper not connected, the address is: " + url);
 

dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/context/ZookeeperWindowsContext.java

@@ -49,6 +49,11 @@ public class ZookeeperWindowsContext extends ZookeeperContext {
      */
     private final ExecuteWatchdog WATCHDOG = new ExecuteWatchdog(ExecuteWatchdog.INFINITE_TIMEOUT);
 
+    /**
+     * Set it to TRUE when using WatchDog.
+     */
+    private boolean usedWatchDog = false;
+
     /**
      * The map to store the pair of clientPort and PID.
      */
@@ -93,6 +98,7 @@ public ExecutorService getExecutorService() {
      * Returns the {@link ExecuteWatchdog}.
      */
     public ExecuteWatchdog getWatchdog() {
+        usedWatchDog = true;
         return WATCHDOG;
     }
 
@@ -101,7 +107,10 @@ public ExecuteWatchdog getWatchdog() {
      */
     public void destroy() {
         this.processIds.clear();
-        this.WATCHDOG.destroyProcess();
+        // check WatchDog used flag to avoid hanging at destroyProcess when WatchDog is not used.
+        if (usedWatchDog) {
+            this.WATCHDOG.destroyProcess();
+        }
         try {
             DEFAULT_EXECUTOR_SERVICE.shutdownNow();
         } catch (SecurityException | NullPointerException ex) {

dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/processor/ResetZookeeperProcessor.java

@@ -45,6 +45,8 @@ public void process(Context context) throws DubboTestException {
                 client.start();
                 boolean connected = client.blockUntilConnected(1000, TimeUnit.MILLISECONDS);
                 if (!connected) {
+                    // close CuratorFramework to stop re-connection.
+                    client.close();
                     throw new IllegalStateException("zookeeper not connected");
                 }
                 client.delete().deletingChildrenIfNeeded().forPath("/dubbo");