Sem-Ver: bugfix Fix some issues that flake8 detected.

Signed-off-by: David Black <dblack@atlassian.com>

Author: dbaxa

atlassian_jwt_auth/frameworks/django/tests/test_django.py

@@ -318,7 +318,6 @@ def test_request_subject_does_need_to_match_issuer_override_settings(self):
         )
         with override_settings(**dict(
                 self.test_settings, ASAP_SUBJECT_SHOULD_MATCH_ISSUER=False)):
-            message = 'Issuer does not match the subject'
             response = self.client.get(
                 reverse('subject_does_need_to_match_issuer'),
                 HTTP_AUTHORIZATION=b'Bearer ' + token)

atlassian_jwt_auth/frameworks/wsgi/tests/test_wsgi.py

@@ -61,7 +61,7 @@ def test_request_with_valid_token_is_allowed(self):
         self.assertEqual(resp_info['status'], '200 OK')
         self.assertIn('ATL_ASAP_CLAIMS', environ)
 
-    def test_request_with_duplicate_jti_is_accepted_as_per_setting(self):
+    def test_request_with_duplicate_jti_is_rejected_as_per_setting(self):
         self.config['ASAP_CHECK_JTI_UNIQUENESS'] = True
         token = create_token(
             'client-app', 'server-app',

atlassian_jwt_auth/signer.py

@@ -114,10 +114,10 @@ def can_reuse_token(self, existing_token, claims):
             return False
         if set(claims.keys()) != set(existing_claims.keys()):
             return False
-        for key, val in claims.items():
-            if key in ['exp', 'iat', 'jti', 'nbf']:
+        for dict_key, val in claims.items():
+            if dict_key in ['exp', 'iat', 'jti', 'nbf']:
                 continue
-            if existing_claims[key] != val:
+            if existing_claims[dict_key] != val:
                 return False
         return True
 

atlassian_jwt_auth/tests/test_key.py

@@ -9,7 +9,7 @@ class TestKeyModule(unittest.TestCase):
 
     def test_key_identifier_with_invalid_keys(self):
         """ test that invalid key identifiers are not permitted. """
-        keys = ['../aha', '/a', '\c:a', 'lk2j34/#$', 'a../../a', 'a/;a',
+        keys = ['../aha', '/a', r'\c:a', 'lk2j34/#$', 'a../../a', 'a/;a',
                 ' ', ' / ', ' /',
                 u'dir/some\0thing', 'a/#a', 'a/a?x', 'a/a;',
                 ]

atlassian_jwt_auth/tests/test_public_key_provider.py

@@ -30,20 +30,20 @@ def test_https_public_key_retriever_does_not_support_http_url(self):
             base urls.
         """
         with self.assertRaises(ValueError):
-            retriever = self.create_retriever('http://example.com')
+            self.create_retriever('http://example.com')
 
     def test_https_public_key_retriever_does_not_support_none_url(self):
         """ tests that HTTPSPublicKeyRetriever does not support None
             base urls.
         """
         with self.assertRaises(ValueError):
-            retriever = self.create_retriever(None)
+            self.create_retriever(None)
 
     def test_https_public_key_retriever_supports_https_url(self):
         """ tests that HTTPSPublicKeyRetriever supports https://
             base urls.
         """
-        retriever = self.create_retriever(self.base_url)
+        self.create_retriever(self.base_url)
 
     @mock.patch.object(requests.Session, 'get')
     def test_retrieve(self, mock_get_method):