Merge pull request #70 from atom-community/typescript-project-based [skip ci]

Author: aminya

package.json

@@ -37,6 +37,7 @@
     "eslint-plugin-optimize-regex": "^1.2.1",
     "eslint-plugin-react": "^7.32.2",
     "eslint-plugin-yaml": "^0.5.0",
+    "fast-glob": "^3.2.12",
     "prettier": "2.8.8",
     "read-pkg-up": "^7.0.1",
     "semver": "^7.5.1",

pnpm-lock.yaml

@@ -1,6 +1,17 @@
 const { eslintRulesExtra } = require("./official-eslint-rules")
 const { pluginImportRulesExtra, pluginImportTypeScriptRulesExtra } = require("./plugin-import-rules")
 const { pluginNodeRules } = require("./plugin-node-rules")
+const glob = require("fast-glob")
+
+const project = ["./**/tsconfig.json", "!./**/node_modules/**/tsconfig.json"]
+
+const projectedBasedRules = glob.sync(project, { onlyFiles: true, suppressErrors: true }).length !== 0
+if (!projectedBasedRules) {
+  console.warn(
+    "\x1b[33m%s\x1b[0m",
+    "No tsconfig.json found, disabling the project-based rules. To enable them, include all the **/*.ts(x)? files in the includes of the tsconfig.json files and run eslint again."
+  )
+}
 
 const pluginTypeScriptRulesExtra = {
   "@typescript-eslint/no-unused-vars": [
@@ -23,32 +34,37 @@ const pluginTypeScriptRulesExtra = {
   "@typescript-eslint/no-shadow": "error",
   "@typescript-eslint/no-dynamic-delete": "error",
   "@typescript-eslint/no-extraneous-class": "error",
-  "@typescript-eslint/no-floating-promises": "error",
   "@typescript-eslint/no-parameter-properties": "error",
-  "@typescript-eslint/no-unnecessary-boolean-literal-compare": "error",
-  "@typescript-eslint/no-unnecessary-condition": "error",
-  "@typescript-eslint/no-unnecessary-qualifier": "error",
   // "@typescript-eslint/no-unnecessary-type-arguments": "error",
   "@typescript-eslint/no-unnecessary-type-constraint": "error",
-  "@typescript-eslint/no-unsafe-argument": "error",
   // "@typescript-eslint/prefer-function-type": "error",
-  "@typescript-eslint/prefer-includes": "error",
   // "@typescript-eslint/prefer-literal-enum-member": "error",
-  "@typescript-eslint/prefer-nullish-coalescing": "error",
   "@typescript-eslint/prefer-optional-chain": "error",
-  "@typescript-eslint/prefer-reduce-type-parameter": "error",
   // "@typescript-eslint/prefer-string-starts-ends-with": "error",
-  "@typescript-eslint/require-array-sort-compare": "error",
-  "@typescript-eslint/strict-boolean-expressions": "error",
-  "@typescript-eslint/switch-exhaustiveness-check": "warn",
 }
 
+const pluginTypeScriptProjectRules = projectedBasedRules
+  ? {
+      "@typescript-eslint/no-floating-promises": "error",
+      "@typescript-eslint/no-unnecessary-boolean-literal-compare": "error",
+      "@typescript-eslint/no-unnecessary-condition": "error",
+      "@typescript-eslint/no-unnecessary-qualifier": "error",
+      "@typescript-eslint/no-unsafe-argument": "error",
+      "@typescript-eslint/prefer-includes": "error",
+      "@typescript-eslint/prefer-nullish-coalescing": "error",
+      "@typescript-eslint/prefer-reduce-type-parameter": "error",
+      "@typescript-eslint/require-array-sort-compare": "error",
+      "@typescript-eslint/strict-boolean-expressions": "error",
+      "@typescript-eslint/switch-exhaustiveness-check": "warn",
+    }
+  : {}
+
 exports.tsConfig = {
   // TypeScript files
-  files: ["**/*.ts", "**/*.tsx"],
+  files: ["**/*.tsx", "**/*.ts"],
   parser: "@typescript-eslint/parser",
   parserOptions: {
-    project: ["./**/tsconfig.json", "!./**/node_modules/**/tsconfig.json"],
+    project,
     createDefaultProgram: true, // otherwise Eslint will error if a ts file is not covered by one of the tsconfig.json files
   },
   plugins: ["@typescript-eslint", "node", "import", "only-warn"],
@@ -63,6 +79,7 @@ exports.tsConfig = {
   rules: {
     ...eslintRulesExtra,
     ...pluginTypeScriptRulesExtra,
+    ...pluginTypeScriptProjectRules,
     ...pluginNodeRules,
     ...pluginImportRulesExtra,
     ...pluginImportTypeScriptRulesExtra,