chore: failover errors fix (#405)

Author: joyc-bq

common/lib/plugins/failover/failover_plugin.ts

@@ -383,7 +383,7 @@ export class FailoverPlugin extends AbstractConnectionPlugin {
     } else {
       // "The active SQL connection has changed due to a connection failure. Please re-configure
       // session state if required."
-      throw new FailoverSuccessError(Messages.get("Failover.connectionChangedError"));
+      throw new FailoverSuccessError();
     }
   }
 

common/lib/plugins/failover2/failover2_plugin.ts

@@ -242,7 +242,7 @@ export class Failover2Plugin extends AbstractConnectionPlugin implements CanRele
     } else {
       // "The active SQL connection has changed due to a connection failure. Please re-configure
       // session state if required."
-      throw new FailoverSuccessError(Messages.get("Failover.connectionChangedError"));
+      throw new FailoverSuccessError();
     }
   }
 

common/lib/utils/errors.ts

@@ -14,6 +14,8 @@
   limitations under the License.
 */
 
+import { Messages } from "./messages";
+
 export class AwsWrapperError extends Error {
   constructor(message?: string, cause?: any) {
     super(message);
@@ -30,7 +32,11 @@ export class IllegalArgumentError extends AwsWrapperError {}
 
 export class FailoverError extends AwsWrapperError {}
 
-export class FailoverSuccessError extends FailoverError {}
+export class FailoverSuccessError extends FailoverError {
+  constructor(message?: string, cause?: any) {
+    super(Messages.get("Failover.connectionChangedError"));
+  }
+}
 
 export class FailoverFailedError extends FailoverError {}
 

common/lib/utils/locales/en.json

@@ -136,8 +136,8 @@
   "MonitorImpl.stopped": "Stopped monitoring for host '%s'.",
   "MonitorImpl.startMonitoring": "Start monitoring for %s.",
   "MonitorImpl.stopMonitoring": "Stop monitoring for %s.",
-  "MonitorImpl.startMonitoringTaskNewContext": "Start monitoring thread for checking new contexts for '%s'",
-  "MonitorImpl.stopMonitoringTaskNewContext": "Stop monitoring thread for checking new contexts for '%s'",
+  "MonitorImpl.startMonitoringTaskNewContext": "Start monitoring task for checking new contexts for '%s'",
+  "MonitorImpl.stopMonitoringTaskNewContext": "Stop monitoring task for checking new contexts for '%s'",
   "MonitorService.startMonitoringNullMonitor": "Start monitoring called but could not find monitor for host: '%s'.",
   "MonitorService.emptyAliasSet": "Empty alias set passed for '%s'. Set should not be empty.",
   "PluginService.hostListEmpty": "Current host list is empty.",
@@ -220,7 +220,7 @@
   "ClusterTopologyMonitor.errorFetchingTopology": "Error fetching topology: '%s'.",
   "ClusterTopologyMonitoring.ignoringNewTopologyRequest": "Previous failover has just completed, ignoring new topology request.",
   "ClusterTopologyMonitoring.timeoutSetToZero": "A topology refresh was requested, but the given timeout for the request was 0 ms. Returning cached hosts: ",
-  "ClusterTopologyMonitor.startingHostMonitors": "Starting host monitoring threads.",
+  "ClusterTopologyMonitor.startingHostMonitors": "Starting host monitoring tasks.",
   "ClusterTopologyMonitor.writerPickedUpFromHostMonitors": "The writer host detected by the node monitors was picked up by the topology monitor: '%s'.",
   "ClusterTopologyMonitor.writerMonitoringConnection": "The monitoring connection is connected to a writer: '%s'.",
   "ClusterTopologyMonitor.invalidWriterQuery": "An error occurred while attempting to obtain the writer id because the query was invalid. Please ensure you are connecting to an Aurora or RDS DB cluster. Error: '%s'",