Sort tags from REST API in case of inconsistencies

axelrindle · axelrindle · commit bd8002d3526b · 2022-12-20T12:45:10.000+01:00
diff --git a/packages/core/src/query/rest.ts b/packages/core/src/query/rest.ts
@@ -54,7 +54,12 @@ const rest: CheckFunction = async function(options: CheckOptions): Promise<Check
     }
 
     if (options.fetchTags) {
-        result.update = tag(compareTags(options, response.data))
+        // sort tags using semver.compare
+        // in case the tag names are inconsistent (e.g. 1.0.0 => 2.0.0 => v3.0.0)
+        const responseData = (response.data as Array<RestResponseTag>)
+            .sort((a, b) => semver.compare(a.name, b.name))
+            .reverse()
+        result.update = tag(compareTags(options, responseData))
     }
     else {
         result.update = release(compareReleases(options, response.data))

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,12 @@ const rest: CheckFunction = async function(options: CheckOptions): Promise<Check`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`if (options.fetchTags) {`
`57`		`- result.update = tag(compareTags(options, response.data))`
	`57`	`+ // sort tags using semver.compare`
	`58`	`+ // in case the tag names are inconsistent (e.g. 1.0.0 => 2.0.0 => v3.0.0)`
	`59`	`+ const responseData = (response.data as Array<RestResponseTag>)`
	`60`	`+ .sort((a, b) => semver.compare(a.name, b.name))`
	`61`	`+ .reverse()`
	`62`	`+ result.update = tag(compareTags(options, responseData))`
`58`	`63`	`}`
`59`	`64`	`else {`
`60`	`65`	`result.update = release(compareReleases(options, response.data))`