fix: log when render cycle happens after dispose is called

Author: egil

src/bunit.core/Rendering/TestRenderer.cs

@@ -168,7 +168,10 @@ public void DisposeComponents()
 	protected override void ProcessPendingRender()
 	{
 		if (disposed)
+		{
+			logger.LogRenderCycleActiveAfterDispose();
 			return;
+		}
 
 		// Blocks updates to the renderers internal render tree
 		// while the render tree is being read elsewhere.
@@ -184,7 +187,10 @@ protected override void ProcessPendingRender()
 	protected override Task UpdateDisplayAsync(in RenderBatch renderBatch)
 	{
 		if (disposed)
+		{
+			logger.LogRenderCycleActiveAfterDispose();
 			return Task.CompletedTask;
+		}
 
 		if (usersSyncContext is not null && usersSyncContext != SynchronizationContext.Current)
 		{
@@ -220,6 +226,12 @@ private void UpdateDisplay(in RenderBatch renderBatch)
 		RenderCount++;
 		var renderEvent = new RenderEvent(renderBatch, new RenderTreeFrameDictionary());
 
+		if (disposed)
+		{
+			logger.LogRenderCycleActiveAfterDispose();
+			return;
+		}
+
 		// removes disposed components
 		for (var i = 0; i < renderBatch.DisposedComponentIDs.Count; i++)
 		{

src/bunit.core/Rendering/TestRendererLoggerExtensions.cs

@@ -28,27 +28,78 @@ internal static class TestRendererLoggerExtensions
 	private static readonly Action<ILogger, string, string, Exception> UnhandledException
 		= LoggerMessage.Define<string, string>(LogLevel.Error, new EventId(30, "LogUnhandledException"), "An unhandled exception happened during rendering: {Message}" + Environment.NewLine + "{StackTrace}");
 
+	private static readonly Action<ILogger, Exception?> RenderCycleActiveAfterDispose
+		= LoggerMessage.Define(LogLevel.Warning, new EventId(31, "LogRenderCycleActiveAfterDispose"), "A component attempted to update the render tree after the renderer was disposed.");
+
 	internal static void LogProcessingPendingRenders(this ILogger<TestRenderer> logger)
-		=> ProcessingPendingRenders(logger, null);
+	{
+		if (logger.IsEnabled(LogLevel.Debug))
+		{
+			ProcessingPendingRenders(logger, null);
+		}
+	}
 
 	internal static void LogNewRenderBatchReceived(this ILogger<TestRenderer> logger)
-		=> NewRenderBatchReceived(logger, null);
+	{
+		if (logger.IsEnabled(LogLevel.Debug))
+		{
+			NewRenderBatchReceived(logger, null);
+		}
+	}
 
 	internal static void LogComponentDisposed(this ILogger<TestRenderer> logger, int componentId)
-		=> ComponentDisposed(logger, componentId, null);
+	{
+		if (logger.IsEnabled(LogLevel.Debug))
+		{
+			ComponentDisposed(logger, componentId, null);
+		}
+	}
 
 	internal static void LogComponentRendered(this ILogger<TestRenderer> logger, int componentId)
-		=> ComponentRendered(logger, componentId, null);
+	{
+		if (logger.IsEnabled(LogLevel.Debug))
+		{
+			ComponentRendered(logger, componentId, null);
+		}
+	}
 
 	internal static void LogChangedComponentsMarkupUpdated(this ILogger<TestRenderer> logger)
-		=> ChangedComponentsMarkupUpdated(logger, null);
+	{
+		if (logger.IsEnabled(LogLevel.Debug))
+		{
+			ChangedComponentsMarkupUpdated(logger, null);
+		}
+	}
 
 	internal static void LogAsyncInitialRender(this ILogger<TestRenderer> logger)
-		=> AsyncInitialRender(logger, null);
+	{
+		if (logger.IsEnabled(LogLevel.Debug))
+		{
+			AsyncInitialRender(logger, null);
+		}
+	}
 
 	internal static void LogInitialRenderCompleted(this ILogger<TestRenderer> logger, int componentId)
-		=> InitialRenderCompleted(logger, componentId, null);
+	{
+		if (logger.IsEnabled(LogLevel.Debug))
+		{
+			InitialRenderCompleted(logger, componentId, null);
+		}
+	}
 
 	internal static void LogUnhandledException(this ILogger<TestRenderer> logger, Exception exception)
-		=> UnhandledException(logger, exception.Message, exception.StackTrace ?? string.Empty, exception);
+	{
+		if (logger.IsEnabled(LogLevel.Error))
+		{
+			UnhandledException(logger, exception.Message, exception.StackTrace ?? string.Empty, exception);
+		}
+	}
+
+	internal static void LogRenderCycleActiveAfterDispose(this ILogger<TestRenderer> logger)
+	{
+		if (logger.IsEnabled(LogLevel.Warning))
+		{
+			RenderCycleActiveAfterDispose(logger, null);
+		}
+	}
 }