Re-enabled FxCop analyzers and fixed all warnings

Author: egil

src/Directory.Build.props

@@ -7,7 +7,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.0.0">
+    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.0.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>

src/bunit.core.tests/GlobalSuppressions.cs

@@ -6,3 +6,4 @@
 using System.Diagnostics.CodeAnalysis;
 
 [assembly: SuppressMessage("Usage", "BL0006:Do not use RenderTree types")]
+[assembly: SuppressMessage("Reliability", "CA2007:Consider calling ConfigureAwait on the awaited task", Justification = "not in tests")]

src/bunit.core.tests/Rendering/TestRendererTest.cs

@@ -22,7 +22,7 @@ public class TestRendererTest
 		public async Task Test001()
 		{
 			// Arrange
-			var sut = new TestRenderer(ServiceProvider, NullLoggerFactory.Instance);
+			using var sut = new TestRenderer(ServiceProvider, NullLoggerFactory.Instance);
 			var handler = new MockRenderEventHandler(completeHandleTaskSynchronously: true);
 			sut.AddRenderEventHandler(handler);
 
@@ -42,7 +42,7 @@ public async Task Test001()
 		[Fact(DisplayName = "Multiple handlers can be added to the Renderer")]
 		public void Test002()
 		{
-			var sut = new TestRenderer(ServiceProvider, NullLoggerFactory.Instance);
+			using var sut = new TestRenderer(ServiceProvider, NullLoggerFactory.Instance);
 			var handler1 = new MockRenderEventHandler(completeHandleTaskSynchronously: true);
 			var handler2 = new MockRenderEventHandler(completeHandleTaskSynchronously: true);
 
@@ -57,7 +57,7 @@ public void Test002()
 		[Fact(DisplayName = "Handler is not invoked if removed from Renderer")]
 		public void Test003()
 		{
-			var sut = new TestRenderer(ServiceProvider, NullLoggerFactory.Instance);
+			using var sut = new TestRenderer(ServiceProvider, NullLoggerFactory.Instance);
 			var handler1 = new MockRenderEventHandler(completeHandleTaskSynchronously: true);
 			var handler2 = new MockRenderEventHandler(completeHandleTaskSynchronously: true);
 			sut.AddRenderEventHandler(handler1);

src/bunit.core/ComponentParameterBuilder.cs

@@ -214,6 +214,9 @@ public ComponentParameterBuilder<TComponent> Add<TValue>(Expression<Func<TCompon
 		/// <returns>A <see cref="ComponentParameterBuilder{TComponent}"/> which can be chained</returns>
 		public ComponentParameterBuilder<TComponent> Add<TChildComponent>(Expression<Func<TComponent, RenderFragment?>> parameterSelector, Action<ComponentParameterBuilder<TChildComponent>>? childParameterBuilder = null) where TChildComponent : class, IComponent
 		{
+			if (parameterSelector is null)
+				throw new ArgumentNullException(nameof(parameterSelector));
+
 			var (name, isCascading) = GetDetailsFromExpression(parameterSelector);
 
 			RenderFragment childContentFragment;

src/bunit.core/Extensions/WaitForHelpers/WaitForHelper.cs

@@ -47,10 +47,10 @@ public abstract class WaitForHelper : IDisposable
 		/// </summary>
 		protected WaitForHelper(IRenderedFragmentBase renderedFragment, Func<bool> completeChecker, TimeSpan? timeout = null)
 		{
+			_renderedFragment = renderedFragment ?? throw new ArgumentNullException(nameof(renderedFragment));
+			_completeChecker = completeChecker ?? throw new ArgumentNullException(nameof(completeChecker));
 			_logger = renderedFragment.Services.CreateLogger<WaitForHelper>();
 			_completionSouce = new TaskCompletionSource<object?>();
-			_renderedFragment = renderedFragment;
-			_completeChecker = completeChecker;
 			_timer = new Timer(OnTimeout, this, Timeout.InfiniteTimeSpan, Timeout.InfiniteTimeSpan);
 
 			_renderedFragment.OnAfterRender += OnAfterRender;

src/bunit.core/GlobalSuppressions.cs

@@ -6,3 +6,8 @@
 using System.Diagnostics.CodeAnalysis;
 
 [assembly: SuppressMessage("Usage", "BL0006:Do not use RenderTree types")]
+[assembly: SuppressMessage("Design", "CA1063:Implement IDisposable Correctly")]
+[assembly: SuppressMessage("Design", "CA1031:Do not catch general exception types")]
+[assembly: SuppressMessage("Globalization", "CA1303:Do not pass literals as localized parameters")]
+[assembly: SuppressMessage("Usage", "CA1816:Dispose methods should call SuppressFinalize")]
+[assembly: SuppressMessage("Design", "CA1032:Implement standard exception constructors")]

src/bunit.core/RazorTesting/FixtureBase.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Threading.Tasks;
 
 using Microsoft.AspNetCore.Components;
@@ -22,13 +23,13 @@ public abstract class FixtureBase<TFixture> : RazorTestBase
 		/// Gets or sets the setup action to perform before the <see cref="Test"/> action,
 		/// <see cref="TestAsync"/> action and <see cref="Tests"/> and <see cref="TestsAsync"/> actions are invoked.
 		/// </summary>
-		[Parameter] public Action<TFixture>? Setup { private get; set; }
+		[Parameter] public Action<TFixture>? Setup { get; set; }
 
 		/// <summary>
 		/// Gets or sets the asynchronous setup action to perform before the <see cref="Test"/> action,
 		/// <see cref="TestAsync"/> action and <see cref="Tests"/> and <see cref="TestsAsync"/> actions are invoked.
 		/// </summary>
-		[Parameter] public Func<TFixture, Task>? SetupAsync { private get; set; }
+		[Parameter] public Func<TFixture, Task>? SetupAsync { get; set; }
 
 		/// <summary>
 		/// Gets or sets the first test action to invoke, after the <see cref="Setup"/> action has
@@ -37,7 +38,7 @@ public abstract class FixtureBase<TFixture> : RazorTestBase
 		/// Use this to assert against the <see cref="ComponentUnderTest"/> and <see cref="Fragment"/>'s
 		/// defined in the fixture.
 		/// </summary>
-		[Parameter] public Action<TFixture>? Test { private get; set; }
+		[Parameter] public Action<TFixture>? Test { get; set; }
 
 		/// <summary>
 		/// Gets or sets the first test action to invoke, after the <see cref="SetupAsync"/> action has
@@ -46,7 +47,7 @@ public abstract class FixtureBase<TFixture> : RazorTestBase
 		/// Use this to assert against the <see cref="ComponentUnderTest"/> and <see cref="Fragment"/>'s
 		/// defined in the fixture.
 		/// </summary>
-		[Parameter] public Func<TFixture, Task>? TestAsync { private get; set; }
+		[Parameter] public Func<TFixture, Task>? TestAsync { get; set; }
 
 		/// <summary>
 		/// Gets or sets the test actions to invoke, one at the time, in the order they are placed 
@@ -56,7 +57,7 @@ public abstract class FixtureBase<TFixture> : RazorTestBase
 		/// Use this to assert against the <see cref="ComponentUnderTest"/> and <see cref="Fragment"/>'s
 		/// defined in the fixture.
 		/// </summary>
-		[Parameter] public IReadOnlyCollection<Action<TFixture>>? Tests { private get; set; }
+		[Parameter] public IReadOnlyCollection<Action<TFixture>>? Tests { get; set; }
 
 		/// <summary>
 		/// Gets or sets the test actions to invoke, one at the time, in the order they are placed 
@@ -66,7 +67,8 @@ public abstract class FixtureBase<TFixture> : RazorTestBase
 		/// Use this to assert against the <see cref="ComponentUnderTest"/> and <see cref="Fragment"/>'s
 		/// defined in the fixture.
 		/// </summary>
-		[Parameter] public IReadOnlyCollection<Func<TFixture, Task>>? TestsAsync { private get; set; }
+		[Parameter]
+		public IReadOnlyCollection<Func<TFixture, Task>>? TestsAsync { get; set; }
 
 		/// <inheritdoc/>
 		public override Task SetParametersAsync(ParameterView parameters)

src/bunit.core/RazorTesting/RazorTestBase.cs

@@ -80,6 +80,8 @@ void IComponent.Attach(RenderHandle renderHandle) { }
 		/// </summary>
 		protected void TryRun<T>(Action<T> action, T input)
 		{
+			if (action is null)
+				throw new ArgumentNullException(nameof(action));
 			try
 			{
 				action(input);
@@ -95,6 +97,8 @@ protected void TryRun<T>(Action<T> action, T input)
 		/// </summary>
 		protected async Task TryRunAsync<T>(Func<T, Task> action, T input)
 		{
+			if (action is null)
+				throw new ArgumentNullException(nameof(action));
 			try
 			{
 				await action(input).ConfigureAwait(false);

src/bunit.core/Rendering/TestRenderer.cs

@@ -17,10 +17,9 @@ namespace Bunit.Rendering
 	/// </summary>
 	public class TestRenderer : Renderer, ITestRenderer, IRenderEventProducer
 	{
-		private static readonly Type CascadingValueType = typeof(CascadingValue<>);
 		private readonly ILogger _logger;
+		private readonly List<IRenderEventHandler> _renderEventHandlers = new List<IRenderEventHandler>();
 		private Exception? _unhandledException;
-		private List<IRenderEventHandler> _renderEventHandlers = new List<IRenderEventHandler>();
 
 		/// <inheritdoc/>
 		public override Dispatcher Dispatcher { get; } = Dispatcher.CreateDefault();
@@ -109,7 +108,7 @@ public int RenderFragment(RenderFragment renderFragment)
 					{
 						_logger.LogDebug(new EventId(12, nameof(DispatchEventAsync)), $"Finished trigger asynchronously for '{fieldInfo.FieldValue}'");
 					}
-				}, TaskContinuationOptions.OnlyOnRanToCompletion);
+				}, TaskScheduler.Default);
 			}
 
 			return result;

src/bunit.testassets/BlazorE2E/RenderFragmentToggler.razor

@@ -15,13 +15,6 @@
 
     static RenderFragment ExampleFragment = builder =>
     {
-        // TODO: Improve syntax
-        // Ideally we'd support inline Razor syntax here and are investigating this
-        // Could be:
-        //    static RenderFragment ExampleFragment()
-        //        => @<p>Some text<div>Child text</div></p>; // spaced over multiple lines, of course
-        // Failing that, we could have an C#-based representation, e.g.,
-        //    new Element.P { "Some text", new Element.Div { "Child text" } }, etc.
         builder.OpenElement(100, "p");
         builder.AddAttribute(101, "name", "fragment-element");
         builder.AddAttribute(102, "style", "color: red");