Skip to content

Commit 1196085

Browse files
committed
chore: code clean up
1 parent 9dc1934 commit 1196085

14 files changed

Lines changed: 17 additions & 28 deletions

File tree

.editorconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -505,3 +505,4 @@ dotnet_diagnostic.S3459.severity = none # S3459: Unassigned members should be re
505505
dotnet_diagnostic.S3871.severity = none # S3871: Exception types should be "public"
506506
dotnet_diagnostic.S1186.severity = none # S1186: Methods should not be empty
507507
dotnet_diagnostic.S1133.severity = none # S1133: Deprecated code should be removed
508+
dotnet_diagnostic.S3963.severity = none # S3963: "static" fields should be initialized inline (covered by CA1810)

Directory.Build.props

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919
<PropertyGroup Label="Compile settings">
2020
<Nullable>enable</Nullable>
2121
<LangVersion>11.0</LangVersion>
22-
<AccelerateBuildsInVisualStudio>true</AccelerateBuildsInVisualStudio>
22+
<AccelerateBuildsInVisualStudio>false</AccelerateBuildsInVisualStudio>
2323
<ImplicitUsings>enable</ImplicitUsings>
24-
<NoWarn>CA1014,NU5104</NoWarn>
24+
<NoWarn>CA1014,NU5104,NETSDK1138</NoWarn>
2525
<CheckEolTargetFramework>false</CheckEolTargetFramework>
2626

2727
<!-- Used by code coverage -->
@@ -50,7 +50,7 @@
5050
<!-- Shared code analyzers used for all projects in the solution -->
5151
<ItemGroup Label="Code Analyzers">
5252
<PackageReference Include="AsyncFixer" Version="1.6.0" PrivateAssets="All" />
53-
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665" PrivateAssets="All" />
53+
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.63966" PrivateAssets="All" />
5454
</ItemGroup>
5555

5656
<ItemGroup Label="Implicit usings"

src/bunit.core/Extensions/WaitForHelpers/WaitForFailedException.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
using System.ComponentModel;
2-
31
namespace Bunit.Extensions.WaitForHelpers;
42

53
/// <summary>

src/bunit.core/Rendering/RootComponent.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,10 @@ internal sealed class RootComponent : IComponent
1212

1313
public void Attach(RenderHandle renderHandle) => this.renderHandle = renderHandle;
1414

15-
public Task SetParametersAsync(ParameterView parameters) => throw new InvalidOperationException($"{nameof(RootComponent)} shouldn't receive any parameters");
15+
public Task SetParametersAsync(ParameterView parameters)
16+
=> throw new InvalidOperationException($"{nameof(RootComponent)} shouldn't receive any parameters");
1617

1718
public void Render() => renderHandle.Render(renderFragment);
1819

1920
public void Detach() => renderHandle.Render(_ => { });
20-
}
21+
}

src/bunit.core/TestServiceProvider.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using System.Collections;
2-
using Microsoft.Extensions.DependencyInjection;
32

43
namespace Bunit;
54

src/bunit.web/Extensions/TestServiceProviderExtensions.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using Microsoft.AspNetCore.Components.Authorization;
66
using Microsoft.AspNetCore.Components.Routing;
77
using Microsoft.AspNetCore.Components.WebAssembly.Hosting;
8-
using Microsoft.Extensions.Caching.Memory;
98
using Microsoft.Extensions.Localization;
109

1110
namespace Bunit.Extensions;

tests/.editorconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,3 +44,4 @@ dotnet_diagnostic.CA1819.severity = suggestion # CA1819: Properties should not
4444
dotnet_diagnostic.CA1849.severity = suggestion # CA1849: Call async methods when in an async method
4545
dotnet_diagnostic.xUnit1026.severity = none # xUnit1026: Theory methods should use all of their parameters
4646
dotnet_diagnostic.S1144.severity = suggestion # S1144: Unused private types or members should be removed
47+
dotnet_diagnostic.S2094.severity = suggestion # S2094: Classes should not be empty

tests/AngleSharpWrappers.Tests/ElementWrapperTest.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,3 @@
1-
using System.Collections.Generic;
2-
using System.Data.Common;
3-
using System.Linq;
4-
using System.Text;
5-
using System.Threading;
6-
using System.Threading.Tasks;
71
using AngleSharp.Dom;
82
using Shouldly;
93
using Xunit;

tests/AngleSharpWrappers.Tests/HtmlParser.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
using System;
2-
using AngleSharp;
1+
using AngleSharp;
32
using AngleSharp.Dom;
43
using AngleSharp.Html.Parser;
54

tests/AngleSharpWrappers.Tests/TestFactory.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
using System;
2-
using AngleSharp.Dom;
1+
using AngleSharp.Dom;
32

43
namespace AngleSharpWrappers
54
{

0 commit comments

Comments
 (0)