Skip to content

Commit 1745102

Browse files
committed
fix: include packages that support target framework, fix inherited package imports
1 parent d2159cb commit 1745102

4 files changed

Lines changed: 25 additions & 15 deletions

File tree

tests/Directory.Build.props

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,32 @@
1414
<SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
1515
</PropertyGroup>
1616

17-
<ItemGroup Condition="$(MSBuildProjectName) != 'bunit.testassets' and $(MSBuildProjectName) != 'bunit.web.testcomponents.tests'">
17+
<ItemGroup>
1818
<PackageReference Include="AutoFixture" Version="4.18.0" />
1919
<PackageReference Include="AutoFixture.Xunit2" Version="4.18.0" />
2020
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.2" />
2121
<PackageReference Include="Moq" Version="4.18.4" />
2222
<PackageReference Include="Shouldly" Version="4.2.1" />
2323
<PackageReference Include="xunit" Version="2.4.2" />
2424
<PackageReference Include="Xunit.Combinatorial" Version="1.5.25" />
25-
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5" PrivateAssets="All" />
2625
<PackageReference Include="coverlet.msbuild" Version="6.0.0" PrivateAssets="All" />
2726
</ItemGroup>
2827

28+
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.1'">
29+
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
30+
<PrivateAssets>all</PrivateAssets>
31+
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
32+
<NoWarn>NU1701</NoWarn>
33+
</PackageReference>
34+
</ItemGroup>
35+
36+
<ItemGroup Condition="'$(TargetFramework)' != 'netstandard2.1'">
37+
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
38+
<PrivateAssets>all</PrivateAssets>
39+
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
40+
</PackageReference>
41+
</ItemGroup>
42+
2943
<ItemGroup Label="Implicit usings" Condition="$(MSBuildProjectName) != 'bunit.testassets' AND $(MSBuildProjectName) != 'AngleSharpWrappers.Tests'">
3044
<Using Include="AutoFixture" />
3145
<Using Include="AutoFixture.Xunit2" />

tests/bunit.testassets/SampleComponents/CustomPasteSample.razor.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ void HandleCustomPaste(CustomPasteEventArgs eventArgs)
1111
}
1212

1313
[EventHandler("oncustompaste", typeof(CustomPasteEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
14+
[SuppressMessage("Naming", "CA1724:Type names should not match namespaces", Justification = "By convention this has to be named EventHandlers")]
1415
public static class EventHandlers
1516
{
1617
// This static class doesn't need to contain any members. It's just a place where we can put

tests/bunit.testassets/bunit.testassets.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,33 +13,33 @@
1313
</PropertyGroup>
1414

1515
<ItemGroup>
16-
<PackageReference Include="xunit.core" Version="2.4.2" />
17-
<PackageReference Include="xunit.assert" Version="2.4.2" />
18-
<PackageReference Include="xunit.abstractions" Version="2.0.3" />
1916
<PackageReference Include="Serilog" Version="2.12.0" />
20-
<PackageReference Include="Serilog.Extensions.Logging" Version="7.0.0" />
2117
</ItemGroup>
2218

2319
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.1'">
2420
<PackageReference Include="Microsoft.Extensions.Localization.Abstractions" Version="$(DotNet3Version)" />
2521
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="3.2.1" />
2622
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.Authentication" Version="3.2.1" />
2723
<PackageReference Include="System.Text.Json" Version="7.0.2" />
24+
<PackageReference Include="Serilog.Extensions.Logging" Version="3.1.0" />
2825
</ItemGroup>
2926
<ItemGroup Condition="'$(TargetFramework)' == 'net5.0'">
3027
<PackageReference Include="Microsoft.Extensions.Localization.Abstractions" Version="$(DotNet5Version)" />
3128
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="$(DotNet5Version)" />
3229
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.Authentication" Version="$(DotNet5Version)" />
30+
<PackageReference Include="Serilog.Extensions.Logging" Version="3.1.0" />
3331
</ItemGroup>
3432
<ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
3533
<PackageReference Include="Microsoft.Extensions.Localization.Abstractions" Version="$(DotNet6Version)" />
3634
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="$(DotNet6Version)" />
3735
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.Authentication" Version="$(DotNet6Version)" />
36+
<PackageReference Include="Serilog.Extensions.Logging" Version="7.0.0" />
3837
</ItemGroup>
3938
<ItemGroup Condition="'$(TargetFramework)' == 'net7.0'">
4039
<PackageReference Include="Microsoft.Extensions.Localization.Abstractions" Version="$(DotNet7Version)" />
4140
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="$(DotNet7Version)" />
4241
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.Authentication" Version="$(DotNet7Version)" />
42+
<PackageReference Include="Serilog.Extensions.Logging" Version="7.0.0" />
4343
</ItemGroup>
4444

4545
</Project>

tests/bunit.web.testcomponents.tests/bunit.web.testcomponents.tests.csproj

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,10 @@
1111
<PackageReference Include="xunit.extensibility.core" Version="2.4.2" />
1212
<PackageReference Include="xunit.extensibility.execution" Version="2.4.2" />
1313
<PackageReference Include="xunit.runner.utility" Version="2.4.2" />
14-
<PackageReference Include="AutoFixture" Version="4.18.0" />
15-
<PackageReference Include="AutoFixture.Xunit2" Version="4.18.0" />
16-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.2" />
17-
<PackageReference Include="Moq" Version="4.18.4" />
18-
<PackageReference Include="Shouldly" Version="4.1.0" /> <!-- some test fails with > 4.1.0 -->
19-
<PackageReference Include="xunit" Version="2.4.2" />
20-
<PackageReference Include="Xunit.Combinatorial" Version="1.5.25" />
21-
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5" PrivateAssets="All" />
22-
<PackageReference Include="coverlet.msbuild" Version="6.0.0" PrivateAssets="All" />
14+
<PackageReference Update="Shouldly" Version="4.1.0">
15+
<!-- some test fails with > 4.1.0 -->
16+
<NoWarn>NU1605</NoWarn>
17+
</PackageReference>
2318
</ItemGroup>
2419

2520
<ItemGroup>

0 commit comments

Comments
 (0)