Skip to content

Commit 4e439e9

Browse files
authored
fix: prevent endless recursion loading render tree frames (#1132)
1 parent 4990e75 commit 4e439e9

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

src/bunit.core/Rendering/TestRenderer.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,11 @@ private void UpdateDisplay(in RenderBatch renderBatch)
279279
{
280280
var id = renderBatch.DisposedComponentIDs.Array[i];
281281

282+
// Add disposed components to the frames collection
283+
// to avoid them being added into the dictionary later during a
284+
// LoadRenderTreeFrames/GetOrLoadRenderTreeFrame call.
285+
renderEvent.Frames.Add(id, default);
286+
282287
logger.LogComponentDisposed(id);
283288

284289
if (renderedComponents.TryGetValue(id, out var rc))
@@ -443,7 +448,8 @@ private void LoadRenderTreeFrames(int componentId, RenderTreeFrameDictionary fra
443448
for (var i = 0; i < frames.Count; i++)
444449
{
445450
ref var frame = ref frames.Array[i];
446-
if (frame.FrameType == RenderTreeFrameType.Component)
451+
452+
if (frame.FrameType == RenderTreeFrameType.Component && !framesCollection.Contains(frame.ComponentId))
447453
{
448454
LoadRenderTreeFrames(frame.ComponentId, framesCollection);
449455
}

0 commit comments

Comments
 (0)