build(deps): bump SonarAnalyzer.CSharp from 8.41.0.50478 to 8.42.0.51121 (#799)

* build(deps): bump SonarAnalyzer.CSharp from 8.41.0.50478 to 8.42.0.51121

Bumps SonarAnalyzer.CSharp from 8.41.0.50478 to 8.42.0.51121.

---
updated-dependencies:
- dependency-name: SonarAnalyzer.CSharp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: Adopt S1117

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Steven Giesel <stgiesel35@gmail.com>

Author: dependabot[bot]

Directory.Build.props

@@ -49,7 +49,7 @@
 	<ItemGroup Label="Code Analyzers">
 		<PackageReference Include="AsyncFixer" Version="1.6.0" PrivateAssets="All" />
 		<PackageReference Include="Meziantou.Analyzer" Version="1.0.708" PrivateAssets="All" />
-		<PackageReference Include="SonarAnalyzer.CSharp" Version="8.41.0.50478" PrivateAssets="All" />
+		<PackageReference Include="SonarAnalyzer.CSharp" Version="8.42.0.51121" PrivateAssets="All" />
 	</ItemGroup>
 
 	<ItemGroup Label="Implicit usings"

src/bunit.web/Extensions/Internal/ElementFactory.cs

@@ -26,8 +26,8 @@ TElement IElementFactory<TElement>.GetElement()
 		if (element is null)
 		{
 			var queryResult = testTarget.Nodes.QuerySelector(cssSelector);
-			if (queryResult is TElement element)
-				this.element = element;
+			if (queryResult is TElement queryResultElement)
+				element = queryResultElement;
 		}
 
 		return element ?? throw new ElementRemovedFromDomException(cssSelector);

src/bunit.web/TestDoubles/Components/Stub{TComponent}.cs

@@ -25,10 +25,10 @@ public Stub() { }
 	/// <param name="replacement">The replacement template to use when rendering.</param>
 	public Stub(object? replacement)
 	{
-		if (replacement is RenderFragment<CapturedParameterView<TComponent>> replacementTemplate)
-			this.replacementTemplate = replacementTemplate;
-		else if (replacement is RenderFragment replacementFragment)
-			this.replacementFragment = replacementFragment;
+		if (replacement is RenderFragment<CapturedParameterView<TComponent>> replacementRenderTemplate)
+			replacementTemplate = replacementRenderTemplate;
+		else if (replacement is RenderFragment replacementRenderFragment)
+			replacementFragment = replacementRenderFragment;
 		else if (replacement is not null)
 			throw new ArgumentException($"The type of replacement is not supported. Replacement type = {replacement.GetType()}", nameof(replacement));
 	}