Upgraded fxcop for tests

Author: egil

tests/Directory.Build.props

@@ -34,6 +34,6 @@
 		<PackageReference Include="xunit" Version="2.4.1" />
 		<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3" PrivateAssets="All" />
 		<PackageReference Include="coverlet.msbuild" Version="2.9.0" PrivateAssets="All" />
-		<PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.0" PrivateAssets="All" />
+		<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.0" PrivateAssets="All" />
 	</ItemGroup>
 </Project>

tests/bunit.core.tests/ComponentParameterCollectionBuilderTests.cs

@@ -8,7 +8,7 @@
 
 namespace Bunit
 {
-	public class ComponentParameterCollectionBuilderTests
+	public class ComponentParameterCollectionBuilderTests : TestContext
 	{
 		private readonly ComponentParameterCollectionBuilder<Params> Builder = new ComponentParameterCollectionBuilder<Params>();
 
@@ -43,16 +43,14 @@ private async Task VerifyEventCallback(string expectedName)
 			EventCallbackCalled.ShouldBeTrue();
 		}
 
-		private static IRenderedFragment RenderWithRenderFragment(RenderFragment renderFragment)
+		private IRenderedFragment RenderWithRenderFragment(RenderFragment renderFragment)
 		{
-			var ctx = new TestContext();
-			return (IRenderedFragment)ctx.Renderer.RenderFragment(renderFragment);
+			return (IRenderedFragment)Renderer.RenderFragment(renderFragment);
 		}
 
-		private static IRenderedComponent<TComponent> RenderWithRenderFragment<TComponent>(RenderFragment renderFragment) where TComponent : IComponent
+		private IRenderedComponent<TComponent> RenderWithRenderFragment<TComponent>(RenderFragment renderFragment) where TComponent : IComponent
 		{
-			var ctx = new TestContext();
-			var res = (IRenderedFragment)ctx.Renderer.RenderFragment(renderFragment);
+			var res = (IRenderedFragment)Renderer.RenderFragment(renderFragment);
 			return res.FindComponent<TComponent>();
 		}
 
@@ -389,7 +387,7 @@ public void Test053()
 
 			Builder.Build().ShouldAllBe(VerifyTemplate, VerifyTemplate);
 
-			static void VerifyTemplate(ComponentParameter template)
+			void VerifyTemplate(ComponentParameter template)
 			{
 				var input = "FOO";
 				var rf = template.ShouldBeParameter<RenderFragment<string>>("Template", isCascadingValue: false);

tests/bunit.core.tests/GlobalSuppressions.cs

@@ -15,3 +15,4 @@
 [assembly: SuppressMessage("Usage", "BL0006:Do not use RenderTree types", Justification = "<Pending>")]
 [assembly: SuppressMessage("Naming", "CA1707:Identifiers should not contain underscores")]
 [assembly: SuppressMessage("Performance", "CA1812:Avoid uninstantiated internal classes")]
+[assembly: SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "<Pending>")]

tests/bunit.core.tests/Rendering/TestRendererTest.cs

@@ -12,22 +12,22 @@
 
 namespace Bunit.Rendering
 {
-	public class NoChildNoParams : ComponentBase
+	internal class NoChildNoParams : ComponentBase
 	{
 		public const string MARKUP = "hello world";
 		protected override void BuildRenderTree(RenderTreeBuilder builder)
 			=> builder.AddMarkupContent(0, MARKUP);
 	}
 
-	public class ThrowsDuringSetParams : ComponentBase
+	internal class ThrowsDuringSetParams : ComponentBase
 	{
 		public static readonly InvalidOperationException EXCEPTION =
 			new InvalidOperationException("THROWS ON PURPOSE");
 
 		public override Task SetParametersAsync(ParameterView parameters) => throw EXCEPTION;
 	}
 
-	public class HasParams : ComponentBase
+	internal class HasParams : ComponentBase
 	{
 		[Parameter] public string? Value { get; set; }
 		[Parameter] public RenderFragment? ChildContent { get; set; }
@@ -39,7 +39,7 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
 		}
 	}
 
-	public class RenderTrigger : ComponentBase
+	internal class RenderTrigger : ComponentBase
 	{
 		[Parameter] public string? Value { get; set; }
 
@@ -56,7 +56,7 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
 		}
 	}
 
-	public class ToggleChild : ComponentBase
+	internal class ToggleChild : ComponentBase
 	{
 		private bool _showing = true;