Skip to content

Commit d966bcb

Browse files
committed
Fix spelling in changelog, removed dotnet-format from workflow
1 parent c8a2fd3 commit d966bcb

2 files changed

Lines changed: 1 addition & 41 deletions

File tree

.github/workflows/main.yml

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -117,46 +117,6 @@ jobs:
117117
dotnet restore ${GITHUB_WORKSPACE}/TemplateTest --source ${GITHUB_WORKSPACE}/packages --source https://api.nuget.org/v3/index.json
118118
dotnet test ${GITHUB_WORKSPACE}/TemplateTest
119119
120-
dotnet-format:
121-
if: github.event_name == 'pull_request'
122-
runs-on: ubuntu-latest
123-
steps:
124-
- name: Checkout repository
125-
uses: actions/checkout@v2
126-
127-
- uses: jwalton/gh-find-current-pr@v1
128-
id: findPr
129-
with:
130-
github-token: ${{ secrets.GITHUB_TOKEN }}
131-
132-
- name: Checkout PR
133-
uses: dawidd6/action-checkout-pr@v1
134-
with:
135-
pr: steps.findPr.outputs.number
136-
137-
- uses: actions/setup-dotnet@v1
138-
with:
139-
dotnet-version: '3.1.x'
140-
- uses: actions/setup-dotnet@v1
141-
with:
142-
dotnet-version: '5.0.100-rc.1.20452.10'
143-
144-
- name: Install dotnet-format
145-
run: dotnet tool install -g dotnet-format
146-
147-
- name: Run dotnet-format
148-
run: dotnet format ./bunit.sln --verbosity diag
149-
150-
- name: Commit formatted files
151-
uses: EndBug/add-and-commit@v4.1.0
152-
with:
153-
add: '.'
154-
author_name: Github Actions
155-
author_email: actions@github.com
156-
message: Automated dotnet-format update
157-
env:
158-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
159-
160120
sonarcloud:
161121
if: github.event_name != 'schedule' || github.event_name != 'pull_request'
162122
runs-on: ubuntu-latest

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ List of changes in existing functionality.
1818

1919
- The `ComponentParameterBuilder` has been renamed to `ComponentParameterCollectionBuilder`, since it now builds the `ComponentParameterCollection` type, introduced in this release of bUnit. By [@egil](https://github.com/egil) in [#203](https://github.com/egil/bUnit/pull/203).
2020
- `ComponentParameterCollectionBuilder` now allows adding cascading values that is not directly used by the component type it targets. This makes it possible to add cascading values to children of the target component. By [@egil](https://github.com/egil) in [#203](https://github.com/egil/bUnit/pull/203).
21-
- The `Add(object)` has been replaced by `AddCascadingValue(object)` in `ComponentParameterCollectionBuilder`, to make it more clear that an unnnamed cascading value is being passed to the target component or one of its child components. It it is also possible to pass unnamed cascading values using the `Add(parameterSelector, value)` method, which now correctly detect if the selected cascading value parameter is named or unnamed. By [@egil](https://github.com/egil) in [#203](https://github.com/egil/bUnit/pull/203).
21+
- The `Add(object)` has been replaced by `AddCascadingValue(object)` in `ComponentParameterCollectionBuilder`, to make it more clear that an unnamed cascading value is being passed to the target component or one of its child components. It is also possible to pass unnamed cascading values using the `Add(parameterSelector, value)` method, which now correctly detect if the selected cascading value parameter is named or unnamed. By [@egil](https://github.com/egil) in [#203](https://github.com/egil/bUnit/pull/203).
2222
- It is now possible to call the `Add()`, `AddChildContent()` methods on `ComponentParameterCollectionBuilder`, and the factory methods `RenderFragment()`, `ChildContent()`, and `Template()`, _**multiple times**_ for the same parameter, if it is of type `RenderFragment` or `RenderFragment<TValue>`. Doing so previously would either result in an exception or just the last passed `RenderFragment` to be used. Now all the provided `RenderFragment` or `RenderFragment<TValue>` will be combined at runtime into a single `RenderFragment` or `RenderFragment<TValue>`.
2323

2424
For example, this makes it easier to pass e.g. both a markup string and a component to a `ChildContent` parameter:

0 commit comments

Comments
 (0)