Skip to content

Commit c1a14b6

Browse files
committed
Add eslint config and remove snapshot tests
1 parent e411c75 commit c1a14b6

9 files changed

Lines changed: 50 additions & 744 deletions

File tree

.eslintignore

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
**/node_modules
2+
**/android
3+
**/ios
4+
**/vendors
5+
**/coverage
6+
**/flow-coverage

.eslintrc

Lines changed: 24 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,28 @@
11
{
2-
"extends": "airbnb",
3-
"parser": "babel-eslint",
2+
"extends": [
3+
"react-app",
4+
"prettier",
5+
"prettier/flowtype",
6+
"prettier/react"
7+
],
8+
"plugins": [
9+
"flowtype",
10+
"react",
11+
"prettier"
12+
],
13+
"globals": {
14+
"__DEV__": true
15+
},
416
"rules": {
5-
"react/jsx-filename-extension": [1, { "extensions": [".js", ".jsx"] }],
6-
"import/no-extraneous-dependencies": [0],
7-
"import/no-unresolved": [2, { ignore: ['^react(-native)?$'] }],
8-
"import/extensions": [2, { "js": "never", "json": "always" }]
17+
"no-use-before-define": 0,
18+
"no-unused-vars": "error",
19+
"prettier/prettier": [
20+
"error",
21+
{
22+
"trailingComma": "es5",
23+
"singleQuote": true,
24+
"printWidth": 100
25+
}
26+
]
927
}
1028
}

package.json

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,9 @@
44
"description": "ScrollView with an image in header which become a navbar",
55
"main": "src/index.js",
66
"scripts": {
7-
"jest": "jest",
8-
"jest:watch": "npm run jest -- --watch",
97
"lint": "eslint src/*.js",
10-
"test": "npm run lint && npm run jest"
8+
"test": "npm run lint",
9+
"prettify": "prettier --single-quote --trailing-comma es5 --print-width 100 --write src/**.js"
1110
},
1211
"files": ["README.md", "LICENCE", "src", "readmeAssets"],
1312
"repository": {
@@ -30,7 +29,7 @@
3029
},
3130
"homepage": "https://github.com/bamlab/react-native-image-header-scroll-view#readme",
3231
"devDependencies": {
33-
"babel-jest": "19.0.0",
32+
"babel-eslint": "^7.2.3",
3433
"babel-preset-react-native": "1.9.1",
3534
"eslint": "^3.19.0",
3635
"eslint-config-prettier": "1.7.0",
@@ -47,10 +46,6 @@
4746
"react": ">=15.3.1",
4847
"react-native": ">=0.20.0"
4948
},
50-
"jest": {
51-
"preset": "react-native",
52-
"modulePathIgnorePatterns": ["<rootDir>/exemple/"]
53-
},
5449
"dependencies": {
5550
"lodash": "^4.17.4"
5651
}

src/TriggeringView.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { View, Animated } from 'react-native';
33
import _ from 'lodash';
44

55
class TriggeringView extends Component {
6-
76
constructor(props) {
87
super(props);
98
this.state = {
@@ -73,13 +72,8 @@ class TriggeringView extends Component {
7372
render() {
7473
const viewProps = _.pick(this.props, _.keys(View.propTypes));
7574
return (
76-
<View
77-
ref={this.onRef}
78-
onLayout={this.onLayout}
79-
collapsable={false}
80-
{...viewProps}
81-
>
82-
{ this.props.children }
75+
<View ref={this.onRef} onLayout={this.onLayout} collapsable={false} {...viewProps}>
76+
{this.props.children}
8377
</View>
8478
);
8579
}

src/__tests__/TriggeringView.js

Lines changed: 0 additions & 31 deletions
This file was deleted.

src/__tests__/__snapshots__/TriggeringView.js.snap

Lines changed: 0 additions & 134 deletions
This file was deleted.

src/__tests__/__snapshots__/index.js.snap

Lines changed: 0 additions & 111 deletions
This file was deleted.

src/__tests__/index.js

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)