Skip to content

Commit 2227246

Browse files
authored
feat: add jsx-no-useless-fragment (#69)
* BREAKING CHANGE: add jsx-no-useless-fragment * doc: precise what to do when you add a rule * feat: add a pull request template
1 parent 1a82936 commit 2227246

3 files changed

Lines changed: 6 additions & 0 deletions

File tree

PULL_REQUEST_TEMPLATE.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<!-- If your PR is related to a RFC, please add `Closes #<issue number>` to link the PR to the issue and close it automatically when the PR is merged -->
2+
3+
<!-- We use [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) to automate the release process. Please follow the commit message format described in the link above. Lerna will automatically generate the changelog for each package based on the commit messages since the last version. -->

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ Changes:
5555

5656
It will then push a tagged commit `chore(release): Publish` which will then trigger the Github Workflow to publish the new version of each package to NPM.
5757

58+
> If you add a new rule to a config, this is a breaking change, because it could make the CI fail on projects that use the plugin. The commit name where you add the new rule needs to follow this patern `BREAKING CHANGE : the description of your commit`
59+
5860
## Running commands
5961

6062
- `yarn lerna run start`: run the 'start' script in all packages (currently only present in `example-app`),

packages/eslint-plugin/lib/configs/recommended.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ module.exports = defineConfig({
4040
"react/no-unstable-nested-components": "error",
4141
"react/prop-types": "off",
4242
"react/no-unused-prop-types": "error",
43+
"react/jsx-no-useless-fragment": "error",
4344
"@typescript-eslint/no-unused-vars": "off",
4445
"unused-imports/no-unused-imports": "error",
4546
"unused-imports/no-unused-vars": "error",

0 commit comments

Comments
 (0)