Skip to content

Commit e6c18ad

Browse files
AntoineThibiAntoineThibi
authored
fix: fixes some issues with the package.json and the no-unnecessary-condition rule (#141)
* fix: fix the package.json importing the package * fix: fix the unnecessary condition being twice * fix: fix the peer dep to be sync with the deps
1 parent f2258e2 commit e6c18ad

3 files changed

Lines changed: 53 additions & 62 deletions

File tree

‎packages/eslint-plugin/lib/configs/recommended.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ export const recommendedConfig = tseslint.config(
4141
"react/no-unstable-nested-components": ["error", { allowAsProps: true }], // allowAsProps for Functions as child components
4242
"react/prop-types": "off",
4343
"react/no-unused-prop-types": "error",
44-
"@typescript-eslint/no-unnecessary-condition": "error",
4544
"react/jsx-no-useless-fragment": "error",
4645
"@bam.tech/no-different-displayname": "error",
4746
"@bam.tech/require-named-effect": "error",

‎packages/eslint-plugin/package.json‎

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,10 @@
3030
"eslint": "^9.37.0",
3131
"eslint-config-prettier": "^10.1.8",
3232
"eslint-import-resolver-typescript": "^4.4.4",
33+
"eslint-plugin-eslint-plugin": "^6.4.0",
3334
"eslint-plugin-import": "^2.32.0",
3435
"eslint-plugin-jest": "^29.0.1",
36+
"eslint-plugin-prettier": "^5.2.1",
3537
"eslint-plugin-react": "^7.37.5",
3638
"eslint-plugin-react-hooks": "^7.0.0",
3739
"eslint-plugin-react-native": "^5.0.0",
@@ -45,27 +47,26 @@
4547
"eslint-define-config": "^2.0.0"
4648
},
4749
"devDependencies": {
48-
"@bam.tech/eslint-plugin": "^8.0.0",
4950
"@eslint/compat": "^2.0.0",
5051
"@eslint/js": "^9.17.0",
5152
"@types/eslint": "^9.6.1",
5253
"@typescript-eslint/eslint-plugin": "^8.19.1",
5354
"@typescript-eslint/parser": "^8.0.0",
54-
"eslint": "^9.17.0",
55-
"eslint-config-prettier": "^10.0.1",
55+
"eslint": "^9.37.0",
56+
"eslint-config-prettier": "^10.1.8",
5657
"eslint-doc-generator": "^2.0.2",
57-
"eslint-import-resolver-typescript": "^4.0.0",
58+
"eslint-import-resolver-typescript": "^4.4.4",
5859
"eslint-plugin-eslint-plugin": "^6.4.0",
59-
"eslint-plugin-import": "^2.31.0",
60+
"eslint-plugin-import": "^2.32.0",
6061
"eslint-plugin-jest": "^29.0.1",
6162
"eslint-plugin-prettier": "^5.2.1",
62-
"eslint-plugin-react": "^7.37.4",
63+
"eslint-plugin-react": "^7.37.5",
6364
"eslint-plugin-react-hooks": "^7.0.0",
6465
"eslint-plugin-react-native": "^5.0.0",
6566
"eslint-plugin-react-native-a11y": "^3.5.1",
6667
"eslint-plugin-simple-import-sort": "^12.1.1",
67-
"eslint-plugin-testing-library": "7.1.1",
68-
"eslint-plugin-unused-imports": "^4.1.4",
68+
"eslint-plugin-testing-library": "^7.13.1",
69+
"eslint-plugin-unused-imports": "^4.2.0",
6970
"jest": "^30.0.0",
7071
"npm-run-all2": "^8.0.0",
7172
"prettier": "^3.0.0",

‎yarn.lock‎

Lines changed: 44 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -1669,32 +1669,56 @@ __metadata:
16691669
languageName: node
16701670
linkType: hard
16711671

1672-
"@bam.tech/eslint-plugin@npm:^8.0.0, @bam.tech/eslint-plugin@workspace:packages/eslint-plugin":
1672+
"@bam.tech/eslint-plugin@portal:../packages/eslint-plugin::locator=example-app%40workspace%3Aexample-app":
1673+
version: 0.0.0-use.local
1674+
resolution: "@bam.tech/eslint-plugin@portal:../packages/eslint-plugin::locator=example-app%40workspace%3Aexample-app"
1675+
dependencies:
1676+
eslint-define-config: "npm:^2.0.0"
1677+
peerDependencies:
1678+
"@typescript-eslint/eslint-plugin": ^8.46.0
1679+
eslint: ^9.37.0
1680+
eslint-config-prettier: ^10.1.8
1681+
eslint-import-resolver-typescript: ^4.4.4
1682+
eslint-plugin-eslint-plugin: ^6.4.0
1683+
eslint-plugin-import: ^2.32.0
1684+
eslint-plugin-jest: ^29.0.1
1685+
eslint-plugin-prettier: ^5.2.1
1686+
eslint-plugin-react: ^7.37.5
1687+
eslint-plugin-react-hooks: ^7.0.0
1688+
eslint-plugin-react-native: ^5.0.0
1689+
eslint-plugin-react-native-a11y: ^3.5.1
1690+
eslint-plugin-simple-import-sort: ^12.1.1
1691+
eslint-plugin-testing-library: ^7.13.1
1692+
eslint-plugin-unused-imports: ^4.2.0
1693+
prettier: ^3.6.2
1694+
languageName: node
1695+
linkType: soft
1696+
1697+
"@bam.tech/eslint-plugin@workspace:packages/eslint-plugin":
16731698
version: 0.0.0-use.local
16741699
resolution: "@bam.tech/eslint-plugin@workspace:packages/eslint-plugin"
16751700
dependencies:
1676-
"@bam.tech/eslint-plugin": "npm:^8.0.0"
16771701
"@eslint/compat": "npm:^2.0.0"
16781702
"@eslint/js": "npm:^9.17.0"
16791703
"@types/eslint": "npm:^9.6.1"
16801704
"@typescript-eslint/eslint-plugin": "npm:^8.19.1"
16811705
"@typescript-eslint/parser": "npm:^8.0.0"
1682-
eslint: "npm:^9.17.0"
1683-
eslint-config-prettier: "npm:^10.0.1"
1706+
eslint: "npm:^9.37.0"
1707+
eslint-config-prettier: "npm:^10.1.8"
16841708
eslint-define-config: "npm:^2.0.0"
16851709
eslint-doc-generator: "npm:^2.0.2"
1686-
eslint-import-resolver-typescript: "npm:^4.0.0"
1710+
eslint-import-resolver-typescript: "npm:^4.4.4"
16871711
eslint-plugin-eslint-plugin: "npm:^6.4.0"
1688-
eslint-plugin-import: "npm:^2.31.0"
1712+
eslint-plugin-import: "npm:^2.32.0"
16891713
eslint-plugin-jest: "npm:^29.0.1"
16901714
eslint-plugin-prettier: "npm:^5.2.1"
1691-
eslint-plugin-react: "npm:^7.37.4"
1715+
eslint-plugin-react: "npm:^7.37.5"
16921716
eslint-plugin-react-hooks: "npm:^7.0.0"
16931717
eslint-plugin-react-native: "npm:^5.0.0"
16941718
eslint-plugin-react-native-a11y: "npm:^3.5.1"
16951719
eslint-plugin-simple-import-sort: "npm:^12.1.1"
1696-
eslint-plugin-testing-library: "npm:7.1.1"
1697-
eslint-plugin-unused-imports: "npm:^4.1.4"
1720+
eslint-plugin-testing-library: "npm:^7.13.1"
1721+
eslint-plugin-unused-imports: "npm:^4.2.0"
16981722
jest: "npm:^30.0.0"
16991723
npm-run-all2: "npm:^8.0.0"
17001724
prettier: "npm:^3.0.0"
@@ -1707,8 +1731,10 @@ __metadata:
17071731
eslint: ^9.37.0
17081732
eslint-config-prettier: ^10.1.8
17091733
eslint-import-resolver-typescript: ^4.4.4
1734+
eslint-plugin-eslint-plugin: ^6.4.0
17101735
eslint-plugin-import: ^2.32.0
17111736
eslint-plugin-jest: ^29.0.1
1737+
eslint-plugin-prettier: ^5.2.1
17121738
eslint-plugin-react: ^7.37.5
17131739
eslint-plugin-react-hooks: ^7.0.0
17141740
eslint-plugin-react-native: ^5.0.0
@@ -1720,29 +1746,6 @@ __metadata:
17201746
languageName: unknown
17211747
linkType: soft
17221748

1723-
"@bam.tech/eslint-plugin@portal:../packages/eslint-plugin::locator=example-app%40workspace%3Aexample-app":
1724-
version: 0.0.0-use.local
1725-
resolution: "@bam.tech/eslint-plugin@portal:../packages/eslint-plugin::locator=example-app%40workspace%3Aexample-app"
1726-
dependencies:
1727-
eslint-define-config: "npm:^2.0.0"
1728-
peerDependencies:
1729-
"@typescript-eslint/eslint-plugin": ^8.46.0
1730-
eslint: ^9.37.0
1731-
eslint-config-prettier: ^10.1.8
1732-
eslint-import-resolver-typescript: ^4.4.4
1733-
eslint-plugin-import: ^2.32.0
1734-
eslint-plugin-jest: ^29.0.1
1735-
eslint-plugin-react: ^7.37.5
1736-
eslint-plugin-react-hooks: ^7.0.0
1737-
eslint-plugin-react-native: ^5.0.0
1738-
eslint-plugin-react-native-a11y: ^3.5.1
1739-
eslint-plugin-simple-import-sort: ^12.1.1
1740-
eslint-plugin-testing-library: ^7.13.1
1741-
eslint-plugin-unused-imports: ^4.2.0
1742-
prettier: ^3.6.2
1743-
languageName: node
1744-
linkType: soft
1745-
17461749
"@bam.tech/typescript-config@portal:../packages/typescript-config::locator=example-app%40workspace%3Aexample-app":
17471750
version: 0.0.0-use.local
17481751
resolution: "@bam.tech/typescript-config@portal:../packages/typescript-config::locator=example-app%40workspace%3Aexample-app"
@@ -4635,7 +4638,7 @@ __metadata:
46354638
languageName: node
46364639
linkType: hard
46374640

4638-
"@typescript-eslint/scope-manager@npm:8.53.0, @typescript-eslint/scope-manager@npm:^8.15.0, @typescript-eslint/scope-manager@npm:^8.51.0":
4641+
"@typescript-eslint/scope-manager@npm:8.53.0, @typescript-eslint/scope-manager@npm:^8.51.0":
46394642
version: 8.53.0
46404643
resolution: "@typescript-eslint/scope-manager@npm:8.53.0"
46414644
dependencies:
@@ -4696,7 +4699,7 @@ __metadata:
46964699
languageName: node
46974700
linkType: hard
46984701

4699-
"@typescript-eslint/utils@npm:8.53.0, @typescript-eslint/utils@npm:^8.0.0, @typescript-eslint/utils@npm:^8.15.0, @typescript-eslint/utils@npm:^8.51.0":
4702+
"@typescript-eslint/utils@npm:8.53.0, @typescript-eslint/utils@npm:^8.0.0, @typescript-eslint/utils@npm:^8.51.0":
47004703
version: 8.53.0
47014704
resolution: "@typescript-eslint/utils@npm:8.53.0"
47024705
dependencies:
@@ -7564,7 +7567,7 @@ __metadata:
75647567
languageName: node
75657568
linkType: hard
75667569

7567-
"eslint-config-prettier@npm:^10.0.1":
7570+
"eslint-config-prettier@npm:^10.0.1, eslint-config-prettier@npm:^10.1.8":
75687571
version: 10.1.8
75697572
resolution: "eslint-config-prettier@npm:10.1.8"
75707573
peerDependencies:
@@ -7637,7 +7640,7 @@ __metadata:
76377640
languageName: node
76387641
linkType: hard
76397642

7640-
"eslint-import-resolver-typescript@npm:^4.0.0":
7643+
"eslint-import-resolver-typescript@npm:^4.0.0, eslint-import-resolver-typescript@npm:^4.4.4":
76417644
version: 4.4.4
76427645
resolution: "eslint-import-resolver-typescript@npm:4.4.4"
76437646
dependencies:
@@ -7685,7 +7688,7 @@ __metadata:
76857688
languageName: node
76867689
linkType: hard
76877690

7688-
"eslint-plugin-import@npm:^2.31.0":
7691+
"eslint-plugin-import@npm:^2.31.0, eslint-plugin-import@npm:^2.32.0":
76897692
version: 2.32.0
76907693
resolution: "eslint-plugin-import@npm:2.32.0"
76917694
dependencies:
@@ -7798,7 +7801,7 @@ __metadata:
77987801
languageName: node
77997802
linkType: hard
78007803

7801-
"eslint-plugin-react@npm:^7.37.3, eslint-plugin-react@npm:^7.37.4":
7804+
"eslint-plugin-react@npm:^7.37.3, eslint-plugin-react@npm:^7.37.5":
78027805
version: 7.37.5
78037806
resolution: "eslint-plugin-react@npm:7.37.5"
78047807
dependencies:
@@ -7835,19 +7838,7 @@ __metadata:
78357838
languageName: node
78367839
linkType: hard
78377840

7838-
"eslint-plugin-testing-library@npm:7.1.1":
7839-
version: 7.1.1
7840-
resolution: "eslint-plugin-testing-library@npm:7.1.1"
7841-
dependencies:
7842-
"@typescript-eslint/scope-manager": "npm:^8.15.0"
7843-
"@typescript-eslint/utils": "npm:^8.15.0"
7844-
peerDependencies:
7845-
eslint: ^8.57.0 || ^9.0.0
7846-
checksum: 10c0/648a7dd07ec3f26388eaad89e72ae74441f0e27e337cca7ca10ca55a4ff0437aa6303df5d9f37aeb90aaadd287c536696a7d11f14d1431bb8ae4fabad8c2744e
7847-
languageName: node
7848-
linkType: hard
7849-
7850-
"eslint-plugin-testing-library@npm:^7.1.1":
7841+
"eslint-plugin-testing-library@npm:^7.1.1, eslint-plugin-testing-library@npm:^7.13.1":
78517842
version: 7.15.4
78527843
resolution: "eslint-plugin-testing-library@npm:7.15.4"
78537844
dependencies:
@@ -7859,7 +7850,7 @@ __metadata:
78597850
languageName: node
78607851
linkType: hard
78617852

7862-
"eslint-plugin-unused-imports@npm:^4.1.0, eslint-plugin-unused-imports@npm:^4.1.4":
7853+
"eslint-plugin-unused-imports@npm:^4.1.0, eslint-plugin-unused-imports@npm:^4.2.0":
78637854
version: 4.3.0
78647855
resolution: "eslint-plugin-unused-imports@npm:4.3.0"
78657856
peerDependencies:
@@ -7896,7 +7887,7 @@ __metadata:
78967887
languageName: node
78977888
linkType: hard
78987889

7899-
"eslint@npm:^9.17.0, eslint@npm:^9.18.0":
7890+
"eslint@npm:^9.18.0, eslint@npm:^9.37.0":
79007891
version: 9.39.2
79017892
resolution: "eslint@npm:9.39.2"
79027893
dependencies:

0 commit comments

Comments
 (0)