Skip to content

Commit 3904648

Browse files
author
Luca Bassani
committed
feat: version bumped and adjustment needed on the printed table
1 parent bf19a1a commit 3904648

7 files changed

Lines changed: 4775 additions & 5472 deletions

File tree

.eslintrc.cjs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
module.exports = {
22
extends: ['eslint-config-salesforce-typescript', 'plugin:sf-plugin/recommended'],
3+
ignorePatterns: [
4+
'.eslintrc.cjs',
5+
'dist',
6+
'node_modules'
7+
]
38
};

package.json

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,22 @@
44
"version": "1.1.3",
55
"author": "Luca Bassani",
66
"dependencies": {
7-
"@oclif/core": "^3.22.0",
8-
"@salesforce/core": "^6.7.0",
9-
"@salesforce/sf-plugins-core": "^7.1.14",
10-
"@salesforce/source-deploy-retrieve": "^10.5.1"
7+
"@oclif/core": "^4",
8+
"@salesforce/core": "^8.25.1",
9+
"@salesforce/sf-plugins-core": "^12.2.6",
10+
"@salesforce/source-deploy-retrieve": "^12.32.1",
11+
"@salesforce/kit": "^3.2.4",
12+
"@salesforce/ts-types": "^2.0.12"
1113
},
1214
"devDependencies": {
13-
"@oclif/plugin-command-snapshot": "^5.1.0",
14-
"@salesforce/cli-plugins-testkit": "^5.1.10",
15-
"@salesforce/dev-scripts": "^8.4.2",
16-
"@types/mocha": "^10.0.6",
17-
"eslint-plugin-sf-plugin": "^1.17.4",
18-
"oclif": "^4.5.0",
19-
"shx": "^0.3.4",
15+
"@oclif/plugin-command-snapshot": "^5.3.15",
16+
"@salesforce/cli-plugins-testkit": "^5.3.52",
17+
"@salesforce/dev-scripts": "^11.0.4",
18+
"@salesforce/plugin-command-reference": "^3.1.88",
19+
"eslint-plugin-sf-plugin": "^1.20.33",
20+
"oclif": "^4.22.96",
2021
"ts-node": "^10.9.2",
21-
"typescript": "^5.3.3"
22+
"typescript": "^5.9.3"
2223
},
2324
"engines": {
2425
"node": ">=18.0.0"

src/commands/analytics/connected-objects/upsert.ts

Lines changed: 21 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Messages.importMessagesDirectoryFromMetaUrl(import.meta.url);
1010
const messages = Messages.loadMessages('plugin-analytics-connected-objects', 'connected-objects.upsert');
1111
const common = Messages.loadMessages('plugin-analytics-connected-objects', 'common');
1212

13-
export interface ConnectedObjectUpsertResult {
13+
export type ConnectedObjectUpsertResult = {
1414
[key: string]: string | boolean | string[] | number | undefined;
1515
objectName: string;
1616
connectorName: string;
@@ -185,24 +185,25 @@ export default class ConnectedObjectsUpsert extends SfCommand<ConnectedObjectUps
185185
}
186186

187187
private printConnectionUpgradeResult(records: ConnectedObjectUpsertResult[], verbose: boolean): void {
188-
this.table(
189-
records,
190-
{
191-
objectName: { header: 'OBJECT' },
192-
connectorName: { header: 'CONNECTOR' },
193-
isNEW: {
194-
header: 'OPERATION',
195-
get: (data): string => (data.isNew ? 'Create' : 'Update'),
196-
},
197-
fieldsCount: { header: 'FIELDSCOUNT' },
198-
fields: {
199-
header: 'FIELDS',
200-
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
201-
get: (data): string => PrinterHelper.printFieldsMultiline(data.fields!, 60),
202-
extended: !verbose,
203-
},
204-
},
205-
{ title: 'Changed connected-objects' }
206-
);
188+
const columns = [
189+
{ key: 'objectName', name: 'OBJECT' },
190+
{ key: 'connectorName', name: 'CONNECTOR' },
191+
{ key: 'operation', name: 'OPERATION' },
192+
{ key: 'fieldsCount', name: 'FIELDSCOUNT' },
193+
{ key: 'fields', name: 'FIELDS' }
194+
];
195+
for(const record of records) {
196+
record.operation = record.isNew ? 'Created' : 'Updated';
197+
}
198+
if (verbose) {
199+
columns.push({ key: 'connectorName', name: 'CONNECTOR' });
200+
for(const record of records) {
201+
record.fieldDetails = PrinterHelper.printFieldsMultiline(record.fields!, 60);
202+
}
203+
}
204+
this.table({
205+
data: records,
206+
columns
207+
});
207208
}
208209
}

test/commands/analytics/connected-objects/upsert.nut.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ describe('analytics connected-objects upsert NUTs', () => {
3838
connectorName: 'SFDC_LOCAL',
3939
objectName: 'User',
4040
isNew: true,
41+
operation: 'Created',
4142
fields: ['Id', 'Username'],
4243
fieldsCount: 2,
4344
},
@@ -55,6 +56,7 @@ describe('analytics connected-objects upsert NUTs', () => {
5556
connectorName: 'SFDC_LOCAL',
5657
objectName: 'User',
5758
isNew: false,
59+
operation: 'Updated',
5860
fields: [
5961
'LastName',
6062
'FirstName',
@@ -75,6 +77,7 @@ describe('analytics connected-objects upsert NUTs', () => {
7577
connectorName: 'SFDC_LOCAL',
7678
objectName: 'Profile',
7779
isNew: true,
80+
operation: 'Created',
7881
fields: ['Id', 'Name'],
7982
fieldsCount: 2,
8083
},

test/commands/analytics/connected-objects/upsert.test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import path, { resolve } from 'node:path';
44
import { fileURLToPath } from 'node:url';
55
import { expect } from 'chai';
6-
import { TestContext, MockTestOrgData } from '@salesforce/core/lib/testSetup.js';
6+
import { TestContext, MockTestOrgData } from '@salesforce/core/testSetup';
77
import { ensureJsonMap, AnyJson } from '@salesforce/ts-types';
88
import { Config } from '@oclif/core';
99
import { ComponentSet, ComponentSetBuilder, LazyCollection, SourceComponent } from '@salesforce/source-deploy-retrieve';
@@ -63,6 +63,7 @@ describe('analytics recipe run', () => {
6363
{
6464
objectName: 'User',
6565
isNew: true,
66+
operation: 'Created',
6667
fields: recipeFields,
6768
fieldsCount: recipeFields.length,
6869
connectorName: 'SFDC_LOCAL',
@@ -87,6 +88,7 @@ describe('analytics recipe run', () => {
8788
{
8889
objectName: 'User',
8990
isNew: false,
91+
operation: 'Updated',
9092
fields: [USERNAME],
9193
fieldsCount: 1,
9294
connectorName: 'SFDC_LOCAL',

test/tsconfig.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"extends": "@salesforce/dev-config/tsconfig-test-strict-esm",
33
"include": ["./**/*.ts"],
44
"compilerOptions": {
5-
"skipLibCheck": true,
6-
"strictNullChecks": true
5+
"types": ["mocha", "node"],
6+
"skipLibCheck": true
77
}
88
}

0 commit comments

Comments
 (0)