Problem Details - RFC 7807

More restful api

Author: brunobritodev

src/Backend/Jp.Application/AutoMapper/ViewModelToDomainMappingProfile.cs

@@ -55,7 +55,7 @@ public ViewModelToDomainMappingProfile()
             /*
              * Client commands
              */
-            CreateMap<ClientViewModel, UpdateClientCommand>().ConstructUsing(c => new UpdateClientCommand(c));
+            CreateMap<ClientViewModel, UpdateClientCommand>().ConstructUsing(c => new UpdateClientCommand(c, c.OldClientId));
             CreateMap<RemoveClientSecretViewModel, RemoveClientSecretCommand>().ConstructUsing(c => new RemoveClientSecretCommand(c.Id, c.ClientId));
             CreateMap<RemovePropertyViewModel, RemovePropertyCommand>().ConstructUsing(c => new RemovePropertyCommand(c.Id, c.ClientId));
             CreateMap<SaveClientSecretViewModel, SaveClientSecretCommand>().ConstructUsing(c => new SaveClientSecretCommand(c.ClientId, c.Description, c.Value, c.Type, c.Expiration, (int)c.Hash.GetValueOrDefault(HashType.Sha256)));

src/Backend/Jp.Application/Interfaces/IClientAppService.cs

@@ -11,7 +11,7 @@ public interface IClientAppService : IDisposable
     {
         Task<IEnumerable<ClientListViewModel>> GetClients();
         Task<Client> GetClientDetails(string clientId);
-        Task Update(string id, ClientViewModel client);
+        Task Update(ClientViewModel client);
         Task<IEnumerable<SecretViewModel>> GetSecrets(string clientId);
         Task RemoveSecret(RemoveClientSecretViewModel model);
         Task SaveSecret(SaveClientSecretViewModel model);

src/Backend/Jp.Application/Services/ClientAppService.cs

@@ -53,9 +53,9 @@ public async Task<Client> GetClientDetails(string clientId)
             return _mapper.Map<Client>(resultado);
         }
 
-        public Task Update(string id, ClientViewModel client)
+        public Task Update(ClientViewModel client)
         {
-            var updateClientCommand = _mapper.Map<UpdateClientCommand>(client).SetClientId(id);
+            var updateClientCommand = _mapper.Map<UpdateClientCommand>(client);
             return Bus.SendCommand(updateClientCommand);
         }
 

src/Backend/Jp.Application/ViewModels/ApiResouceViewModels/RemoveApiResourceViewModel.cs

@@ -4,6 +4,11 @@ namespace Jp.Application.ViewModels.ApiResouceViewModels
 {
     public class RemoveApiResourceViewModel
     {
+        public RemoveApiResourceViewModel(string name)
+        {
+            Name = name;
+        }
+
         [Required]
         public string Name { get; set; }
     }

src/Backend/Jp.Application/ViewModels/ApiResouceViewModels/RemoveApiScopeViewModel.cs

@@ -4,6 +4,12 @@ namespace Jp.Application.ViewModels.ApiResouceViewModels
 {
     public class RemoveApiScopeViewModel
     {
+        public RemoveApiScopeViewModel(string resourceName, int id)
+        {
+            ResourceName = resourceName;
+            Id = id;
+        }
+
         [Required]
         public int Id { get; set; }
         [Required]

src/Backend/Jp.Application/ViewModels/ApiResouceViewModels/RemoveApiSecretViewModel.cs

@@ -5,6 +5,12 @@ namespace Jp.Application.ViewModels.ApiResouceViewModels
 
     public class RemoveApiSecretViewModel
     {
+        public RemoveApiSecretViewModel(string resourceName, in int id)
+        {
+            ResourceName = resourceName;
+            Id = id;
+        }
+
         [Required]
         public int Id { get; set; }
         [Required]

src/Backend/Jp.Application/ViewModels/ApiResouceViewModels/SaveApiSecretViewModel.cs

@@ -13,7 +13,7 @@ public class SaveApiSecretViewModel
         public HashType? Hash { get; set; } = 0;
         [Required]
         public string Type { get; set; }
-        [Required]
+
         public string ResourceName { get; set; }
     }
 }

src/Backend/Jp.Application/ViewModels/ClientsViewModels/ClientViewModel.cs

@@ -4,5 +4,6 @@ namespace Jp.Application.ViewModels.ClientsViewModels
 {
     public class ClientViewModel : Client
     {
+        public string OldClientId { get; set; }
     }
 }

src/Backend/Jp.Application/ViewModels/IdentityResourceViewModels/RemoveIdentityResourceViewModel.cs

@@ -4,6 +4,11 @@ namespace Jp.Application.ViewModels.IdentityResourceViewModels
 {
     public class RemoveIdentityResourceViewModel
     {
+        public RemoveIdentityResourceViewModel(string name)
+        {
+            Name = name;
+        }
+
         [Required]
         public string Name { get; set; }
     }

src/Backend/Jp.Domain/Commands/Clients/UpdateClientCommand.cs

@@ -1,11 +1,13 @@
+using IdentityServer4.Models;
 using Jp.Domain.Validations.Client;
 
 namespace Jp.Domain.Commands.Clients
 {
     public class UpdateClientCommand : ClientCommand
     {
-        public UpdateClientCommand(IdentityServer4.Models.Client client)
+        public UpdateClientCommand(Client client, string oldClientId)
         {
+            OldClientId = oldClientId;
             this.Client = client;
         }
 
@@ -16,10 +18,5 @@ public override bool IsValid()
             return ValidationResult.IsValid;
         }
 
-        public UpdateClientCommand SetClientId(string id)
-        {
-            OldClientId = id;
-            return this;
-        }
     }
 }