Skip to content

Commit 128afd4

Browse files
fix: missing async usage, debug options reading
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
1 parent 49a05a5 commit 128afd4

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

src/componentize.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,9 @@ export async function componentize(
118118
aotCache = DEFAULT_AOT_CACHE,
119119
} = opts;
120120

121-
debugBindings = debugBindings || debug?.bindings;
122-
debugBuild = debugBuild || debug?.build;
123-
enableWizerLogging = enableWizerLogging || debug?.enableWizerLogging;
121+
debugBindings = debugBindings ?? debug?.bindings;
122+
debugBuild = debugBuild ?? debug?.build;
123+
enableWizerLogging = enableWizerLogging ?? debug?.enableWizerLogging;
124124

125125
// Determine the path to the StarlingMonkey binary
126126
const engine = getEnginePath(opts);
@@ -356,7 +356,12 @@ export async function componentize(
356356
}
357357

358358
/// Process output of check init, throwing if necessary
359-
handleCheckInitOutput(check_init(), initializerPath, workDir, getStderr);
359+
await handleCheckInitOutput(
360+
check_init(),
361+
initializerPath,
362+
workDir,
363+
getStderr,
364+
);
360365

361366
// After wizening, stub out the wasi imports depending on what features are enabled
362367
const finalBin = stubWasi(
@@ -558,7 +563,7 @@ async function initWasm(bin) {
558563
* @param {string} workDir
559564
* @param {() => string} getStderr - A function that resolves to the stderr output of check init
560565
*/
561-
function handleCheckInitOutput(
566+
async function handleCheckInitOutput(
562567
status,
563568
initializerPath,
564569
workDir,

0 commit comments

Comments
 (0)