fix: apply clippy fixes

Author: andreiltd

crates/spidermonkey-embedding-splicer/src/bindgen.rs

@@ -1117,13 +1117,12 @@ impl EsmBindgen {
             } else {
                 expt_name
             };
-            if let Some(alias) = interface_name_from_string(expt_name_sans_version) {
-                if !self.exports.contains_key(&alias)
+            if let Some(alias) = interface_name_from_string(expt_name_sans_version)
+                && !self.exports.contains_key(&alias)
                     && !self.export_aliases.values().any(|_alias| &alias == _alias)
                 {
                     self.export_aliases.insert(expt_name.to_string(), alias);
                 }
-            }
         }
     }
 
@@ -1292,12 +1291,12 @@ fn interface_name_from_string(name: &str) -> Option<String> {
     let name = &name[path_idx + 1..];
     let at_idx = name.rfind('@');
     let alias = name[..at_idx.unwrap_or(name.len())].to_lower_camel_case();
-    let iface_name = Some(if let Some(at_idx) = at_idx {
+
+    Some(if let Some(at_idx) = at_idx {
         format!("{alias}_{}", name[at_idx + 1..].replace(['.', '-'], "_"))
     } else {
         alias
-    });
-    iface_name
+    })
 }
 
 fn binding_name(func_name: &str, iface_name: &Option<String>) -> String {

crates/spidermonkey-embedding-splicer/src/splice.rs

@@ -563,11 +563,11 @@ fn synthesize_import_functions(
 
             // stack the return arg now as it chains with the
             // args we're about to add to the stack
-            if impt_sig.ret.is_some() {
+            if let Some(ret) = impt_sig.ret {
                 func.local_get(vp_arg);
 
                 // if an i64 return, then we need to stack the extra BigInt constructor arg for that now
-                if matches!(impt_sig.ret.unwrap(), CoreTy::I64) {
+                if matches!(ret, CoreTy::I64) {
                     func.local_get(ctx_arg);
                 }
             }
@@ -726,7 +726,7 @@ fn synthesize_import_functions(
 
         // create imported function table
         let els = module.elements.iter_mut().next().unwrap();
-        if let ElementItems::Functions(ref mut funcs) = &mut els.items {
+        if let ElementItems::Functions(funcs) = &mut els.items {
             for fid in import_fnids {
                 funcs.push(fid);
             }