fix: disable http by default (#121)

Author: Guy Bedford

README.md

@@ -144,12 +144,16 @@ export function componentize(jsSource: string, opts: {
   engine?: string,
   preview2Adapter?: string,
   disableFeatures?: ('stdio' | 'random' | 'clocks')[],
+  enableFeatures?: ('http')[],
 }): {
   component: Uint8Array,
   imports: string[]
 }
 ```
 
+`http` provides support for the host APIs used by the `fetch` method and is disabled by default,
+while this API is still being developed. Contributions very welcome to improve `fetch` support.
+
 Converts a JS source into a component binary.
 
 Imports provides the list of used guest imports only, while the StarlingMonkey engine may pull in additional

src/componentize.js

@@ -88,7 +88,7 @@ export async function componentize(jsSource, witWorld, opts) {
   if (!disableFeatures.includes('clocks')) {
     features.push('clocks');
   }
-  if (!disableFeatures.includes('http')) {
+  if (enableFeatures.includes('http')) {
     features.push('http');
   }
 

test/cases/http-request/test.js

@@ -1,5 +1,7 @@
 import { ok } from 'node:assert';
 
+export const enableFeatures = ['http'];
+
 export function test (instance) {
   ok(instance.getResult().includes('"content-type":"text/html'));
   ok(instance.getResult().includes('WebAssembly'));

test/test.js

@@ -141,17 +141,19 @@ suite('Bindings', () => {
 
       const test = await import(`./cases/${name}/test.js`);
 
+      const enableFeatures = test.enableFeatures || [];
+      const disableFeatures = test.disableFeatures || (isWasiTarget ? [] : ['random', 'clocks', 'http', 'stdio']);
+
       let testArg;
       try {
-        const { component, imports, exports } = await componentize(source, {
+        const { component, imports } = await componentize(source, {
           sourceName: `${name}.js`,
           witWorld,
           witPath,
           worldName,
-          disableFeatures: isWasiTarget ? [] : ['random', 'clocks', 'http', 'stdio']
+          enableFeatures,
+          disableFeatures
         });
-        testArg = { imports, exports };
-
         const map = {
           'wasi:cli-base/*': '@bytecodealliance/preview2-shim/cli-base#*',
           'wasi:clocks/*': '@bytecodealliance/preview2-shim/clocks#*',
@@ -170,13 +172,15 @@ suite('Bindings', () => {
           map[impt] = `../../cases/${name}/${importName}.js`;
         }
 
-        const { files } = await transpile(component, {
+        const { files, imports: componentImports, exports: componentExports } = await transpile(component, {
           name,
           map,
           wasiShim: true,
           validLiftingOptimization: false,
         });
 
+        testArg = { imports, componentImports, componentExports };
+
         await mkdir(new URL(`./output/${name}/interfaces`, import.meta.url), {
           recursive: true,
         });